feat(search): cutover to MAF runtime

[Cataldir]

Problem statement

Migrate the search-enrichment-agent bounded context (single service) from the legacy BaseRetailAgent runtime internals to the MAF-backed runtime introduced in #981. This is the smallest single-service context in R1 and serves as a clean validation of the seam after the larger truth-* migration.

This is a hard sunset: legacy runtime imports are deleted in the same PR. There is no coexistence flag.

Required change

For search-enrichment-agent:

• Replace usage of lib/src/holiday_peak_lib/agents/ internals with the public surface backed by the MAF runtime from feat(lib): MAF runtime adapter behind the existing BaseRetailAgent surface #981.
• Update main.py and the agent definition to use the MAF-backed seam.
• MCP tool registrations via FastAPIMCPServer remain unchanged in signature; only the underlying runtime changes.
• REST endpoints (/search, /enrich) remain unchanged in shape; migration is internal.
• Per-service Foundry config (FOUNDRY_AGENT_ID_FAST, MODEL_DEPLOYMENT_NAME_FAST, FOUNDRY_AGENT_ID_RICH, MODEL_DEPLOYMENT_NAME_RICH, FOUNDRY_STREAM, PROJECT_ENDPOINT) wired via Helm values + Key Vault refs.
• Three-tier memory bound per ADR-032 (PR docs(adr): ADR-029..033 - architecture contracts (canary, MCP A2A, OTEL, memory, UI on SWA) #978).
• MCP-only A2A enforced (ADR-030, PR docs(adr): ADR-029..033 - architecture contracts (canary, MCP A2A, OTEL, memory, UI on SWA) #978); hop counter wired.
• Delete pre-MAF imports in the same PR.

Affected components

• apps/search-enrichment-agent
• apps/search-enrichment-agent/src
• apps/search-enrichment-agent/tests

Acceptance criteria (per spec — Acceptance gate per bounded context)

• Contract tests in lib/tests pass.
• All apps/search-enrichment-agent unit and integration tests pass.
• Continuous eval baseline (per ADR-028 final schema, PR Add continuous agent evaluation engine #974) within maxDeltaPercent for the agent in this context (advisory until PR Add continuous agent evaluation engine #974 merges).
• AGC canary 5 → 25 → 50 → 100 succeeds in dev, then in staging (per ADR-029, PR docs(adr): ADR-029..033 - architecture contracts (canary, MCP A2A, OTEL, memory, UI on SWA) #978).
• No A2A HTTP detected by scripts/ci/lint_no_a2a_http.py (per ADR-030, PR docs(adr): ADR-029..033 - architecture contracts (canary, MCP A2A, OTEL, memory, UI on SWA) #978).
• Span attribute contract validated by App Insights workbook query (per ADR-031, PR docs(adr): ADR-029..033 - architecture contracts (canary, MCP A2A, OTEL, memory, UI on SWA) #978).
• No pre-MAF imports remain in apps/search-enrichment-agent/src.
• Per-service Foundry config wired via Helm values + Key Vault refs.
• 24-hour steady-state hold satisfied before the next context's PR opens.

Risks and dependencies

Risk	Mitigation
Search relevance regresses on cutover (vector / semantic search behavior).	Eval baselines specifically cover search relevance metrics; regressions outside maxDeltaPercent halt the canary.
MCP A2A introduces extra latency on enrichment hops.	Measured pre/post; tolerance P95 within 10 %. Outside tolerance halts the canary.
Reach-through into BaseRetailAgent internals.	Pre-flight grep blocks cutover until refactored.
Foundry agent ID provisioning fails.	Provisioning runs ahead of this PR; failure halts this context.

Blocked by:

• feat(lib): MAF runtime adapter behind the existing BaseRetailAgent surface #981 (lib MAF runtime seam).
• feat(truth): cutover to MAF runtime #983 (truth-* cutover — preceding context per the R1 cutover order).

Blocks: the next context (crm-*) per the R1 sequencing rule.

Evidence links

• apps/search-enrichment-agent
• apps/search-enrichment-agent/src
• apps/search-enrichment-agent/tests
• apps/search-enrichment-agent/README.md
• lib/src/holiday_peak_lib/agents/base_agent.py

ADR impact

• ADR-007 (memory tiers) — refined by ADR-032 (PR docs(adr): ADR-029..033 - architecture contracts (canary, MCP A2A, OTEL, memory, UI on SWA) #978).
• ADR-023 (search-enrichment bounded context) — preserved; internal migration only.
• ADR-024 → ADR-030 (PR docs(adr): ADR-029..033 - architecture contracts (canary, MCP A2A, OTEL, memory, UI on SWA) #978): MCP-only A2A enforced.
• ADR-029 (PR docs(adr): ADR-029..033 - architecture contracts (canary, MCP A2A, OTEL, memory, UI on SWA) #978): AGC canary gates the cutover.
• ADR-031 (PR docs(adr): ADR-029..033 - architecture contracts (canary, MCP A2A, OTEL, memory, UI on SWA) #978): span attribute contract validated.

Branch convention

feature/<issue-id>-search-maf-cutover (per ADR-018).

BPMN process

%%{init: {'theme':'base', 'themeVariables': {
  'primaryColor':'#FFB3BA',
  'primaryTextColor':'#000',
  'primaryBorderColor':'#FF8B94',
  'lineColor':'#BAE1FF',
  'secondaryColor':'#BAE1FF',
  'tertiaryColor':'#FFFFFF'
}}}%%
flowchart LR
  A[Analyze Current Code] --> B[Design Change]
  B --> C[Implement on Issue Branch]
  C --> D[Open PR]
  D --> E[Validation and Fixes]
  E --> F[Merge to Main]
  F --> G[Monitor Workflows]
  G --> H[Close Issue and Cleanup]

Loading