Skip to content

Domaintools CCF - #14752

Merged
v-atulyadav merged 4 commits into
Azure:masterfrom
RamboV:DomaintoolsCCF2
Aug 6, 2026
Merged

Domaintools CCF#14752
v-atulyadav merged 4 commits into
Azure:masterfrom
RamboV:DomaintoolsCCF2

Conversation

@RamboV

Copy link
Copy Markdown
Contributor

Required items, please complete

Change(s):

Added new DomainTools CCF Connector
Reason for Change(s):

New Domain Tools TI CCF Connector
Version Updated:

None
Testing Completed:

Yes
Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new DomainTools CCF Microsoft Sentinel solution package, including a CCF data connector, workbook, parsers, and analytic rules.

Changes:

  • Added DomainTools CCF solution metadata, release notes, package ARM templates, and createUiDefinition.
  • Added CCF data connector definition + poller/DCR/table artifacts, plus workbook and parser.
  • Updated global workbook metadata and test validation assets (valid connector IDs, custom table/function schemas).

Reviewed changes

Copilot reviewed 20 out of 24 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
Workbooks/WorkbooksMetadata.json Registers the new DomainTools workbook in the shared workbook catalog.
Solutions/DomainTools CCF/Workbooks/DomainTools_workbook.json Adds the DomainTools Threat Intelligence workbook content and KQL visuals.
Solutions/DomainTools CCF/SolutionMetadata.json Defines solution publisher, offer, support, and categorization metadata.
Solutions/DomainTools CCF/ReleaseNotes.md Introduces initial release notes entry for the solution.
Solutions/DomainTools CCF/Parsers/DomainToolsThreatIntelDomains.yaml Adds a KQL function/parser for DomainTools threat domain data.
Solutions/DomainTools CCF/Package/testParameters.json Adds test parameters for ARM/TTK validation and workbook naming.
Solutions/DomainTools CCF/Package/mainTemplate.json Adds the deployable ARM template packaging connector/workbook/rules/parser.
Solutions/DomainTools CCF/Package/createUiDefinition.json Adds Azure Marketplace/Portal UI definition for solution installation.
Solutions/DomainTools CCF/Data/Solution_DomainTools.json Adds solution manifest referencing included artifacts (rules, workbook, connector, parser).
Solutions/DomainTools CCF/Data Connectors/DomainToolsFeedsLogs_ccf/DomainToolsFeedsLogs_connectorDefinition.json Adds the CCF connector definition (UI + permissions + instructions).
Solutions/DomainTools CCF/Data Connectors/DomainToolsFeedsLogs_ccf/DomainToolsFeedsLogs_Table.json Adds the custom table schema for ingested DomainTools domains.
Solutions/DomainTools CCF/Data Connectors/DomainToolsFeedsLogs_ccf/DomainToolsFeedsLogs_PollerConfig.json Adds poller configurations for NOD/NAD/NOH/DD feeds.
Solutions/DomainTools CCF/Data Connectors/DomainToolsFeedsLogs_ccf/DomainToolsFeedsLogs_DCR.json Adds the DCR that maps feed streams into the final custom table.
Solutions/DomainTools CCF/Analytic Rules/DomainTools_NewlyObservedHostnames-NOH.yaml Adds scheduled analytic rule for NOH feed ingestion.
Solutions/DomainTools CCF/Analytic Rules/DomainTools_NewlyObservedDomains-NOD.yaml Adds scheduled analytic rule for NOD feed ingestion.
Solutions/DomainTools CCF/Analytic Rules/DomainTools_NewlyAddedDomains-NAD.yaml Adds scheduled analytic rule for NAD feed ingestion.
Solutions/DomainTools CCF/Analytic Rules/DomainTools_DomainDiscovery-DD.yaml Adds scheduled analytic rule for Domain Discovery feed ingestion.
.script/tests/detectionTemplateSchemaValidation/ValidConnectorIds.json Adds DomainTools as a valid connectorId for analytic rule validation.
.script/tests/KqlvalidationsTests/CustomTables/DomainToolsThreatIntelDomains_CL.json Adds custom table schema for KQL validation tests.
.script/tests/KqlvalidationsTests/CustomFunctions/DomainToolsThreatIntelDomains.json Adds custom function schema for KQL validation tests.

Comment thread Solutions/DomainTools CCF/Package/mainTemplate.json
Comment thread Solutions/DomainTools CCF/Package/mainTemplate.json
Comment thread Solutions/DomainTools CCF/Package/mainTemplate.json
Comment thread Solutions/DomainTools CCF/Package/mainTemplate.json
Comment thread Solutions/DomainTools CCF/Package/mainTemplate.json
Comment thread Solutions/DomainTools CCF/Data/Solution_DomainTools.json
Comment thread Solutions/DomainTools CCF/ReleaseNotes.md
Comment thread Solutions/DomainTools CCF/Analytic Rules/DomainTools_NewlyAddedDomains-NAD.yaml Outdated
Comment thread Solutions/DomainTools CCF/Package/mainTemplate.json
@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi Rambatla Venkat Rao (@RamboV),
Please review the suggestions above and implement the necessary changes accordingly.
Additionally, please share screenshots confirming that the connector has been connected successfully, along with the corresponding invocation logs. Thanks

@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi Rambatla Venkat Rao (@RamboV),
Please review the suggestions above and implement the necessary changes accordingly.

Additionally, please share screenshots confirming that the connector has been connected successfully, along with the corresponding invocation logs for verification. Thanks

@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi Rambatla Venkat Rao (@RamboV),
Please review the comments above and take the necessary action accordingly. Thanks

@RamboV

Copy link
Copy Markdown
Contributor Author

Hi v-atulyadav I am working on it will Update you Today.
Thanks

@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Aug 5, 2026
@RamboV

Rambatla Venkat Rao (RamboV) commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Hi v-atulyadav, Please find the screenshots below. Thanks
image

Screenshot from 2026-08-05 13-51-53 Screenshot from 2026-08-05 13-47-41

@RamboV

Rambatla Venkat Rao (RamboV) commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Hi v-atulyadav, The error in workbook validation is failing can you please check as its not related to this project.
"""24 files changed in current PR
1 files changed in current PR after filter. File Type Filter: WorkbooksMetadata.json, File path Filter: Workbooks, File Kind Filter: Modified
WorkbooksMetadata Validation Failed. File path: Workbooks/WorkbooksMetadata.json. Error message: Can't locate logo image file MicrosoftADTierModel.svg under the Workbooks/Images/Logos directory"""".

Please let me know what should be our next step.

Thanks

@RamboV

Copy link
Copy Markdown
Contributor Author

Hi v-atulyadav,
Need you assistance on this issue as the logo not found error is not related to our Solution.
Thanks

@RamboV

Rambatla Venkat Rao (RamboV) commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Hi v-atulyadav, All checks have passed successfully. Please review and merge.
Thanks

@v-atulyadav
v-atulyadav merged commit 67a8ee6 into Azure:master Aug 6, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants