tsp - Add test case for databox (#1533)

Author: dolauli

packages/typespec-powershell/src/utils/modelUtils.ts

@@ -989,7 +989,7 @@ function getSchemaForModel(
     } else {
       // If discriminator value is union variant, it will be constant type
       // Otherwise, it will be sealed choice type
-      modelSchema.discriminatorValue = propSchema.type === 'constant' ? (<ConstantSchema>propSchema).value.value : (<SealedChoiceSchema>propSchema).choices[0].value.toString();
+      modelSchema.discriminatorValue = propSchema.type === 'constant' ? (<ConstantSchema>propSchema).value.value : (propSchema.value ? propSchema.value : (<SealedChoiceSchema>propSchema).choices[0].value.toString());
     }
     if (discriminator && propName === discriminator.propertyName) {
       property.isDiscriminator = true;

tests-upgrade/tests-emitter/DataBox.Management.brown/JobResource.tsp

@@ -0,0 +1,200 @@
+import "@azure-tools/typespec-azure-core";
+import "@azure-tools/typespec-azure-resource-manager";
+import "@typespec/openapi";
+import "@typespec/rest";
+import "./models.tsp";
+
+using TypeSpec.Rest;
+using Azure.ResourceManager;
+using TypeSpec.Http;
+using TypeSpec.OpenAPI;
+
+namespace Microsoft.DataBox;
+/**
+ * Job Resource.
+ */
+model JobResource
+  is Azure.ResourceManager.TrackedResource<JobProperties, false> {
+  ...ResourceNameParameter<
+    Resource = JobResource,
+    KeyName = "jobName",
+    SegmentName = "jobs",
+    NamePattern = "^[-\\w\\.]+$"
+  >;
+
+  /**
+   * The sku type.
+   */
+  #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+  sku: Sku;
+
+  /**
+   * Msi identity of the resource
+   */
+  #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+  identity?: ResourceIdentity;
+}
+
+@armResourceOperations
+interface JobResources {
+  /**
+   * Gets information about the specified job.
+   */
+  get is ArmResourceRead<
+    JobResource,
+    Parameters = {
+      /**
+       * $expand is supported on details parameter for job, which provides details on the job stages.
+       */
+      @query("$expand")
+      $expand?: string;
+    },
+    Error = ApiError
+  >;
+
+  /**
+   * Creates a new job with the specified parameters. Existing job cannot be updated with this API and should instead be updated with the Update job API.
+   */
+  #suppress "@azure-tools/typespec-azure-resource-manager/arm-put-operation-response-codes" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+  create is ArmResourceCreateOrReplaceAsync<
+    JobResource,
+    Response = ArmResourceUpdatedResponse<JobResource> | ArmAcceptedLroResponse<LroHeaders = ArmLroLocationHeader<FinalResult = JobResource> &
+      Azure.Core.Foundations.RetryAfterHeader>,
+    Error = ApiError
+  >;
+
+  /**
+   * Updates the properties of an existing job.
+   */
+  #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-patch" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+  @patch(#{ implicitOptionality: false })
+  update is ArmCustomPatchAsync<
+    JobResource,
+    PatchModel = JobResourceUpdateParameter,
+    Parameters = {
+      /**
+       * Defines the If-Match condition. The patch will be performed only if the ETag of the job on the server matches this value.
+       */
+      #suppress "@azure-tools/typespec-azure-core/casing-style" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+      @header("If-Match")
+      `If-Match`?: string;
+    },
+    Error = ApiError
+  >;
+
+  /**
+   * Deletes a job.
+   */
+  #suppress "@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+  delete is ArmResourceDeleteWithoutOkAsync<
+    JobResource,
+    Response = ArmDeletedResponse | ArmDeleteAcceptedLroResponse | ArmDeletedNoContentResponse,
+    Error = ApiError
+  >;
+
+  /**
+   * Lists all the jobs available under the given resource group.
+   */
+  listByResourceGroup is ArmResourceListByParent<
+    JobResource,
+    Parameters = {
+      /**
+       * $skipToken is supported on Get list of jobs, which provides the next page in the list of jobs.
+       */
+      @query("$skipToken")
+      $skipToken?: string;
+    },
+    Response = ArmResponse<JobResourceList>,
+    Error = ApiError
+  >;
+
+  /**
+   * Lists all the jobs available under the subscription.
+   */
+  list is ArmListBySubscription<
+    JobResource,
+    Parameters = {
+      /**
+       * $skipToken is supported on Get list of jobs, which provides the next page in the list of jobs.
+       */
+      @query("$skipToken")
+      $skipToken?: string;
+    },
+    Response = ArmResponse<JobResourceList>,
+    Error = ApiError
+  >;
+
+  /**
+   * Book shipment pick up.
+   */
+  bookShipmentPickUp is ArmResourceActionSync<
+    JobResource,
+    ShipmentPickUpRequest,
+    ArmResponse<ShipmentPickUpResponse>,
+    Error = ApiError
+  >;
+
+  /**
+   * CancelJob.
+   */
+  cancel is ArmResourceActionSync<
+    JobResource,
+    CancellationReason,
+    NoContentResponse,
+    Error = ApiError
+  >;
+
+  /**
+   * This method gets the unencrypted secrets related to the job.
+   */
+  @list
+  listCredentials is ArmResourceActionSync<
+    JobResource,
+    void,
+    ArmResponse<UnencryptedCredentialsList>,
+    Error = ApiError
+  >;
+
+  /**
+   * Request to mark devices for a given job as shipped
+   */
+  markDevicesShipped is ArmResourceActionSync<
+    JobResource,
+    MarkDevicesShippedRequest,
+    NoContentResponse,
+    Error = ApiError
+  >;
+}
+
+/**
+ * Request to mitigate for a given job
+ */
+@action("mitigate")
+@tag("JobResources")
+op mitigate is ArmResourceActionSync<
+  JobResource,
+  MitigateJobRequest,
+  NoContentResponse,
+  Error = ApiError
+>;
+
+@@maxLength(JobResource.name, 24);
+@@minLength(JobResource.name, 3);
+@@doc(JobResource.name,
+  "The name of the job Resource within the specified resource group. job names must be between 3 and 24 characters in length and use any alphanumeric and underscore only"
+);
+@@doc(JobResource.properties, "Properties of a job.");
+@@doc(JobResources.create::parameters.resource,
+  "Job details from request body."
+);
+@@doc(JobResources.update::parameters.properties,
+  "Job update parameters from request body."
+);
+@@doc(JobResources.bookShipmentPickUp::parameters.body,
+  "Details of shipment pick up request."
+);
+@@doc(JobResources.cancel::parameters.body, "Reason for cancellation.");
+@@doc(JobResources.markDevicesShipped::parameters.body,
+  "Mark Devices Shipped Request"
+);
+@@doc(mitigate::parameters.body, "Mitigation Request");

tests-upgrade/tests-emitter/DataBox.Management.brown/back-compatible.tsp

@@ -0,0 +1,99 @@
+import "@azure-tools/typespec-client-generator-core";
+
+using Azure.ClientGenerator.Core;
+using Microsoft.DataBox;
+
+#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+@@Azure.ClientGenerator.Core.Legacy.flattenProperty(AddressValidationOutput.properties,
+  "!csharp"
+);
+
+#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+@@Azure.ClientGenerator.Core.Legacy.flattenProperty(ValidationResponse.properties
+);
+
+#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+@@Azure.ClientGenerator.Core.Legacy.flattenProperty(JobResourceUpdateParameter.properties
+);
+
+#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+@@Azure.ClientGenerator.Core.Legacy.flattenProperty(SkuInformation.properties);
+
+@@clientLocation(JobResources.get, "Jobs", "!csharp");
+
+@@clientLocation(JobResources.create, "Jobs", "!csharp");
+
+@@clientName(JobResources.create::parameters.resource, "jobResource");
+
+@@clientLocation(JobResources.update, "Jobs", "!csharp");
+
+@@clientName(JobResources.update::parameters.properties,
+  "jobResourceUpdateParameter"
+);
+
+@@clientLocation(JobResources.delete, "Jobs", "!csharp");
+
+@@clientLocation(JobResources.listByResourceGroup, "Jobs", "!csharp");
+
+@@clientLocation(JobResources.list, "Jobs", "!csharp");
+
+@@clientLocation(JobResources.bookShipmentPickUp, "Jobs", "!csharp");
+
+@@clientName(JobResources.bookShipmentPickUp::parameters.body,
+  "shipmentPickUpRequest"
+);
+
+@@clientLocation(JobResources.cancel, "Jobs", "!csharp");
+
+@@clientName(JobResources.cancel::parameters.body, "cancellationReason");
+
+@@clientLocation(JobResources.listCredentials, "Jobs", "!csharp");
+
+@@clientLocation(JobResources.markDevicesShipped, "Jobs", "!csharp");
+
+@@clientName(JobResources.markDevicesShipped::parameters.body,
+  "markDevicesShippedRequest"
+);
+
+@@clientName(mitigate::parameters.body, "mitigateJobRequest");
+
+#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+@@Azure.ClientGenerator.Core.Legacy.flattenProperty(JobResource.properties);
+
+@@clientLocation(ServiceOperationGroup.regionConfiguration,
+  "Service",
+  "!csharp"
+);
+
+@@clientLocation(ServiceOperationGroup.validateAddress, "Service", "!csharp");
+
+@@clientLocation(ServiceOperationGroup.validateInputs, "Service", "!csharp");
+
+@@clientLocation(ServiceOperationGroup.listAvailableSkusByResourceGroup,
+  "Service",
+  "!csharp"
+);
+
+@@clientLocation(ServiceOperationGroup.regionConfigurationByResourceGroup,
+  "Service",
+  "!csharp"
+);
+
+@@clientLocation(ServiceOperationGroup.validateInputsByResourceGroup,
+  "Service",
+  "!csharp"
+);
+
+@@clientName(ServiceOperationGroup.regionConfiguration::parameters.body,
+  "regionConfigurationRequest"
+);
+@@clientName(ServiceOperationGroup.validateAddress::parameters.body,
+  "validateAddress"
+);
+@@clientName(ServiceOperationGroup.validateInputs::parameters.body,
+  "validationRequest"
+);
+
+@@clientLocation(mitigate, "Management", "go");
+#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
+@@Azure.ClientGenerator.Core.Legacy.flattenProperty(Operation.properties);