Optimize_OS_for_AVD.ps1 Issues

[mikejwhat]

What happened? Provide a clear and concise description of the bug, including deployment details.

Hi,

Recently came across the following issues with this script:

• It downloads artifacts from another repo (The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool), but because it doesn't pin versions, subsequent commands are broken. Zip file downloaded here and a script here (I think downloading the script individually is redundant because it exists in the zip download)
• Due to the above, it is referencing the now non-existent 'Win10_VirtualDesktopOptimize.ps1' here and here
• It does not include the now-mandatory parameter 'Optimizations'

The changes to the Virtual-Desktop-Optimization-Tool repo are below in case it's useful:

The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool@76a1532

The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool@8a9d527

Please provide the correlation id associated with your error or bug.

N/A

What was the expected outcome?

Script to complete without errors. I found this issue after isolating the cause of a broken VM image version to this script (image template build completed and uploaded the image to our gallery successfully but then VM deployment failed - VM stuck on 'creating' then timed out).

Relevant log output

[danycontre]

@mikejwhat thanks for submitting the issue, we are reviewing.

@swathibhat1 @jamasten

[mikejwhat]

Additionally - the custom image template example in this repo runs this script before sysprep which this article advises against:

Note: We recommend that you run the script after the Sysprep (System Preparation) process, most likely as startup script w with a large set of virtual machines. This is due to the AppX Packages that conflict and most likely the sysprep will fail.

...and it doesn't use runElevated and runAsSystem as recommended here:

This article uses PowerShell customizer scripts. Use the following settings, or the build will stop responding

Ironically I'm finding that using runElevated and runAsSystem cause my builds to fail.