feat: enhance MCP server functionality with version support and fixed file URI handling

Author: cmendible

cmd/azqr/commands/mcpserver.go

@@ -36,6 +36,6 @@ Examples:
 	Args: cobra.NoArgs,
 	Run: func(cmd *cobra.Command, args []string) {
 		mode := mcpserver.ServerMode(mcpMode)
-		mcpserver.StartWithMode(mode, mcpAddr)
+		mcpserver.StartWithMode(mode, mcpAddr, version)
 	},
 }

internal/mcpserver/roots.go

@@ -6,36 +6,58 @@ package mcpserver
 import (
 	"context"
 	"fmt"
+	"net/url"
 	"os"
 	"strings"
 
 	"github.com/mark3labs/mcp-go/mcp"
 )
 
-func currentWorkspace(ctx context.Context) string {
-	result, err := s.RequestRoots(ctx, mcp.ListRootsRequest{})
-	if err == nil {
-		for _, root := range result.Roots {
-			uri := root.URI
-			if strings.HasPrefix(uri, "file://") {
-				return strings.TrimPrefix(uri, "file://")
-			}
-		}
+// fileURIToPath converts a file:// URI to a local filesystem path.
+// It handles both Unix paths (file:///home/user) and Windows paths
+// (file:///C:/Users, file:///c%3A/Users), decoding percent-encoded characters.
+func fileURIToPath(uri string) string {
+	if !strings.HasPrefix(uri, "file://") {
+		return uri
+	}
+
+	u, err := url.Parse(uri)
+	if err != nil {
+		// Fallback: strip "file://" and hope for the best
+		return strings.TrimPrefix(uri, "file://")
 	}
 
-	return ""
+	// url.Parse decodes percent-encoded characters (e.g. %3A → :) in u.Path.
+	path := u.Path
+
+	// On Windows, MCP clients emit file:///C:/... so the parsed path is /C:/...
+	// Strip the leading "/" before a Windows drive letter to get a valid path.
+	if len(path) >= 3 && path[0] == '/' && isASCIILetter(path[1]) && path[2] == ':' {
+		path = path[1:]
+	}
+
+	return path
 }
 
-func getCurrentFolder(ctx context.Context) (string, error) {
-	currentDir := currentWorkspace(ctx)
+// isASCIILetter reports whether b is an ASCII letter (a–z or A–Z).
+func isASCIILetter(b byte) bool {
+	return (b >= 'a' && b <= 'z') || (b >= 'A' && b <= 'Z')
+}
 
-	if currentDir != "" {
-		return currentDir, nil
+// getCurrentFolder returns the first file:// root reported by the MCP client,
+// or falls back to the process working directory.
+func getCurrentFolder(ctx context.Context) (string, error) {
+	if result, err := s.RequestRoots(ctx, mcp.ListRootsRequest{}); err == nil {
+		for _, root := range result.Roots {
+			if strings.HasPrefix(root.URI, "file://") {
+				return fileURIToPath(root.URI), nil
+			}
+		}
 	}
 
-	currentDir, err := os.Getwd()
+	dir, err := os.Getwd()
 	if err != nil {
 		return "", fmt.Errorf("failed to get current working directory: %w", err)
 	}
-	return currentDir, nil
+	return dir, nil
 }

internal/mcpserver/roots_tests.go

@@ -0,0 +1,112 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+package mcpserver
+
+import "testing"
+
+func TestFileURIToPath(t *testing.T) {
+	tests := []struct {
+		name  string
+		input string
+		want  string
+	}{
+		// ── Unix paths ──────────────────────────────────────────────────────
+		{
+			name:  "unix three-slash URI",
+			input: "file:///home/user/workspace",
+			want:  "/home/user/workspace",
+		},
+		{
+			name:  "unix three-slash URI with subdirectory",
+			input: "file:///var/log/ghqr",
+			want:  "/var/log/ghqr",
+		},
+
+		// ── Windows paths (uppercase drive letter) ──────────────────────────
+		{
+			name:  "windows three-slash URI uppercase drive",
+			input: "file:///C:/Users/gh/workspace",
+			want:  "C:/Users/gh/workspace",
+		},
+		{
+			name:  "windows three-slash URI uppercase Z drive",
+			input: "file:///Z:/Projects",
+			want:  "Z:/Projects",
+		},
+
+		// ── Windows paths (lowercase drive letter) ──────────────────────────
+		{
+			name:  "windows three-slash URI lowercase drive",
+			input: "file:///c:/Users/gh/workspace",
+			want:  "c:/Users/gh/workspace",
+		},
+
+		// ── Windows paths with percent-encoded colon (%3A) ──────────────────
+		// VS Code sends file:///c%3A/Users/... per Issue 1.
+		{
+			name:  "windows percent-encoded colon lowercase",
+			input: "file:///c%3A/Users/gh/workspace",
+			want:  "c:/Users/gh/workspace",
+		},
+		{
+			name:  "windows percent-encoded colon uppercase",
+			input: "file:///C%3A/Users/gh/workspace",
+			want:  "C:/Users/gh/workspace",
+		},
+
+		// ── Paths that are not file URIs ──────────────────────────────────
+		{
+			name:  "plain path passthrough",
+			input: "C:/Users/gh",
+			want:  "C:/Users/gh",
+		},
+		{
+			name:  "unix plain path passthrough",
+			input: "/home/user",
+			want:  "/home/user",
+		},
+
+		// ── Edge cases ───────────────────────────────────────────────────────
+		{
+			name:  "empty string",
+			input: "",
+			want:  "",
+		},
+		{
+			name:  "file URI with spaces (percent-encoded)",
+			input: "file:///home/user/my%20project",
+			want:  "/home/user/my project",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := fileURIToPath(tt.input)
+			if got != tt.want {
+				t.Errorf("fileURIToPath(%q) = %q, want %q", tt.input, got, tt.want)
+			}
+		})
+	}
+}
+
+func TestIsASCIILetter(t *testing.T) {
+	for b := byte('a'); b <= 'z'; b++ {
+		if !isASCIILetter(b) {
+			t.Errorf("isASCIILetter(%q) = false, want true", b)
+		}
+	}
+
+	for b := byte('A'); b <= 'Z'; b++ {
+		if !isASCIILetter(b) {
+			t.Errorf("isASCIILetter(%q) = false, want true", b)
+		}
+	}
+
+	nonLetters := []byte{'0', '9', ':', '/', '\\', ' ', '-', '_'}
+	for _, b := range nonLetters {
+		if isASCIILetter(b) {
+			t.Errorf("isASCIILetter(%q) = true, want false", b)
+		}
+	}
+}

internal/mcpserver/server.go

@@ -22,10 +22,15 @@ const (
 // StartWithMode starts the MCP server with the specified mode and address
 // mode: "stdio" for standard input/output, "http" for HTTP/SSE
 // addr: address to listen on (only used for HTTP mode, e.g., ":8080")
-func StartWithMode(mode ServerMode, addr string) {
+// version: version of the MCP server
+func StartWithMode(mode ServerMode, addr, version string) {
+	if version == "" {
+		version = "dev"
+	}
+	
 	s = server.NewMCPServer(
 		"Azure Quick Review 🚀",
-		"0.1.0",
+		version,
 		server.WithToolCapabilities(true), // Enable tool notifications
 		server.WithResourceCapabilities(true, true),
 		server.WithPromptCapabilities(true),

internal/mcpserver/tools.go

@@ -135,6 +135,8 @@ func withBasicOptions(opts ...mcp.ToolOption) []mcp.ToolOption {
 			mcp.DefaultBool(true),
 			mcp.Description("Mask sensitive data in output (default: true)."),
 		),
+		mcp.WithReadOnlyHintAnnotation(false),
+		mcp.WithDestructiveHintAnnotation(false),
 	}
 	return append(opts, basicOpts...)
 }