Skip to content

[AKS] chore: remove --skip-gpu-driver-install #8777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lilypan26 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[AKS] chore: remove --skip-gpu-driver-install #8777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82e7b22
update gpu driver install test
May 21, 2025
99f1c8f
remove skip-gpu-driver-install preview
May 21, 2025
52009dd
clean up --skip-gpu-driver-install references
May 21, 2025
ae0c5ac
fix test
May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ To release a new version, please select a new version number (usually plus 1 to
Pending
+++++++

18.0.0b3
Copy link
Member

@FumingZhang FumingZhang May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please choose a new major version like 19.0.0b1 as you're making a breaking change.

https://github.com/Azure/azure-cli/blob/release/doc/extensions/versioning_guidelines.md

+++++++
* [BREAKING CHANGE] Remove `--skip-gpu-driver-install` as it's deprecated.

18.0.0b2
+++++++
* Vendor new SDK and bump API version to 2025-03-02-preview.
Expand Down
3 changes: 0 additions & 3 deletions src/aks-preview/azext_aks_preview/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1830,9 +1830,6 @@
- name: --enable-artifact-streaming
type: bool
short-summary: Enable artifact streaming for VirtualMachineScaleSets managed by a node pool, to speed up the cold-start of containers on a node through on-demand image loading. To use this feature, container images must also enable artifact streaming on ACR. If not specified, the default is false.
- name: --skip-gpu-driver-install
type: bool
short-summary: To skip GPU driver auto installation by AKS on a nodepool using GPU vm size if customers want to manage GPU driver installation by their own. If not specified, the default is false.
- name: --gpu-driver
type: string
short-summary: Whether to install driver for GPU node pool. Possible values are "Install" or "None". Default is "Install".
Expand Down
10 changes: 0 additions & 10 deletions src/aks-preview/azext_aks_preview/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1563,16 +1563,6 @@ def load_arguments(self, _):
validator=validate_node_public_ip_tags,
help="space-separated tags: key[=value] [key[=value] ...].",
)
c.argument(
"skip_gpu_driver_install",
action="store_true",
is_preview=True,
deprecate_info=c.deprecate(
target="--skip-gpu-driver-install",
redirect="--gpu-driver",
hide=True
)
)
c.argument(
"gpu_driver",
arg_type=get_enum_type(gpu_driver_install_modes)
Expand Down
32 changes: 0 additions & 32 deletions src/aks-preview/azext_aks_preview/agentpool_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
CONST_DEFAULT_VMS_VM_SIZE,
CONST_DEFAULT_WINDOWS_VMS_VM_SIZE,
CONST_SSH_ACCESS_LOCALUSER,
CONST_GPU_DRIVER_NONE,
)
from azext_aks_preview._helpers import (
get_nodepool_snapshot_by_snapshot_id,
Expand Down Expand Up @@ -592,25 +591,6 @@ def _get_os_sku(self, read_only: bool = False) -> Union[str, None]:
# this parameter does not need validation
return os_sku

def get_skip_gpu_driver_install(self) -> bool:
"""Obtain the value of skip_gpu_driver_install.
:return: bool
"""

# read the original value passed by the command
skip_gpu_driver_install = self.raw_param.get("skip_gpu_driver_install")
# In create mode, try to read the property value corresponding to the parameter from the `agentpool` object
if self.decorator_mode == DecoratorMode.CREATE:
if (
self.agentpool and
self.agentpool.gpu_profile is not None and
self.agentpool.gpu_profile.driver is not None and
self.agentpool.gpu_profile.driver.lower() == CONST_GPU_DRIVER_NONE.lower()
):
skip_gpu_driver_install = True

return skip_gpu_driver_install

def _get_gpu_driver(self) -> Union[str, None]:
"""Obtain the value of gpu_driver.

Expand Down Expand Up @@ -944,16 +924,6 @@ def set_up_ssh_access(self, agentpool: AgentPool) -> AgentPool:
"option to disable SSH access for the node pool to make it more secure.")
return agentpool

def set_up_skip_gpu_driver_install(self, agentpool: AgentPool) -> AgentPool:
"""Set up install gpu driver property for the AgentPool object."""
self._ensure_agentpool(agentpool)

if self.context.get_skip_gpu_driver_install():
if agentpool.gpu_profile is None:
agentpool.gpu_profile = self.models.GPUProfile() # pylint: disable=no-member
agentpool.gpu_profile.driver = CONST_GPU_DRIVER_NONE
return agentpool

def set_up_gpu_profile(self, agentpool: AgentPool) -> AgentPool:
"""Set up gpu profile for the AgentPool object."""
self._ensure_agentpool(agentpool)
Expand Down Expand Up @@ -1077,8 +1047,6 @@ def construct_agentpool_profile_preview(self) -> AgentPool:
agentpool = self.set_up_init_taints(agentpool)
# set up artifact streaming
agentpool = self.set_up_artifact_streaming(agentpool)
# set up skip_gpu_driver_install
agentpool = self.set_up_skip_gpu_driver_install(agentpool)
# set up gpu profile
agentpool = self.set_up_gpu_profile(agentpool)
# set up driver_type
Expand Down
1 change: 0 additions & 1 deletion src/aks-preview/azext_aks_preview/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,7 +1217,6 @@ def aks_agentpool_add(
asg_ids=None,
node_public_ip_tags=None,
enable_artifact_streaming=False,
skip_gpu_driver_install=False,
gpu_driver=None,
driver_type=None,
ssh_access=CONST_SSH_ACCESS_LOCALUSER,
Expand Down
Loading
Loading