ServiceBus: Added validator for rights (#9886)

* added validator for rigths

* fixed logic

* updated history

Author: Ajit Navasare

src/azure-cli/HISTORY.rst

@@ -35,6 +35,10 @@ Release History
 * Fixed issue #8775 : Cannot create hybrid connection with disabled client authroization
 * Added parameter "--requires-transport-security" to az relay wcfrelay create
 
+**Servicebus**
+
+* Fix for issue #5824 - added validation for parameter --rights of authorizationrule commands
+
 **Storage**
 
 * Enable Files AADDS for storage account update.

src/azure-cli/azure/cli/command_modules/servicebus/_params.py

@@ -15,11 +15,11 @@ def load_arguments_sb(self, _):
     from azure.cli.command_modules.servicebus._validators import _validate_auto_delete_on_idle, \
         _validate_duplicate_detection_history_time_window, \
         _validate_default_message_time_to_live, \
-        _validate_lock_duration, validate_partner_namespace, validate_premiumsku_capacity, validate_target_namespace
+        _validate_lock_duration, validate_partner_namespace, validate_premiumsku_capacity, validate_target_namespace, validate_rights
 
     from knack.arguments import CLIArgumentType
     from azure.mgmt.servicebus.models import SkuName, AccessRights, KeyType, FilterType
-    rights_arg_type = CLIArgumentType(options_list=['--rights'], nargs='+', arg_type=get_enum_type(AccessRights), help='Space-separated list of Authorization rule rights')
+    rights_arg_type = CLIArgumentType(options_list=['--rights'], nargs='+', arg_type=get_enum_type(AccessRights), validator=validate_rights, help='Space-separated list of Authorization rule rights')
     key_arg_type = CLIArgumentType(options_list=['--key'], arg_type=get_enum_type(KeyType), help='specifies Primary or Secondary key needs to be reset')
     keyvalue_arg_type = CLIArgumentType(options_list=['--key-value'], help='Optional, if the key value provided, is set for KeyType or autogenerated Key value set for keyType.')
 

src/azure-cli/azure/cli/command_modules/servicebus/_validators.py

@@ -116,3 +116,9 @@ def validate_subnet(cmd, namespace):
     else:
         raise CLIError('incorrect usage: [--subnet ID | --subnet NAME --vnet-name NAME]')
     delattr(namespace, 'vnet_name')
+
+
+def validate_rights(namespace):
+    if 'Manage' in namespace.rights:
+        if 'Listen' not in namespace.rights or 'Send' not in namespace.rights:
+            raise CLIError('Error : Assigning \'Manage\' to --rights requires \'Listen\' and \'Send\' to be included with. e.g. --rights Manage Send Listen')