enhanced logging

Author: dibahlfi

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/Converters/ChangeFeedMetadataConverter.cs

@@ -72,13 +72,22 @@ public override ChangeFeedMetadata Read(ref Utf8JsonReader reader, Type typeToCo
                             JsonValueKind.Number => pk.Value.TryGetInt64(out long longValue) ? longValue : (object)pk.Value.GetDouble(),
                             JsonValueKind.True or JsonValueKind.False => pk.Value.GetBoolean(),
                             JsonValueKind.Null => null,
-                            _ => throw new JsonException($"Unexpected JsonValueKind '{pk.Value.ValueKind}' for PartitionKey property."),
+                            _ => throw new JsonException($"Unexpected JsonValueKind '{pk.Value.ValueKind}' for PartitionKey property '{pk.Name}'."),
                         };
                         partitionKey.Add((pk.Name, actualValue));
                     }
                     metadata.PartitionKey = partitionKey;
                 }
             }
+            
+            // validate delete operation requirements
+            if (metadata.OperationType == ChangeFeedOperationType.Delete)
+            {
+                if (metadata.Id == null || metadata.PartitionKey == null)
+                {
+                    throw new JsonException("Delete operations require both 'id' and 'partitionKey' to be present.");
+                }
+            }
 
             return metadata;
         }
@@ -132,7 +141,7 @@ public override void Write(Utf8JsonWriter writer, ChangeFeedMetadata value, Json
                             break;
 
                         default:
-                            throw new JsonException($"Unexpected value type '{value.GetType()}' for PartitionKey property.");
+                           throw new JsonException($"Unexpected value type '{objectValue.GetType()}' for PartitionKey property '{key}'.");
                     }
                 }
                 writer.WriteEndObject();

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/Converters/ChangeFeedMetadataNewtonSoftConverter.cs

@@ -75,7 +75,7 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
                                     break;
 
                                 default:
-                                    throw new JsonSerializationException($"Unexpected value type: {objectValue.GetType()} for PartitionKey property.");
+                                    throw new JsonSerializationException($"Unexpected value type '{objectValue.GetType()}' for PartitionKey property '{key}'.");
                             }
                         }
                     }
@@ -87,7 +87,7 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
             }
             else
             {
-                throw new JsonSerializationException($"Unexpected value when converting {nameof(ChangeFeedMetadata)}.");
+                throw new JsonSerializationException($"Unexpected value '{value}' of type '{value?.GetType()}' when converting {nameof(ChangeFeedMetadata)}.");
             }
         }