fix: address PR review feedback from @jongio

- Fix shell pipe handling in installer splitCommand for commands
  containing | or redirects (e.g., curl | sudo bash)
- Remove accidentally committed test coverage file, add to .gitignore
- Change MCP server detection from npx (triggers download) to
  npm list -g (local check only)
- Move upgrade execution inside TaskList callbacks so spinners
  reflect real-time progress
- Replace hardcoded workflow command allowlist with group annotation
  check (CmdGroupStart/CmdGroupAzure/CmdGroupBeta)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: wbreza

cli/azd/.gitignore

@@ -10,6 +10,7 @@ azd.sln
 **/target
 
 # Coverage artifacts (generated by mage coverage:* targets)
+cover
 cover-local.out
 cover-ci-combined.out
 coverage.html

cli/azd/cmd/root.go

@@ -282,6 +282,9 @@ func newRootCmd(
 			ActionResolver: newBuildAction,
 			OutputFormats:  []output.Format{output.JsonFormat, output.NoneFormat},
 			DefaultFormat:  output.NoneFormat,
+			GroupingOptions: actions.CommandGroupOptions{
+				RootLevelHelp: actions.CmdGroupBeta,
+			},
 		}).
 		UseMiddleware("hooks", middleware.NewHooksMiddleware).
 		UseMiddleware("extensions", middleware.NewExtensionsMiddleware)
@@ -547,27 +550,25 @@ func newRootCmd(
 // command where a first-run tool check adds value.  Utility commands
 // (auth, config, env, show, etc.) are excluded so they are never
 // blocked by the first-run experience or update notifications.
+//
+// Instead of maintaining a hard-coded allowlist, we rely on the
+// RootLevelHelpOption group annotation so that any new command added
+// to a workflow group is automatically covered.
 func isWorkflowCommand(descriptor *actions.ActionDescriptor) bool {
-	workflowCommands := map[string]bool{
-		"init":      true,
-		"up":        true,
-		"deploy":    true,
-		"provision": true,
-		"build":     true,
-		"package":   true,
-		"restore":   true,
-		"publish":   true,
-		"down":      true,
-		"monitor":   true,
-		"add":       true,
+	// Walk up to the root-level subcommand (first segment after "azd").
+	current := descriptor
+	for current.Parent() != nil && current.Parent().Parent() != nil {
+		current = current.Parent()
 	}
 
-	// Walk up to the root-level subcommand (first segment after "azd").
-	cmd := descriptor.Options.Command
-	for cmd.Parent() != nil && cmd.Parent().Parent() != nil {
-		cmd = cmd.Parent()
+	if current.Options == nil {
+		return false
 	}
-	return workflowCommands[cmd.Name()]
+
+	group := current.Options.GroupingOptions.RootLevelHelp
+	return group == actions.CmdGroupStart ||
+		group == actions.CmdGroupAzure ||
+		group == actions.CmdGroupBeta
 }
 
 func getCmdRootHelpFooter(cmd *cobra.Command) string {

cli/azd/cmd/tool.go

@@ -516,20 +516,32 @@ func (a *toolUpgradeAction) Run(ctx context.Context) (*actions.ActionResult, err
 		TitleNote: "Upgrades installed tools to their latest versions",
 	})
 
-	var results []*tool.InstallResult
-	var err error
+	// Determine which tools to upgrade — resolve tool definitions
+	// up front but defer the actual upgrade work to each task callback
+	// so that the spinner reflects real-time progress.
+	var toolsToUpgrade []*tool.ToolDefinition
 
 	if len(a.args) > 0 {
-		results, err = a.manager.UpgradeTools(ctx, a.args)
+		for _, id := range a.args {
+			toolDef, findErr := a.manager.FindTool(id)
+			if findErr != nil {
+				return nil, findErr
+			}
+			toolsToUpgrade = append(toolsToUpgrade, toolDef)
+		}
 	} else {
-		results, err = a.manager.UpgradeAll(ctx)
-	}
-
-	if err != nil {
-		return nil, fmt.Errorf("upgrading tools: %w", err)
+		statuses, detectErr := a.manager.DetectAll(ctx)
+		if detectErr != nil {
+			return nil, fmt.Errorf("detecting installed tools: %w", detectErr)
+		}
+		for _, s := range statuses {
+			if s.Installed {
+				toolsToUpgrade = append(toolsToUpgrade, s.Tool)
+			}
+		}
 	}
 
-	if len(results) == 0 {
+	if len(toolsToUpgrade) == 0 {
 		a.console.Message(ctx, output.WithGrayFormat("No installed tools to upgrade."))
 		return nil, nil
 	}
@@ -538,19 +550,26 @@ func (a *toolUpgradeAction) Run(ctx context.Context) (*actions.ActionResult, err
 		&uxlib.TaskListOptions{ContinueOnError: true},
 	)
 
-	for _, r := range results {
-		capturedResult := r
+	for _, t := range toolsToUpgrade {
+		capturedTool := t
 		taskList.AddTask(uxlib.TaskOptions{
-			Title: fmt.Sprintf("Upgrading %s", capturedResult.Tool.Name),
+			Title: fmt.Sprintf("Upgrading %s", capturedTool.Name),
 			Action: func(setProgress uxlib.SetProgressFunc) (uxlib.TaskState, error) {
-				if capturedResult.Error != nil {
-					return uxlib.Error, capturedResult.Error
-				}
-				if !capturedResult.Success {
-					return uxlib.Warning, fmt.Errorf("upgrade did not succeed")
+				results, upgradeErr := a.manager.UpgradeTools(ctx, []string{capturedTool.Id})
+				if upgradeErr != nil {
+					return uxlib.Error, upgradeErr
 				}
-				if capturedResult.InstalledVersion != "" {
-					setProgress(capturedResult.InstalledVersion)
+				if len(results) > 0 {
+					r := results[0]
+					if r.Error != nil {
+						return uxlib.Error, r.Error
+					}
+					if !r.Success {
+						return uxlib.Warning, fmt.Errorf("upgrade did not succeed")
+					}
+					if r.InstalledVersion != "" {
+						setProgress(r.InstalledVersion)
+					}
 				}
 				return uxlib.Success, nil
 			},