Skip to content

Commit 85e01ca

Browse files
therealjohnCopilot
andcommitted
fix(azure.ai.docs): address PR review comments and cspell
* ci-build.ps1: correct ldflags module path from azure.ai.skills to azure.ai.docs * toolbox/overview.md: clarify that any toolbox mutation promotes a new version to default; --default-version is for rollback/repointing * connection/overview.md and agent/configure.md: align CustomKeys credential shape with auth-types.md (credentials.keys.<header> and PARAM_<CONN>_KEYS_<HEADER>) * cspell.yaml: add 'parseable' for skill_install.go doc comment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 4aa7c43 commit 85e01ca

5 files changed

Lines changed: 8 additions & 4 deletions

File tree

cli/azd/extensions/azure.ai.docs/ci-build.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ if ($CodeCoverageEnabled) {
2929

3030
$tagsFlag = "-tags=cfi,cfg,osusergo"
3131

32-
$ldFlag = "-ldflags=-s -w -X azure.ai.skills/internal/cmd.Version=$Version -X azure.ai.skills/internal/cmd.Commit=$SourceVersion -X azure.ai.skills/internal/cmd.BuildDate=$(Get-Date -Format o) "
32+
$ldFlag = "-ldflags=-s -w -X azure.ai.docs/internal/cmd.Version=$Version -X azure.ai.docs/internal/cmd.Commit=$SourceVersion -X azure.ai.docs/internal/cmd.BuildDate=$(Get-Date -Format o) "
3333

3434
if ($IsWindows) {
3535
$msg = "Building for Windows"

cli/azd/extensions/azure.ai.docs/cspell.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ words:
3838
# Filesystem terms used in skill_install.go (target directories + cross-filesystem renames)
3939
- subdirs
4040
- tmpfs
41+
# Used in skill_install.go comments describing the JSON wire shape
42+
- parseable
4143
overrides:
4244
- filename: internal/cmd/doc_catalog.go
4345
words:

cli/azd/extensions/azure.ai.docs/internal/cmd/skills/agent/configure.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ services:
4444
target: https://api.githubcopilot.com/mcp
4545
authType: CustomKeys
4646
credentials:
47-
Authorization: ${PARAM_GITHUB_MCP_CONN_AUTHORIZATION}
47+
keys:
48+
Authorization: ${PARAM_GITHUB_MCP_CONN_KEYS_AUTHORIZATION}
4849
toolboxes:
4950
- name: agent-tools
5051
description: "MCP toolset bundling GitHub + web search."

cli/azd/extensions/azure.ai.docs/internal/cmd/skills/connection/overview.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ connections:
4646
target: https://api.githubcopilot.com/mcp
4747
authType: CustomKeys
4848
credentials:
49-
Authorization: ${PARAM_GITHUB_MCP_CONN_AUTHORIZATION}
49+
keys:
50+
Authorization: ${PARAM_GITHUB_MCP_CONN_KEYS_AUTHORIZATION}
5051
toolboxes:
5152
- name: agent-tools
5253
tools:

cli/azd/extensions/azure.ai.docs/internal/cmd/skills/toolbox/overview.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Then `azd ai toolbox --help` to see the verbs.
3333
| `azd ai toolbox update <name> --default-version <ver>` | Re-point the default version (the only field `update` supports today). |
3434
| `azd ai toolbox delete <name> [--version <ver>] [--force]` | Delete a whole toolbox, or a single version. |
3535

36-
Every mutation publishes a new immutable version. The first version of a new toolbox is automatically the default; subsequent versions require an explicit `update --default-version` to promote.
36+
Every mutation publishes a new immutable version and promotes it to default (`toolbox create`, `connection add`, `connection remove`). Use `update --default-version` later to re-point at an older version (rollback) or to fix a previous promotion.
3737

3838
## Connections must already exist
3939

0 commit comments

Comments
 (0)