Enforce go fix in CI and apply modernizations

Add go fix -diff as a quality gate across all Go modules (azd core
and extensions). This ensures code stays up to date with modern Go
idioms such as interface{} -> any, range-over-int loops, maps.Copy,
slices.Contains, min/max builtins, and more.

Changes:
- Apply go fix ./... to azd core and all 6 extensions (307 files)
- Add go-fix job to reusable lint-go.yml workflow
- Add go fix -diff check to mage preflight (step 2)
- Update CONTRIBUTING.md and AGENTS.md with go fix docs
- Remove unused Ptr helpers that were inlined by go fix
- Refactor ioc/container.go to avoid go fix false positive with
  unexported types from the container package

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: vhvb1989

.github/workflows/lint-go.yml

@@ -39,3 +39,23 @@ jobs:
           version: ${{ inputs.golangci-lint-version }}
           args: -v --timeout 10m0s
           working-directory: ${{ inputs.working-directory }}
+
+  go-fix:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/setup-go@v6
+        with:
+          go-version: ${{ inputs.go-version }}
+      - uses: actions/checkout@v4
+      - name: Check for go fix suggestions
+        working-directory: ${{ inputs.working-directory }}
+        run: |
+          DIFF=$(go fix -diff ./... 2>/dev/null)
+          if [ -n "$DIFF" ]; then
+            echo "::error::go fix found code that should be modernized."
+            echo "Run 'go fix ./...' locally and commit the changes."
+            echo ""
+            echo "$DIFF"
+            exit 1
+          fi
+          echo "No go fix suggestions — code is up to date."

cli/azd/AGENTS.md

@@ -73,6 +73,7 @@ When writing tests, prefer table-driven tests. Use testify/mock for mocking.
 
 ```bash
 gofmt -s -w .
+go fix ./...
 golangci-lint run ./...
 cspell lint "**/*.go" --relative --config ./.vscode/cspell.yaml --no-progress
 ../../eng/scripts/copyright-check.sh . --fix
@@ -81,6 +82,8 @@ cspell lint "**/*.go" --relative --config ./.vscode/cspell.yaml --no-progress
 - **Line length**: 125 chars max for Go (enforced by `lll` linter); no limit for Markdown
 - **Spelling**: Add technical terms to `cli/azd/.vscode/cspell.yaml` overrides
 - **Copyright**: All Go files need the Microsoft header (handled by copyright-check.sh)
+- **Code modernization**: `go fix ./...` applies automatic modernizations (e.g. `interface{}` → `any`,
+  loop simplifications, use of `slices`/`maps` packages). CI enforces this check.
 
 ### Avoiding Unrelated go.mod/go.sum Changes
 

cli/azd/CONTRIBUTING.md

@@ -80,6 +80,15 @@ Run linter (install [golangci-lint](https://golangci-lint.run/welcome/install/#l
 golangci-lint run ./...
 ```
 
+Run code modernization check ([go fix](https://go.dev/blog/gofix)):
+
+```bash
+go fix -diff ./...
+```
+
+If `go fix -diff` reports any changes, apply them with `go fix ./...` and commit the result.
+CI enforces this check — PRs with pending `go fix` suggestions will fail the lint workflow.
+
 > Note: On Windows you may need to add `C:\Program Files\Git\usr\bin` to `%PATH%`
 
 ### Debugging (with VSCode)

cli/azd/cmd/auto_install.go

@@ -10,6 +10,7 @@ import (
 	"io"
 	"log"
 	"os"
+	"slices"
 	"strings"
 
 	"github.com/azure/azure-dev/cli/azd/internal"
@@ -202,10 +203,8 @@ func isBuiltInCommand(rootCmd *cobra.Command, commandName string) bool {
 			return true
 		}
 		// Also check aliases
-		for _, alias := range cmd.Aliases {
-			if alias == commandName {
-				return true
-			}
+		if slices.Contains(cmd.Aliases, commandName) {
+			return true
 		}
 	}
 
@@ -218,10 +217,8 @@ func hasSubcommand(cmd *cobra.Command, name string) bool {
 		if sub.Name() == name {
 			return true
 		}
-		for _, alias := range sub.Aliases {
-			if alias == name {
-				return true
-			}
+		if slices.Contains(sub.Aliases, name) {
+			return true
 		}
 	}
 	return false

cli/azd/cmd/auto_install_integration_test.go

@@ -5,6 +5,7 @@ package cmd
 
 import (
 	"os"
+	"slices"
 	"testing"
 
 	"github.com/azure/azure-dev/cli/azd/internal"
@@ -182,12 +183,7 @@ func TestAgentDetectionIntegration(t *testing.T) {
 
 // containsNoPromptFalse checks if args contain --no-prompt=false
 func containsNoPromptFalse(args []string) bool {
-	for _, arg := range args {
-		if arg == "--no-prompt=false" {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(args, "--no-prompt=false")
 }
 
 // clearAgentEnvVarsForTest clears all environment variables that could trigger agent detection.

cli/azd/cmd/hooks.go

@@ -7,7 +7,6 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
 	"github.com/azure/azure-dev/cli/azd/cmd/actions"
 	"github.com/azure/azure-dev/cli/azd/internal"
 	"github.com/azure/azure-dev/cli/azd/pkg/environment"
@@ -258,7 +257,7 @@ func (hra *hooksRunAction) execHook(
 
 	// Always run in interactive mode for 'azd hooks run', to help with testing/debugging
 	runOptions := &tools.ExecOptions{
-		Interactive: to.Ptr(true),
+		Interactive: new(true),
 	}
 
 	err := hooksRunner.RunHooks(ctx, hookType, runOptions, commandName)

cli/azd/cmd/init.go

@@ -19,7 +19,6 @@ import (
 	"github.com/azure/azure-dev/cli/azd/internal/agent"
 	"github.com/azure/azure-dev/cli/azd/internal/agent/consent"
 	"github.com/azure/azure-dev/cli/azd/internal/agent/feedback"
-	"github.com/azure/azure-dev/cli/azd/internal/agent/tools/common"
 	"github.com/azure/azure-dev/cli/azd/internal/repository"
 	"github.com/azure/azure-dev/cli/azd/internal/tracing"
 	"github.com/azure/azure-dev/cli/azd/internal/tracing/fields"
@@ -414,7 +413,7 @@ func (i *initAction) initAppWithAgent(ctx context.Context) error {
 			ServerName: "*",
 			Operation:  consent.OperationTypeTool,
 			Annotations: mcp.ToolAnnotation{
-				ReadOnlyHint: common.ToPtr(true),
+				ReadOnlyHint: new(true),
 			},
 		},
 	)

cli/azd/cmd/middleware/error.go

@@ -518,7 +518,7 @@ func promptForErrorHandlingConsent(
 		Message:         message,
 		HelpMessage:     helpMessage,
 		Choices:         choices,
-		EnableFiltering: uxlib.Ptr(false),
+		EnableFiltering: new(false),
 		DisplayCount:    len(choices),
 	})
 
@@ -566,7 +566,7 @@ func (e *ErrorMiddleware) promptExplanationWithConsent(ctx context.Context) (str
 			" Edit permissions anytime by running %s.",
 			output.WithHighLightFormat("azd mcp consent")),
 		Choices:         choices,
-		EnableFiltering: uxlib.Ptr(false),
+		EnableFiltering: new(false),
 		DisplayCount:    len(choices),
 	})
 
@@ -582,8 +582,8 @@ func (e *ErrorMiddleware) promptExplanationWithConsent(ctx context.Context) (str
 	selected := choices[*choiceIndex].Value
 
 	// Handle "always" variants — save to config and return the scope
-	if strings.HasPrefix(selected, "always.") {
-		scope := strings.TrimPrefix(selected, "always.")
+	if after, ok := strings.CutPrefix(selected, "always."); ok {
+		scope := after
 		configKey := configPrefix + "." + scope
 		if err := userConfig.Set(configKey, "allow"); err != nil {
 			return "", fmt.Errorf("failed to set config %s: %w", configKey, err)
@@ -615,7 +615,7 @@ func (e *ErrorMiddleware) promptForFixGuidance(ctx context.Context) (bool, error
 	selector := uxlib.NewSelect(&uxlib.SelectOptions{
 		Message:         "Do you want to generate step-by-step fix guidance?",
 		Choices:         choices,
-		EnableFiltering: uxlib.Ptr(false),
+		EnableFiltering: new(false),
 		DisplayCount:    len(choices),
 	})
 
@@ -686,7 +686,7 @@ func promptUserForSolution(ctx context.Context, solutions []string, agentName st
 		Message:         fmt.Sprintf("Allow %s to fix the error?", agentName),
 		HelpMessage:     "Select a suggested fix, or let AI decide",
 		Choices:         choices,
-		EnableFiltering: uxlib.Ptr(false),
+		EnableFiltering: new(false),
 		DisplayCount:    len(choices),
 	})
 

cli/azd/cmd/usage_test.go

@@ -68,7 +68,7 @@ func usageSnapshot(t *testing.T, cmd *cobra.Command) {
 	})
 }
 
-func resolveTemplate(text string, data interface{}) (string, error) {
+func resolveTemplate(text string, data any) (string, error) {
 	finalBuffer := &bytes.Buffer{}
 	t := template.New("resolve template with command")
 	template.Must(t.Parse(text))

cli/azd/cmd/util.go

@@ -27,7 +27,7 @@ type CmdAnnotations map[string]string
 // CmdCalledAs provides access to the cmd.CalledAs() value through dependency injection
 type CmdCalledAs string
 
-type Asker func(p survey.Prompt, response interface{}) error
+type Asker func(p survey.Prompt, response any) error
 
 func serviceNameWarningCheck(console input.Console, serviceNameFlag string, commandName string) {
 	if serviceNameFlag == "" {