Fix warnings in extension projects (#3260)

Author: jviau

extensions/Worker.Extensions.CosmosDB/src/Config/CosmosDBBindingOptionsSetup.cs

@@ -31,8 +31,10 @@ public void Configure(CosmosDBBindingOptions options)
             Configure(Options.DefaultName, options);
         }
 
-        public void Configure(string connectionName, CosmosDBBindingOptions options)
+        public void Configure(string? connectionName, CosmosDBBindingOptions options)
         {
+            // TODO: evaluate defaulting to CosmosDB connection name.
+            connectionName ??= Options.DefaultName;
             IConfigurationSection connectionSection = _configuration.GetWebJobsConnectionStringSection(connectionName);
 
             if (!connectionSection.Exists())

extensions/Worker.Extensions.CosmosDB/src/CosmosDBConverter.cs

@@ -53,7 +53,7 @@ private async ValueTask<ConversionResult> ConvertFromBindingDataAsync(ConverterC
                     throw new InvalidBindingSourceException(modelBindingData.Source, Constants.CosmosExtensionName);
                 }
 
-                var cosmosAttribute = GetBindingDataContent(modelBindingData);
+                CosmosDBInputAttribute cosmosAttribute = GetBindingDataContent(modelBindingData);
                 object result = await ToTargetTypeAsync(context.TargetType, cosmosAttribute);
 
                 return ConversionResult.Success(result);
@@ -77,7 +77,8 @@ private CosmosDBInputAttribute GetBindingDataContent(ModelBindingData bindingDat
 
             return bindingData.ContentType switch
             {
-                Constants.JsonContentType => bindingData.Content.ToObjectFromJson<CosmosDBInputAttribute>(),
+                Constants.JsonContentType => bindingData.Content.ToObjectFromJson<CosmosDBInputAttribute>()
+                    ?? throw new InvalidOperationException("CosmosDB binding data content could not be retrieved."),
                 _ => throw new InvalidContentTypeException(bindingData.ContentType, Constants.JsonContentType)
             };
         }

extensions/Worker.Extensions.Storage.Blobs/src/Config/BlobStorageBindingOptionsSetup.cs

@@ -29,14 +29,14 @@ public void Configure(BlobStorageBindingOptions options)
             Configure(Options.DefaultName, options);
         }
 
-        public void Configure(string name, BlobStorageBindingOptions options)
+        public void Configure(string? name, BlobStorageBindingOptions options)
         {
             if (string.IsNullOrWhiteSpace(name))
             {
                 name = Constants.Storage; // default
             }
 
-            IConfigurationSection connectionSection = _configuration.GetWebJobsConnectionStringSection(name);
+            IConfigurationSection connectionSection = _configuration.GetWebJobsConnectionStringSection(name!);
 
             if (!connectionSection.Exists())
             {
@@ -61,4 +61,4 @@ public void Configure(string name, BlobStorageBindingOptions options)
             options.Credential = _componentFactory.CreateTokenCredential(connectionSection);
         }
     }
-}
+}

extensions/Worker.Extensions.Tables/src/Config/TablesBindingOptionsSetup.cs

@@ -24,14 +24,14 @@ public void Configure(TablesBindingOptions options)
             Configure(Options.DefaultName, options);
         }
 
-        public void Configure(string name, TablesBindingOptions options)
+        public void Configure(string? name, TablesBindingOptions options)
         {
             if (string.IsNullOrWhiteSpace(name))
             {
                 name = Constants.Storage; // default
             }
 
-            IConfigurationSection connectionSection = _configuration.GetWebJobsConnectionStringSection(name);
+            IConfigurationSection connectionSection = _configuration.GetWebJobsConnectionStringSection(name!);
 
             if (!connectionSection.Exists())
             {

extensions/Worker.Extensions.Tables/src/TypeConverters/TableConverterBase.cs

@@ -55,7 +55,8 @@ protected TableData GetBindingDataContent(ModelBindingData? bindingData)
 
             return bindingData.ContentType switch
             {
-                Constants.JsonContentType => bindingData.Content.ToObjectFromJson<TableData>(),
+                Constants.JsonContentType => bindingData.Content.ToObjectFromJson<TableData>()
+                    ?? throw new InvalidOperationException("Table binding data content could not be deserialized."),
                 _ => throw new InvalidContentTypeException(bindingData.ContentType, Constants.JsonContentType)
             };
         }

test/E2ETests/E2ETests/AspNetCore/CancellationEndToEndTests.cs

@@ -55,7 +55,7 @@ await TestUtility.RetryAsync(() =>
             Assert.Contains(_fixture.TestLogs.CoreToolsLogs, log => log.Contains(expectedMessage, StringComparison.OrdinalIgnoreCase));
 
             // TODO: 2/3 of the test invocations will fail until the host with the ForwarderProxy fix is released - uncomment this line when the fix is released
-            Assert.NotEqual(null, invocationResult); // just here to 'use' invocationResult to avoid a warning.
+            Assert.NotNull(invocationResult); // just here to 'use' invocationResult to avoid a warning.
             // Assert.Contains(_fixture.TestLogs.CoreToolsLogs, log => log.Contains($"'Functions.{functionName}' ({invocationResult}", StringComparison.OrdinalIgnoreCase));
         }