Skip to content

Commit c50e8c0

Browse files
committed
Make target dependencies explicit
1 parent c1ee491 commit c50e8c0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Azure.Functions.Sdk/Targets/Extensions/Azure.Functions.Sdk.Extensions.targets

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,15 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
2525
DependsOnTargets="CollectExtensionPackages;WriteExtensionProject;RestoreExtensionProject"
2626
AfterTargets="Restore" />
2727

28-
<Target Name="CollectExtensionPackages" Returns="@(_AzureFunctionPackageReference)">
28+
<Target Name="CollectExtensionPackages" DependsOnTargets="Restore"
29+
Returns="@(_AzureFunctionPackageReference)">
2930
<ResolveExtensionPackages ProjectAssetsFile="$(ProjectAssetsFile)">
3031
<Output TaskParameter="ExtensionPackages" ItemName="_AzureFunctionPackageReference" />
3132
</ResolveExtensionPackages>
3233
</Target>
3334

3435
<!-- The WriteExtensionProject task will perform its own incremental build checks. -->
35-
<Target Name="WriteExtensionProject">
36+
<Target Name="WriteExtensionProject" DependsOnTargets="CollectExtensionPackages">
3637
<ValidateExtensionPackages ExtensionPackages="@(_AzureFunctionPackageReference)">
3738
<Output TaskParameter="FilteredPackages" ItemName="_ValidatedAzureFunctionPackageReference" />
3839
</ValidateExtensionPackages>
@@ -41,7 +42,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
4142
HashFilePath="$(_FunctionsPackageHashPath)" />
4243
</Target>
4344

44-
<Target Name="RestoreExtensionProject">
45+
<Target Name="RestoreExtensionProject" DependsOnTargets="WriteExtensionProject">
4546
<MSBuild Projects="$(_AzureFunctionsExtensionProjectPath)" Targets="Restore"
4647
RemoveProperties="$(_AzureFunctionsExtensionRemoveProps)" Properties="IsRestoring=true;RestoreSources=$(_OutputSources)" />
4748
</Target>

test/Azure.Functions.Sdk.Tests/Integration/SdkEndToEndTests.Restore.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright (c) .NET Foundation. All rights reserved.
22
// Licensed under the MIT License. See License.txt in the project root for license information.
33

4-
using System.Reflection.Emit;
54
using System.Xml;
65
using Microsoft.Build.Utilities.ProjectCreation;
76
using NuGet.ProjectModel;

0 commit comments

Comments
 (0)