Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

Commit 3225ebb

Browse files
Copilotjongio
Copilot
and
jongio
committed
Revert foundry model parameter to --model-name and change monitor model to --health-model
Co-authored-by: jongio <2163001+jongio@users.noreply.github.com>
1 parent 3789c03 commit 3225ebb

8 files changed

Lines changed: 21 additions & 21 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ The Azure MCP Server updates automatically by default whenever a new release com
2121
- **Postgres**: `--user-name` → `--user`
2222
- **ServiceBus**: `--queue-name` → `--queue`, `--topic-name` → `--topic`
2323
- **Storage**: `--account-name` → `--account`, `--container-name` → `--container`, `--table-name` → `--table`, `--file-system-name` → `--file-system`, `--tier-name` → `--tier`
24-
- **Monitor**: `--table-name` → `--table`, `--model-name` → `--model`, `--resource-name` → `--resource`
25-
- **Foundry**: `--deployment-name` → `--deployment`, `--model-name` → `--model`, `--publisher-name` → `--publisher`, `--license-name` → `--license`, `--sku-name` → `--sku`, `--azure-ai-services-name` → `--azure-ai-services`
24+
- **Monitor**: `--table-name` → `--table`, `--model` → `--health-model`, `--resource-name` → `--resource`
25+
- **Foundry**: `--deployment-name` → `--deployment`, `--publisher-name` → `--publisher`, `--license-name` → `--license`, `--sku-name` → `--sku`, `--azure-ai-services-name` → `--azure-ai-services`
2626

2727
### Bugs Fixed
2828

‎areas/foundry/src/AzureMcp.Foundry/Options/FoundryOptionDefinitions.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ public static class FoundryOptionDefinitions
99
public const string SearchForFreePlayground = "search-for-free-playground";
1010
public const string PublisherName = "publisher";
1111
public const string LicenseName = "license";
12-
public const string OptionalModelName = "model";
12+
public const string OptionalModelName = "model-name";
1313
public const string DeploymentName = "deployment";
14-
public const string ModelName = "model";
14+
public const string ModelName = "model-name";
1515
public const string ModelFormat = "model-format";
1616
public const string AzureAiServicesName = "azure-ai-services";
1717
public const string ModelVersion = "model-version";

‎areas/foundry/tests/AzureMcp.Foundry.LiveTests/FoundryCommandTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public async Task Should_deploy_foundry_model()
5555
new()
5656
{
5757
{ "deployment", deploymentName },
58-
{ "model", "gpt-4o" },
58+
{ "model-name", "gpt-4o" },
5959
{ "model-format", "OpenAI"},
6060
{ "azure-ai-services", Settings.ResourceBaseName },
6161
{ "resource-group", Settings.ResourceGroupName },

‎areas/foundry/tests/AzureMcp.Foundry.UnitTests/ModelDeploymentCommandTests.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public async Task ExecuteAsync_DeploysModel_WhenValidOptionsProvided()
6262
.Returns(expectedResponse);
6363

6464
var command = new ModelDeploymentCommand();
65-
var args = command.GetCommand().Parse(["--deployment", deploymentName, "--model", modelName, "--model-format", modelFormat, "--azure-ai-services", aiServicesName, "--resource-group", resourceGroup, "--subscription", subscriptionId]);
65+
var args = command.GetCommand().Parse(["--deployment", deploymentName, "--model-name", modelName, "--model-format", modelFormat, "--azure-ai-services", aiServicesName, "--resource-group", resourceGroup, "--subscription", subscriptionId]);
6666
var context = new CommandContext(_serviceProvider);
6767
var response = await command.ExecuteAsync(context, args);
6868

@@ -108,7 +108,7 @@ public async Task ExecuteAsync_OptionalParameters_PassedToService()
108108
.Returns(expectedResponse);
109109

110110
var command = new ModelDeploymentCommand();
111-
var args = command.GetCommand().Parse(["--deployment", deploymentName, "--model", modelName, "--model-format", modelFormat, "--azure-ai-services", aiServicesName, "--resource-group", resourceGroup, "--subscription", subscriptionId, "--model-version", modelVersion, "--model-source", modelSource, "--sku", skuName, "--sku-capacity", skuCapacity.ToString(), "--scale-type", scaleType, "--scale-capacity", scaleCapacity.ToString()]);
111+
var args = command.GetCommand().Parse(["--deployment", deploymentName, "--model-name", modelName, "--model-format", modelFormat, "--azure-ai-services", aiServicesName, "--resource-group", resourceGroup, "--subscription", subscriptionId, "--model-version", modelVersion, "--model-source", modelSource, "--sku", skuName, "--sku-capacity", skuCapacity.ToString(), "--scale-type", scaleType, "--scale-capacity", scaleCapacity.ToString()]);
112112
var context = new CommandContext(_serviceProvider);
113113
var response = await command.ExecuteAsync(context, args);
114114

@@ -144,7 +144,7 @@ public async Task ExecuteAsync_HandlesException()
144144
.ThrowsAsync(new Exception(expectedError));
145145

146146
var command = new ModelDeploymentCommand();
147-
var args = command.GetCommand().Parse(["--deployment", deploymentName, "--model", modelName, "--model-format", modelFormat, "--azure-ai-services", aiServicesName, "--resource-group", resourceGroup, "--subscription", subscriptionId]);
147+
var args = command.GetCommand().Parse(["--deployment", deploymentName, "--model-name", modelName, "--model-format", modelFormat, "--azure-ai-services", aiServicesName, "--resource-group", resourceGroup, "--subscription", subscriptionId]);
148148
var context = new CommandContext(_serviceProvider);
149149
var response = await command.ExecuteAsync(context, args);
150150

‎areas/foundry/tests/AzureMcp.Foundry.UnitTests/ModelsListCommandTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public async Task ExecuteAsync_ReturnsModels_WhenModelsExistWithFlags()
8888
.Returns(expectedModels);
8989

9090
var command = new ModelsListCommand();
91-
var args = command.GetCommand().Parse(["--search-for-free-playground", "--publisher", publisherName, "--license", license, "--model", modelName]);
91+
var args = command.GetCommand().Parse(["--search-for-free-playground", "--publisher", publisherName, "--license", license, "--model-name", modelName]);
9292
var context = new CommandContext(_serviceProvider);
9393
var response = await command.ExecuteAsync(context, args);
9494

‎areas/monitor/src/AzureMcp.Monitor/Options/MonitorOptionDefinitions.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public static class MonitorOptionDefinitions
1313
public const string HoursName = "hours";
1414
public const string LimitName = "limit";
1515
public const string EntityName = "entity";
16-
public const string HealthModelName = "model";
16+
public const string HealthModelName = "health-model";
1717

1818
public static readonly Option<string> TableType = new(
1919
$"--{TableTypeName}",
@@ -77,7 +77,7 @@ public static class Metrics
7777
public const string SearchStringName = "search-string";
7878

7979
public const string EntityName = "entity";
80-
public const string HealthModelName = "model";
80+
public const string HealthModelName = "health-model";
8181
public const string MaxBucketsName = "max-buckets";
8282

8383
// Metrics options

‎areas/monitor/tests/AzureMcp.Monitor.UnitTests/HealthModels/Entity/EntityGetHealthCommandTests.cs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public async Task ExecuteAsync_WithValidParameters_ReturnsEntityHealth()
6969
Arg.Any<RetryPolicyOptions?>())
7070
.Returns(mockResponse);
7171

72-
var args = _parser.Parse($"--entity {TestEntity} --model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription} --tenant {TestTenant}");
72+
var args = _parser.Parse($"--entity {TestEntity} --health-model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription} --tenant {TestTenant}");
7373

7474
// Act
7575
var result = await _command.ExecuteAsync(_context, args);
@@ -92,7 +92,7 @@ await _monitorHealthService.Received(1).GetEntityHealth(
9292
[Fact]
9393
public async Task ExecuteAsync_WithMissingRequiredParameters_ReturnsBadRequest()
9494
{ // Arrange - missing entity parameter
95-
var args = _parser.Parse($"--model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription}");
95+
var args = _parser.Parse($"--health-model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription}");
9696

9797
// Act
9898
var result = await _command.ExecuteAsync(_context, args);
@@ -128,7 +128,7 @@ public async Task ExecuteAsync_EntityNotFound_ReturnsNotFound()
128128
Arg.Any<RetryPolicyOptions?>())
129129
.Returns(Task.FromException<JsonNode>(new KeyNotFoundException("Entity not found")));
130130

131-
var args = _parser.Parse($"--entity {TestEntity} --model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription}");
131+
var args = _parser.Parse($"--entity {TestEntity} --health-model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription}");
132132

133133
// Act
134134
var result = await _command.ExecuteAsync(_context, args);
@@ -163,7 +163,7 @@ public async Task ExecuteAsync_InvalidArgument_ReturnsBadRequest()
163163
Arg.Any<RetryPolicyOptions?>())
164164
.Returns(Task.FromException<JsonNode>(new ArgumentException("Invalid health model format")));
165165

166-
var args = _parser.Parse($"--entity {TestEntity} --model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription}");
166+
var args = _parser.Parse($"--entity {TestEntity} --health-model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription}");
167167

168168
// Act
169169
var result = await _command.ExecuteAsync(_context, args);
@@ -199,7 +199,7 @@ public async Task ExecuteAsync_GeneralException_ReturnsInternalServerError()
199199
Arg.Any<RetryPolicyOptions?>())
200200
.Returns(Task.FromException<JsonNode>(new Exception(expectedError)));
201201

202-
var args = _parser.Parse($"--entity {TestEntity} --model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription}");
202+
var args = _parser.Parse($"--entity {TestEntity} --health-model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription}");
203203

204204
// Act
205205
var result = await _command.ExecuteAsync(_context, args);
@@ -237,7 +237,7 @@ public async Task ExecuteAsync_WithAuthMethod_PassesAuthMethodToService()
237237
Arg.Any<RetryPolicyOptions?>())
238238
.Returns(mockResponse);
239239

240-
var args = _parser.Parse($"--entity {TestEntity} --model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription} --auth-method {authMethod}");
240+
var args = _parser.Parse($"--entity {TestEntity} --health-model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription} --auth-method {authMethod}");
241241

242242
// Act
243243
var result = await _command.ExecuteAsync(_context, args);
@@ -275,7 +275,7 @@ public async Task ExecuteAsync_WithRetryPolicy_PassesRetryPolicyToService()
275275
Arg.Is<RetryPolicyOptions>(r => r.DelaySeconds == RetryDelay && r.MaxRetries == MaxRetries))
276276
.Returns(mockResponse);
277277

278-
var args = _parser.Parse($"--entity {TestEntity} --model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription} --retry-delay {RetryDelay} --retry-max-retries {MaxRetries}");
278+
var args = _parser.Parse($"--entity {TestEntity} --health-model {TestHealthModel} --resource-group {TestResourceGroup} --subscription {TestSubscription} --retry-delay {RetryDelay} --retry-max-retries {MaxRetries}");
279279

280280
// Act
281281
var result = await _command.ExecuteAsync(_context, args);

‎docs/azmcp-commands.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ azmcp server start \
124124
azmcp foundry models deploy --subscription <subscription> \
125125
--resource-group <resource-group> \
126126
--deployment <deployment> \
127-
--model <model> \
127+
--model-name <model> \
128128
--model-format <model-format> \
129129
--azure-ai-services <azure-ai-services> \
130130
[--model-version <model-version>] \
@@ -141,7 +141,7 @@ azmcp foundry models deployments list --endpoint <endpoint>
141141
azmcp foundry models list [--search-for-free-playground <search-for-free-playground>] \
142142
[--publisher <publisher>] \
143143
[--license <license>] \
144-
[--model <model>]
144+
[--model-name <model>]
145145
```
146146

147147
### Azure AI Search Operations
@@ -568,7 +568,7 @@ azmcp monitor workspace log query --subscription <subscription> \
568568
# Get the health of an entity
569569
azmcp monitor healthmodels entity gethealth --subscription <subscription> \
570570
--resource-group <resource-group> \
571-
--model <health-model-name> \
571+
--health-model <health-model-name> \
572572
--entity <entity-id>
573573
```
574574

0 commit comments

Comments
 (0)