optin error record config (#416)

Author: VeryEarly

src/Authentication.Abstractions/Models/ConfigKeysForCommon.cs

@@ -29,8 +29,6 @@ public static class ConfigKeysForCommon
         public const string EnableDataCollection = "EnableDataCollection";
         public const string EnableTestCoverage = "EnableTestCoverage";
         public const string CheckForUpgrade = "CheckForUpgrade";
-        //Use DisableErrorRecordsPersistence as opt-out for now, will replace it with EnableErrorRecordsPersistence as opt-in at next major release (November 2023)
-        public const string DisableErrorRecordsPersistence = "DisableErrorRecordsPersistence";
         public const string EnableErrorRecordsPersistence = "EnableErrorRecordsPersistence";
         public const string DisplaySecretsWarning = "DisplaySecretsWarning";
     }

src/Common/AzurePSCmdlet.cs

@@ -823,8 +823,8 @@ private void RecordDebugMessages()
         //Use DisableErrorRecordsPersistence as opt-out for now, will replace it with EnableErrorRecordsPersistence as opt-in at next major release (November 2023)
         private bool ShouldRecordDebugMessages()
         {
-            return (!AzureSession.Instance.TryGetComponent<IConfigManager>(nameof(IConfigManager), out var configManager)
-                || !configManager.GetConfigValue<bool>(ConfigKeysForCommon.DisableErrorRecordsPersistence))
+            return AzureSession.Instance.TryGetComponent<IConfigManager>(nameof(IConfigManager), out var configManager)
+                && configManager.GetConfigValue<bool>(ConfigKeysForCommon.EnableErrorRecordsPersistence)
                 && IsDataCollectionAllowed();
         }