Restore-AzSqlDatabase does not respect the WhatifPreference

[T630Dev]

Description

For Az.Sql in Version 3.4.0, the Restore-AzSqlDatabase with the -whatIf switch present still restores the actual database instead of calling the ShouldProcess.

Name Value

---

PSVersion 5.1.19041.1023
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.19041.1023
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @azureSQLGitHub.

Issue Details

---

Description

For Az.Sql in Version 3.4.0, the Restore-AzSqlDatabase with the -whatIf switch present still restores the actual database instead of calling the ShouldProcess.

Name Value

---

PSVersion 5.1.19041.1023
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.19041.1023
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

Author:	T630Dev
Assignees:	-
Labels:	SQL - Backup & Restore, Service Attention, question, customer-reported, needs-triage
Milestone:	-

[KranthiPakala-MSFT]

@T630Dev Apologies for the delayed response. To better assist on your query, could you please elaborate a bit on your feedback so that we can involve relevant owners?

Thank you

[T630Dev]

@KranthiPakala-MSFT
The cmdlet Restore-AzSqlDatabase -WhatIf is not working as expected. When providing the -WhatIf parameter, I expect that the actual activity of restoring a DB is not done but just printed that it would restore the DB but not actually doing it.
This cmdlet, however, is ignoring the WhatIf switch and is conducting an actual restore of the DB.
This should be fixed accordingly.

[andylholloway]

Hi
I seeing the same issue. All our automation scripts make use of [CmdletBinding(SupportsShouldProcess)], and support WhatIf.

If I run the following command:

Restore-AzSqlinstanceDatabase `
    -Name $ManagedInstance.ManagedInstanceName `
    -InstanceName $DatabaseName `
    -ResourceGroupName $ManagedInstance.ResourceGroupName `
    -PointInTime $restorePointInTime `
    -TargetInstanceDatabaseName $TargetDatabaseName `
    -FromPointInTimeBackup `
    -WhatIf

I would expect the command to output what it will do e.g. restore the database to the target name: $TargetDatabaseName

But what actually happens is the database is restored, as if the -WhatIf switch was not provided.

Name Value

---

PSVersion 7.2.0
PSEdition Core
GitCommitId 7.2.0
OS Microsoft Windows 10.0.19043
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0

Script 3.5.1 Az.Sql

Thanks
Andy

[aldass]

oy... bump... this is still a bug with Restore-AzSqlInstanceDatabase. I just verified that it does not respect the -WhatIf flag. It's been open for over a year, please fix.

PSVersion 7.3.4
PSEdition Core
GitCommitId 7.3.4
OS Microsoft Windows 10.0.19044
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0

Script 4.6.0 Az.Sql

[mwilsonin]

I just came across this as well. Ran a restore with -WhatIf and to my great surprise it actually restored the database.

Please fix. -WhatIf safety is a bedrock foundation of PowerShell.

PSVersion 7.3.4
PSEdition Core
GitCommitId 7.3.4
OS Microsoft Windows 10.0.19044
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0
Az.Sql Module 4.6.0

Thank you.

[ay-azara]

@azureSQLGitHub Hello? Please, anything?