update

Author: melina5656

specification/monitor/resource-manager/Microsoft.Insights/Insights/DiagnosticsSettings/DiagnosticSettingsResource.tsp

@@ -34,7 +34,7 @@ interface DiagnosticSettingsResources {
   get is Extension.Read<
     Extension.ScopeParameter,
     DiagnosticSettingsResource,
-    Error = ErrorResponse
+    Error = Microsoft.Common.ErrorResponse
   >;
 
   /**
@@ -46,7 +46,7 @@ interface DiagnosticSettingsResources {
     Extension.ScopeParameter,
     DiagnosticSettingsResource,
     Response = ArmResourceUpdatedResponse<DiagnosticSettingsResource>,
-    Error = ErrorResponse
+    Error = Microsoft.Common.ErrorResponse
   >;
 
   /**
@@ -56,7 +56,7 @@ interface DiagnosticSettingsResources {
   delete is Extension.DeleteSync<
     Extension.ScopeParameter,
     DiagnosticSettingsResource,
-    Error = ErrorResponse
+    Error = Microsoft.Common.ErrorResponse
   >;
 
   /**
@@ -67,7 +67,7 @@ interface DiagnosticSettingsResources {
     Extension.ScopeParameter,
     DiagnosticSettingsResource,
     Response = ArmResponse<DiagnosticSettingsResourceCollection>,
-    Error = ErrorResponse
+    Error = Microsoft.Common.ErrorResponse
   >;
 }
 

specification/monitor/resource-manager/Microsoft.Insights/Insights/DiagnosticsSettings/main.tsp

@@ -15,6 +15,7 @@ import "./models.tsp";
 import "./back-compatible.tsp";
 import "./DiagnosticSettingsResource.tsp";
 import "./DiagnosticSettingsCategoryResource.tsp";
+import "../Common/main.tsp";
 
 using TypeSpec.Rest;
 using TypeSpec.Http;

specification/monitor/resource-manager/Microsoft.Insights/Insights/DiagnosticsSettings/models.tsp

@@ -130,23 +130,7 @@ model MetricSettings {
   /**
    * the retention policy for this category.
    */
-  retentionPolicy?: RetentionPolicy;
-}
-
-/**
- * Specifies the retention policy for the log.
- */
-model RetentionPolicy {
-  /**
-   * a value indicating whether the retention policy is enabled.
-   */
-  enabled: boolean;
-
-  /**
-   * the number of days for the retention in days. A value of 0 will retain the events indefinitely.
-   */
-  @minValue(0)
-  days: int32;
+  retentionPolicy?: Microsoft.Common.RetentionPolicy;
 }
 
 /**
@@ -171,23 +155,7 @@ model LogSettings {
   /**
    * the retention policy for this log.
    */
-  retentionPolicy?: RetentionPolicy;
-}
-
-/**
- * Describes the format of Error response.
- */
-@error
-model ErrorResponse {
-  /**
-   * Error code
-   */
-  code?: string;
-
-  /**
-   * Error message indicating why the operation failed.
-   */
-  message?: string;
+  retentionPolicy?: Microsoft.Common.RetentionPolicy;
 }
 
 /**

specification/monitor/resource-manager/Microsoft.Insights/Insights/TenantActionGroups/main.tsp

@@ -14,6 +14,7 @@ import "@azure-tools/typespec-azure-resource-manager";
 import "./models.tsp";
 import "./back-compatible.tsp";
 import "./TenantActionGroupResource.tsp";
+import "../Common/main.tsp";
 
 using TypeSpec.Rest;
 using TypeSpec.Http;

specification/monitor/resource-manager/Microsoft.Insights/Insights/TenantActionGroups/models.tsp

@@ -205,57 +205,6 @@ model VoiceReceiver {
   phoneNumber: string;
 }
 
-/**
- * An azure resource object
- */
-model AzureResource {
-  /**
-   * Azure resource Id
-   */
-  @visibility(Lifecycle.Read)
-  id?: string;
-
-  /**
-   * Azure resource name
-   */
-  @visibility(Lifecycle.Read)
-  name?: string;
-
-  /**
-   * Azure resource type
-   */
-  @visibility(Lifecycle.Read)
-  type?: string;
-
-  /**
-   * Resource location
-   */
-  @visibility(Lifecycle.Read, Lifecycle.Create)
-  location: string;
-
-  /**
-   * Resource tags
-   */
-  #suppress "@azure-tools/typespec-azure-resource-manager/arm-no-record" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
-  tags?: Record<string>;
-}
-
-/**
- * Describes the format of Error response.
- */
-@error
-model ErrorResponse {
-  /**
-   * Error code
-   */
-  code?: string;
-
-  /**
-   * Error message indicating why the operation failed.
-   */
-  message?: string;
-}
-
 /**
  * A tenant action group object for the body of patch operations.
  */

specification/monitor/resource-manager/Microsoft.Insights/Insights/VmInsightsOnboarding/models.tsp

@@ -116,29 +116,6 @@ model WorkspaceInfoProperties {
   customerId: string;
 }
 
-/**
- * An azure resource object
- */
-model ProxyResource {
-  /**
-   * Azure resource Id
-   */
-  @visibility(Lifecycle.Read)
-  id?: string;
-
-  /**
-   * Azure resource name
-   */
-  @visibility(Lifecycle.Read)
-  name?: string;
-
-  /**
-   * Azure resource type
-   */
-  @visibility(Lifecycle.Read)
-  type?: string;
-}
-
 /**
  * An error response from the API.
  */

specification/monitor/resource-manager/Microsoft.Insights/Insights/preview/2021-05-01-preview/openapi.json

@@ -77,7 +77,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "#/definitions/Microsoft.Common.ErrorResponse"
             }
           }
         },
@@ -131,7 +131,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "#/definitions/Microsoft.Common.ErrorResponse"
             }
           }
         },
@@ -189,7 +189,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "#/definitions/Microsoft.Common.ErrorResponse"
             }
           }
         },
@@ -238,7 +238,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "#/definitions/Microsoft.Common.ErrorResponse"
             }
           }
         },
@@ -279,7 +279,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
             }
           }
         },
@@ -330,7 +330,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
             }
           }
         },
@@ -498,20 +498,6 @@
         }
       }
     },
-    "ErrorResponse": {
-      "type": "object",
-      "description": "Describes the format of Error response.",
-      "properties": {
-        "code": {
-          "type": "string",
-          "description": "Error code"
-        },
-        "message": {
-          "type": "string",
-          "description": "Error message indicating why the operation failed."
-        }
-      }
-    },
     "LogSettings": {
       "type": "object",
       "description": "Part of MultiTenantDiagnosticSettings. Specifies the settings for a particular log.",
@@ -529,7 +515,7 @@
           "description": "a value indicating whether this log is enabled."
         },
         "retentionPolicy": {
-          "$ref": "#/definitions/RetentionPolicy",
+          "$ref": "#/definitions/Microsoft.Common.RetentionPolicy",
           "description": "the retention policy for this log."
         }
       },
@@ -555,15 +541,29 @@
           "description": "a value indicating whether this category is enabled."
         },
         "retentionPolicy": {
-          "$ref": "#/definitions/RetentionPolicy",
+          "$ref": "#/definitions/Microsoft.Common.RetentionPolicy",
           "description": "the retention policy for this category."
         }
       },
       "required": [
         "enabled"
       ]
     },
-    "RetentionPolicy": {
+    "Microsoft.Common.ErrorResponse": {
+      "type": "object",
+      "description": "Describes the format of Error response.",
+      "properties": {
+        "code": {
+          "type": "string",
+          "description": "Error code"
+        },
+        "message": {
+          "type": "string",
+          "description": "Error message indicating why the operation failed."
+        }
+      }
+    },
+    "Microsoft.Common.RetentionPolicy": {
       "type": "object",
       "description": "Specifies the retention policy for the log.",
       "properties": {

specification/monitor/resource-manager/Microsoft.Insights/Insights/preview/2023-05-01-preview/tenantActionGroups.json

@@ -74,7 +74,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
             }
           }
         },
@@ -132,7 +132,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
             }
           }
         },
@@ -200,7 +200,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
             }
           }
         },
@@ -262,7 +262,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
             }
           }
         },
@@ -315,7 +315,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
             }
           }
         },
@@ -459,7 +459,7 @@
           "default": {
             "description": "An unexpected error response.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
             }
           }
         },
@@ -591,20 +591,6 @@
         "emailAddress"
       ]
     },
-    "ErrorResponse": {
-      "type": "object",
-      "description": "Describes the format of Error response.",
-      "properties": {
-        "code": {
-          "type": "string",
-          "description": "Error code"
-        },
-        "message": {
-          "type": "string",
-          "description": "Error message indicating why the operation failed."
-        }
-      }
-    },
     "ReceiverStatus": {
       "type": "string",
       "description": "Indicates the status of the receiver. Receivers that are not Enabled will not receive any communications.",