[SDK Validation Status] trigger on PR reopen (#44026)

* Trigger spec-gen-sdk-status on PR reopen

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>

* restore details_url

* Enhance comments for SDK Validation workflow

Added important comments regarding workflow security and context.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>

Author: Copilot

.github/workflows/spec-gen-sdk-status.yaml

@@ -3,6 +3,11 @@ name: "SDK Validation Status"
 on:
   check_run:
     types: [completed]
+  # Azure DevOps pipelines (which report the "SDK Validation" check runs) do not re-trigger when a
+  # PR is reopened, so the "check_run" event alone would never refresh the status. Re-evaluate the
+  # existing check runs on reopen using pull_request_target (privileged, runs in the target branch).
+  pull_request_target:
+    types: [reopened]
 
 permissions:
   contents: read
@@ -13,13 +18,23 @@ permissions:
 jobs:
   sdk-validation-status:
     if: |
-      github.event.check_run.check_suite.app.name == 'Azure Pipelines' &&
-      contains(github.event.check_run.name, 'SDK Validation')
+      github.event_name == 'pull_request_target' ||
+      (github.event.check_run.check_suite.app.name == 'Azure Pipelines' &&
+      contains(github.event.check_run.name, 'SDK Validation'))
     name: "SDK Validation Status"
     runs-on: ubuntu-slim
     steps:
+      # *** IMPORTANT ***
+      # For workflows that are triggered by the pull_request_target event, the workflow runs in the
+      # context of the base of the pull request.  You should make sure that you do not check out,
+      # build, or run untrusted code from the head of the pull request.
       - uses: actions/checkout@v6
         with:
+          # Only needs .github folder for automation, not the files in the PR (analyzed in a
+          # separate workflow).
+          #
+          # Uses the .github folder from the PR base branch (pull_request_target trigger),
+          # or the repo default branch (other triggers).
           sparse-checkout: |
             .github
 

.github/workflows/src/spec-gen-sdk-status.js

@@ -75,6 +75,14 @@ export async function setSpecGenSdkStatusImpl({
     core.info(`- ${check.name}: ${check.status} (${check.conclusion})`);
   }
 
+  // No SDK Validation check runs exist for this commit (e.g. a PR without SDK-relevant changes that
+  // was reopened). Skip setting a status, to avoid creating a spurious "pending" status that would
+  // never be resolved, since the Azure DevOps pipelines won't run for such PRs.
+  if (specGenSdkChecks.length === 0) {
+    core.info("No SDK Validation check runs found. Skipping status update.");
+    return;
+  }
+
   // Check if all SDK generation checks have completed
   const allCompleted =
     specGenSdkChecks.length > 0 &&

.github/workflows/test/spec-gen-sdk-status.test.js

@@ -352,4 +352,30 @@ describe("spec-gen-sdk-status", () => {
       }),
     );
   });
+
+  it("should skip status update when no SDK Validation checks are found", async () => {
+    // Simulates a reopened PR with no SDK-relevant changes: no SDK Validation check runs exist.
+    mockGithub.rest.checks.listForRef.mockResolvedValue({
+      data: {
+        check_runs: [],
+      },
+    });
+
+    await setSpecGenSdkStatusImpl({
+      owner: "testOwner",
+      repo: "testRepo",
+      head_sha: "testSha",
+      target_url: "https://example.com",
+      github: mockGithub,
+      core: mockCore,
+      issue_number: 123,
+    });
+
+    // No status should be set when there are no SDK Validation checks.
+    expect(mockGithub.rest.repos.createCommitStatus).not.toHaveBeenCalled();
+
+    // Outputs should still be set for downstream artifact upload steps.
+    expect(mockCore.setOutput).toBeCalledWith("head_sha", "testSha");
+    expect(mockCore.setOutput).toBeCalledWith("issue_number", 123);
+  });
 });