Skip to content

Commit 34782dd

Browse files
kalyanachakravarthikarri-azhiagaKalyan karri
authored
Swagger correctness fix (#24211)
* Update bms.json Fixed swagger correctness issues https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=5A317FAC-2704-43CF-9008-15B986B1C5C6 https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=EE211DBB-5E86-403E-BBD9-8AD78257CF98 * Update vaults.json Swagger correctness fix for https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=70BCCAF8-A6C2-46E3-BA5F-E6359324D3A2 https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=64C38709-1519-4344-8617-074134722DD9 * Fixed missing comma * Update bms.json Corrected softDeleteRetentionPeriodInDays * Update bms.json fixed typo * Update vaults.json Fixed typo in softDeleteRetentionPeriodInDays * Resolving completeness for Get CRR recovery points from passive stamp Added example * Fixed Model validation - updated API version in examples * suppressed linter error * Added swagger correctness fix to latest version * Added protectableItemCount to latest version * Fixed prettier issues * Fixing issues with go sdk * Fixed prettier issues --------- Co-authored-by: Himanshu Agarwal <[email protected]> Co-authored-by: Kalyan karri <[email protected]>
1 parent 02acc29 commit 34782dd

File tree

15 files changed

+313
-11
lines changed

15 files changed

+313
-11
lines changed

‎specification/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2023-04-01/vaults.json

+46
Original file line numberDiff line numberDiff line change
@@ -1190,6 +1190,44 @@
11901190
}
11911191
}
11921192
},
1193+
"SoftDeleteSettings": {
1194+
"description": "Soft delete Settings of vault",
1195+
"type": "object",
1196+
"properties": {
1197+
"softDeleteState": {
1198+
"enum": [
1199+
"Invalid",
1200+
"Enabled",
1201+
"Disabled",
1202+
"AlwaysON"
1203+
],
1204+
"type": "string",
1205+
"x-ms-enum": {
1206+
"name": "SoftDeleteState",
1207+
"modelAsString": true
1208+
}
1209+
},
1210+
"softDeleteRetentionPeriodInDays": {
1211+
"format": "int32",
1212+
"description": "Soft delete retention period in days",
1213+
"type": "integer"
1214+
}
1215+
}
1216+
},
1217+
"MultiUserAuthorization": {
1218+
"description": "MUA Settings of vault",
1219+
"enum": [
1220+
"Invalid",
1221+
"Enabled",
1222+
"Disabled"
1223+
],
1224+
"type": "string",
1225+
"readOnly": true,
1226+
"x-ms-enum": {
1227+
"name": "MultiUserAuthorization",
1228+
"modelAsString": true
1229+
}
1230+
},
11931231
"MonitoringSettings": {
11941232
"description": "Monitoring Settings of the vault",
11951233
"type": "object",
@@ -1237,6 +1275,14 @@
12371275
"immutabilitySettings": {
12381276
"description": "Immutability Settings of a vault",
12391277
"$ref": "#/definitions/ImmutabilitySettings"
1278+
},
1279+
"softDeleteSettings": {
1280+
"description": "Soft delete Settings of a vault",
1281+
"$ref": "#/definitions/SoftDeleteSettings"
1282+
},
1283+
"multiUserAuthorization": {
1284+
"description": "MUA Settings of a vault",
1285+
"$ref": "#/definitions/MultiUserAuthorization"
12401286
}
12411287
}
12421288
},

‎specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-11-15/bms.json

+73
Original file line numberDiff line numberDiff line change
@@ -712,6 +712,79 @@
712712
}
713713
}
714714
},
715+
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}": {
716+
"get": {
717+
"tags": [
718+
"RecoveryPoints_Crr"
719+
],
720+
"description": "Provides the information of the backed up data identified using RecoveryPointID.",
721+
"operationId": "RecoveryPointsCrr_Get",
722+
"produces": [
723+
"application/json"
724+
],
725+
"parameters": [
726+
{
727+
"$ref": "#/parameters/ApiVersion"
728+
},
729+
{
730+
"$ref": "#/parameters/VaultName"
731+
},
732+
{
733+
"$ref": "#/parameters/ResourceGroupName"
734+
},
735+
{
736+
"$ref": "#/parameters/SubscriptionId"
737+
},
738+
{
739+
"name": "fabricName",
740+
"in": "path",
741+
"description": "Fabric name associated with backed up item.",
742+
"required": true,
743+
"type": "string"
744+
},
745+
{
746+
"name": "containerName",
747+
"in": "path",
748+
"description": "Container name associated with backed up item.",
749+
"required": true,
750+
"type": "string"
751+
},
752+
{
753+
"name": "protectedItemName",
754+
"in": "path",
755+
"description": "Backed up item name whose backup data needs to be fetched.",
756+
"required": true,
757+
"type": "string"
758+
},
759+
{
760+
"name": "recoveryPointId",
761+
"in": "path",
762+
"description": "RecoveryPointID represents the backed up data to be fetched.",
763+
"required": true,
764+
"type": "string"
765+
}
766+
],
767+
"responses": {
768+
"200": {
769+
"description": "OK",
770+
"schema": {
771+
"$ref": "#/definitions/RecoveryPointResource"
772+
}
773+
},
774+
"default": {
775+
"description": "Error response describing why the operation failed.",
776+
"schema": {
777+
"$ref": "#/definitions/NewErrorResponse"
778+
}
779+
}
780+
},
781+
"x-ms-examples": {
782+
"Get Azure Vm Recovery Point Details": {
783+
"$ref": "./examples/AzureIaasVm/RecoveryPoints_Get.json"
784+
}
785+
}
786+
}
787+
},
715788
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectedItems/": {
716789
"get": {
717790
"tags": [

‎specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-11-15/examples/AzureIaasVm/BackupProtectedItems_List.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"subscriptionId": "00000000-0000-0000-0000-000000000000",
44
"resourceGroupName": "SwaggerTestRg",
55
"vaultName": "NetSDKTestRsVault",
6-
"api-version": "2019-05-13",
6+
"api-version": "2021-11-15",
77
"$filter": "backupManagementType eq 'AzureIaasVM' and itemType eq 'VM'"
88
},
99
"responses": {

‎specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-11-15/examples/AzureIaasVm/RecoveryPoints_Get.json

+42
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
{
2+
"parameters": {
3+
"subscriptionId": "00000000-0000-0000-0000-000000000000",
4+
"resourceGroupName": "rshhtestmdvmrg",
5+
"vaultName": "rshvault",
6+
"fabricName": "Azure",
7+
"containerName": "IaasVMContainer;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall",
8+
"protectedItemName": "VM;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall",
9+
"recoveryPointId": "26083826328862",
10+
"api-version": "2021-11-15"
11+
},
12+
"responses": {
13+
"200": {
14+
"body": {
15+
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/rshhtestmdvmrg/providers/Microsoft.RecoveryServices/vaults/rshvault/backupFabrics/Azure/protectionContainers/IaasVMContainer;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall/protectedItems/VM;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall/recoveryPoints/26083826328862",
16+
"name": "26083826328862",
17+
"type": "Microsoft.RecoveryServices/vaults/backupFabrics/protectionContainers/protectedItems/recoveryPoints",
18+
"properties": {
19+
"objectType": "IaasVMRecoveryPoint",
20+
"recoveryPointType": "CrashConsistent",
21+
"recoveryPointTime": "2017-11-22T22:32:46.6088472Z",
22+
"recoveryPointAdditionalInfo": "",
23+
"sourceVMStorageType": "NormalStorage",
24+
"isSourceVMEncrypted": false,
25+
"isInstantIlrSessionActive": false,
26+
"recoveryPointTierDetails": [
27+
{
28+
"type": "HardenedRP",
29+
"status": "Valid"
30+
}
31+
],
32+
"isManagedVirtualMachine": true,
33+
"virtualMachineSize": "Standard_D1",
34+
"originalStorageAccountOption": false,
35+
"zones": [
36+
"1"
37+
]
38+
}
39+
}
40+
}
41+
}
42+
}

‎specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-11-15/examples/AzureIaasVm/RecoveryPoints_List.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"fabricName": "Azure",
77
"containerName": "IaasVMContainer;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall",
88
"protectedItemName": "VM;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall",
9-
"api-version": "2019-05-13"
9+
"api-version": "2021-11-15"
1010
},
1111
"responses": {
1212
"200": {

‎specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-11-15/examples/Common/BackupProtectedItem_UsageSummary_Get.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"subscriptionId": "00000000-0000-0000-0000-000000000000",
44
"resourceGroupName": "testRG",
55
"vaultName": "testVault",
6-
"api-version": "2017-07-01",
6+
"api-version": "2021-11-15",
77
"$filter": "type eq 'BackupProtectedItemCountSummary'"
88
},
99
"responses": {

‎specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-11-15/examples/Common/BackupProtectionContainers_UsageSummary_Get.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"subscriptionId": "00000000-0000-0000-0000-000000000000",
44
"resourceGroupName": "testRG",
55
"vaultName": "testVault",
6-
"api-version": "2017-07-01",
6+
"api-version": "2021-11-15",
77
"$filter": "type eq 'BackupProtectionContainerCountSummary'"
88
},
99
"responses": {

‎specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-11-15/examples/Common/BackupStorageConfig_Get.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"subscriptionId": "00000000-0000-0000-0000-000000000000",
44
"resourceGroupName": "PythonSDKBackupTestRg",
55
"vaultName": "PySDKBackupTestRsVault",
6-
"api-version": "2016-12-01"
6+
"api-version": "2021-11-15"
77
},
88
"responses": {
99
"200": {

‎specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-11-15/examples/Common/BackupStorageConfig_Patch.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"subscriptionId": "00000000-0000-0000-0000-000000000000",
44
"resourceGroupName": "PythonSDKBackupTestRg",
55
"vaultName": "PySDKBackupTestRsVault",
6-
"api-version": "2016-12-01",
6+
"api-version": "2021-11-15",
77
"parameters": {
88
"properties": {
99
"storageType": "LocallyRedundant",

‎specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-11-15/examples/Common/BackupStorageConfig_Put.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"subscriptionId": "00000000-0000-0000-0000-000000000000",
44
"resourceGroupName": "PythonSDKBackupTestRg",
55
"vaultName": "PySDKBackupTestRsVault",
6-
"api-version": "2016-12-01",
6+
"api-version": "2021-11-15",
77
"parameters": {
88
"properties": {
99
"storageType": "LocallyRedundant",

‎specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-01-15/bms.json

+73
Original file line numberDiff line numberDiff line change
@@ -712,6 +712,79 @@
712712
}
713713
}
714714
},
715+
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}": {
716+
"get": {
717+
"tags": [
718+
"RecoveryPoints_Crr"
719+
],
720+
"description": "Provides the information of the backed up data identified using RecoveryPointID.",
721+
"operationId": "RecoveryPointsCrr_Get",
722+
"produces": [
723+
"application/json"
724+
],
725+
"parameters": [
726+
{
727+
"$ref": "#/parameters/ApiVersion"
728+
},
729+
{
730+
"$ref": "#/parameters/VaultName"
731+
},
732+
{
733+
"$ref": "#/parameters/ResourceGroupName"
734+
},
735+
{
736+
"$ref": "#/parameters/SubscriptionId"
737+
},
738+
{
739+
"name": "fabricName",
740+
"in": "path",
741+
"description": "Fabric name associated with backed up item.",
742+
"required": true,
743+
"type": "string"
744+
},
745+
{
746+
"name": "containerName",
747+
"in": "path",
748+
"description": "Container name associated with backed up item.",
749+
"required": true,
750+
"type": "string"
751+
},
752+
{
753+
"name": "protectedItemName",
754+
"in": "path",
755+
"description": "Backed up item name whose backup data needs to be fetched.",
756+
"required": true,
757+
"type": "string"
758+
},
759+
{
760+
"name": "recoveryPointId",
761+
"in": "path",
762+
"description": "RecoveryPointID represents the backed up data to be fetched.",
763+
"required": true,
764+
"type": "string"
765+
}
766+
],
767+
"responses": {
768+
"200": {
769+
"description": "OK",
770+
"schema": {
771+
"$ref": "#/definitions/RecoveryPointResource"
772+
}
773+
},
774+
"default": {
775+
"description": "Error response describing why the operation failed.",
776+
"schema": {
777+
"$ref": "#/definitions/NewErrorResponse"
778+
}
779+
}
780+
},
781+
"x-ms-examples": {
782+
"Get Azure Vm Recovery Point Details": {
783+
"$ref": "./examples/AzureIaasVm/RecoveryPoints_Get.json"
784+
}
785+
}
786+
}
787+
},
715788
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectedItems/": {
716789
"get": {
717790
"tags": [

‎specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-01-15/examples/AzureIaasVm/RecoveryPoints_Get.json

+42
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
{
2+
"parameters": {
3+
"subscriptionId": "00000000-0000-0000-0000-000000000000",
4+
"resourceGroupName": "rshhtestmdvmrg",
5+
"vaultName": "rshvault",
6+
"fabricName": "Azure",
7+
"containerName": "IaasVMContainer;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall",
8+
"protectedItemName": "VM;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall",
9+
"recoveryPointId": "26083826328862",
10+
"api-version": "2023-01-15"
11+
},
12+
"responses": {
13+
"200": {
14+
"body": {
15+
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/rshhtestmdvmrg/providers/Microsoft.RecoveryServices/vaults/rshvault/backupFabrics/Azure/protectionContainers/IaasVMContainer;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall/protectedItems/VM;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall/recoveryPoints/26083826328862",
16+
"name": "26083826328862",
17+
"type": "Microsoft.RecoveryServices/vaults/backupFabrics/protectionContainers/protectedItems/recoveryPoints",
18+
"properties": {
19+
"objectType": "IaasVMRecoveryPoint",
20+
"recoveryPointType": "CrashConsistent",
21+
"recoveryPointTime": "2017-11-22T22:32:46.6088472Z",
22+
"recoveryPointAdditionalInfo": "",
23+
"sourceVMStorageType": "NormalStorage",
24+
"isSourceVMEncrypted": false,
25+
"isInstantIlrSessionActive": false,
26+
"recoveryPointTierDetails": [
27+
{
28+
"type": "HardenedRP",
29+
"status": "Valid"
30+
}
31+
],
32+
"isManagedVirtualMachine": true,
33+
"virtualMachineSize": "Standard_D1",
34+
"originalStorageAccountOption": false,
35+
"zones": [
36+
"1"
37+
]
38+
}
39+
}
40+
}
41+
}
42+
}

0 commit comments

Comments
 (0)