Skip to content

Commit 4d1741c

Browse files
Add exact C# names for management enum members (#44448)
* Add exact C# names for management enum members Use exact C# client names for management-plane enum values that previously required SDK-side CodeGenMember customizations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Pin C# API versions for enum rename migration Keep C# generation on the existing SDK API versions while moving enum member names into TypeSpec. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 0e76f4e commit 4d1741c

10 files changed

Lines changed: 150 additions & 14 deletions

File tree

specification/cdn/resource-manager/Microsoft.Cdn/Cdn/client.tsp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -632,6 +632,16 @@ using Azure.ResourceManager;
632632
"csharp"
633633
);
634634
@@clientName(ResourceType, "CdnResourceType", "csharp");
635+
@@clientName(
636+
ResourceType.`Microsoft.Cdn/Profiles/Endpoints`,
637+
Azure.ClientGenerator.Core.exact("Endpoints"),
638+
"csharp"
639+
);
640+
@@clientName(
641+
ResourceType.`Microsoft.Cdn/Profiles/AfdEndpoints`,
642+
Azure.ClientGenerator.Core.exact("FrontDoorEndpoints"),
643+
"csharp"
644+
);
635645
@@clientName(SslProtocol, "DeliveryRuleSslProtocol", "csharp");
636646
@@clientName(
637647
SslProtocol.TLSv1,

specification/cosmos-db/resource-manager/Microsoft.DocumentDB/DocumentDB/client.tsp

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,26 @@ namespace Customizations;
103103
@@clientName(ServerVersion.Five0, "FIVE_ZERO", "java");
104104
@@clientName(ServerVersion.Six0, "SIX_ZERO", "java");
105105
@@clientName(ServerVersion.Seven0, "SEVEN_ZERO", "java");
106+
@@clientName(
107+
ServerVersion.Three2,
108+
Azure.ClientGenerator.Core.exact("V3_2"),
109+
"csharp"
110+
);
111+
@@clientName(
112+
ServerVersion.Three6,
113+
Azure.ClientGenerator.Core.exact("V3_6"),
114+
"csharp"
115+
);
116+
@@clientName(
117+
ServerVersion.Four0,
118+
Azure.ClientGenerator.Core.exact("V4_0"),
119+
"csharp"
120+
);
121+
@@clientName(
122+
ServerVersion.Four2,
123+
Azure.ClientGenerator.Core.exact("V4_2"),
124+
"csharp"
125+
);
106126

107127
/**
108128
* The subscription resource ID for an access rule.

specification/cosmos-db/resource-manager/Microsoft.DocumentDB/DocumentDB/tspconfig.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ options:
5959
enable-wire-path-attribute: true
6060
namespace: "Azure.ResourceManager.CosmosDB"
6161
emitter-output-dir: "{output-dir}/{service-dir}/{namespace}"
62-
api-version: "2026-03-15"
62+
api-version: "2026-04-01-preview"
6363
linter:
6464
extends:
6565
- "@azure-tools/typespec-azure-rulesets/resource-manager"

specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/DataBoxEdge/client.tsp

Lines changed: 35 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2088,25 +2088,53 @@ op DataBoxEdgeDevicesGetExtendedInformationCustomized(
20882088
@@clientName(SkuName.TCA_Large, "TcaLarge", "csharp");
20892089
@@clientName(SkuName.EdgePR_Base_UPS, "EdgePRBaseUps", "csharp");
20902090
#suppress "@azure-tools/typespec-client-generator-core/invalid-name" "Underscores required in C# client name to match existing SDK enum member for backward compatibility."
2091-
@@clientName(SkuName.EP2_64_1VPU_W, "EP2_64_1VpuW", "csharp");
2091+
@@clientName(
2092+
SkuName.EP2_64_1VPU_W,
2093+
Azure.ClientGenerator.Core.exact("EP2_64_1VpuW"),
2094+
"csharp"
2095+
);
20922096
#suppress "@azure-tools/typespec-client-generator-core/invalid-name" "Underscores required in C# client name to match existing SDK enum member for backward compatibility."
2093-
@@clientName(SkuName.EP2_128_1T4_Mx1_W, "EP2_128_1T4Mx1W", "csharp");
2097+
@@clientName(
2098+
SkuName.EP2_128_1T4_Mx1_W,
2099+
Azure.ClientGenerator.Core.exact("EP2_128_1T4Mx1W"),
2100+
"csharp"
2101+
);
20942102
#suppress "@azure-tools/typespec-client-generator-core/invalid-name" "Underscores required in C# client name to match existing SDK enum member for backward compatibility."
2095-
@@clientName(SkuName.EP2_256_2T4_W, "EP2_256_2T4W", "csharp");
2103+
@@clientName(
2104+
SkuName.EP2_256_2T4_W,
2105+
Azure.ClientGenerator.Core.exact("EP2_256_2T4W"),
2106+
"csharp"
2107+
);
20962108
@@clientName(SkuName.RCA_Small, "RcaSmall", "csharp");
20972109
@@clientName(SkuName.RCA_Large, "RcaLarge", "csharp");
20982110
@@clientName(SkuName.RDC, "Rdc", "csharp");
20992111
#suppress "@azure-tools/typespec-client-generator-core/invalid-name" "Underscores required in C# client name to match existing SDK enum member for backward compatibility."
2100-
@@clientName(SkuName.EP2_64_Mx1_W, "EP2_64_Mx1W", "csharp");
2112+
@@clientName(
2113+
SkuName.EP2_64_Mx1_W,
2114+
Azure.ClientGenerator.Core.exact("EP2_64_Mx1W"),
2115+
"csharp"
2116+
);
21012117
#suppress "@azure-tools/typespec-client-generator-core/invalid-name" "Underscores required in C# client name to match existing SDK enum member for backward compatibility."
2102-
@@clientName(SkuName.EP2_128_GPU1_Mx1_W, "EP2_128Gpu1Mx1W", "csharp");
2118+
@@clientName(
2119+
SkuName.EP2_128_GPU1_Mx1_W,
2120+
Azure.ClientGenerator.Core.exact("EP2_128Gpu1Mx1W"),
2121+
"csharp"
2122+
);
21032123
#suppress "@azure-tools/typespec-client-generator-core/invalid-name" "Underscores required in C# client name to match existing SDK enum member for backward compatibility."
2104-
@@clientName(SkuName.EP2_256_GPU2_Mx1, "EP2_256Gpu2Mx1", "csharp");
2124+
@@clientName(
2125+
SkuName.EP2_256_GPU2_Mx1,
2126+
Azure.ClientGenerator.Core.exact("EP2_256Gpu2Mx1"),
2127+
"csharp"
2128+
);
21052129
@@clientName(SkuName.EdgeMR_TCP, "EdgeMRTcp", "csharp");
21062130

21072131
@@clientName(EncryptionAlgorithm.AES256, "Aes256", "csharp");
21082132
#suppress "@azure-tools/typespec-client-generator-core/invalid-name" "Underscores required in C# client name to match existing SDK enum member for backward compatibility."
2109-
@@clientName(EncryptionAlgorithm.RSAES_PKCS1_v_1_5, "RsaesPkcs1V1_5", "csharp");
2133+
@@clientName(
2134+
EncryptionAlgorithm.RSAES_PKCS1_v_1_5,
2135+
Azure.ClientGenerator.Core.exact("RsaesPkcs1V1_5"),
2136+
"csharp"
2137+
);
21102138

21112139
@@usage(Alert, Usage.input | Usage.output, "csharp");
21122140
@@usage(DiagnosticRemoteSupportSettings, Usage.input | Usage.output, "csharp");

specification/eventhub/resource-manager/Microsoft.EventHub/Eventhub/client.tsp

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -210,10 +210,26 @@ using Microsoft.EventHub;
210210
);
211211

212212
@@clientName(TlsVersion, "EventHubsTlsVersion", "csharp");
213-
@@clientName(TlsVersion.`1.0`, "Tls1_0", "csharp");
214-
@@clientName(TlsVersion.`1.1`, "Tls1_1", "csharp");
215-
@@clientName(TlsVersion.`1.2`, "Tls1_2", "csharp");
216-
@@clientName(TlsVersion.`1.3`, "Tls1_3", "csharp");
213+
@@clientName(
214+
TlsVersion.`1.0`,
215+
Azure.ClientGenerator.Core.exact("Tls1_0"),
216+
"csharp"
217+
);
218+
@@clientName(
219+
TlsVersion.`1.1`,
220+
Azure.ClientGenerator.Core.exact("Tls1_1"),
221+
"csharp"
222+
);
223+
@@clientName(
224+
TlsVersion.`1.2`,
225+
Azure.ClientGenerator.Core.exact("Tls1_2"),
226+
"csharp"
227+
);
228+
@@clientName(
229+
TlsVersion.`1.3`,
230+
Azure.ClientGenerator.Core.exact("Tls1_3"),
231+
"csharp"
232+
);
217233
@@clientName(PublicNetworkAccess, "EventHubsPublicNetworkAccess", "csharp");
218234
@@clientName(
219235
ProvisioningIssueProperties,

specification/eventhub/resource-manager/Microsoft.EventHub/Eventhub/tspconfig.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ options:
5757
namespace: "{package-name}"
5858
emitter-output-dir: "{output-dir}/{service-dir}/{namespace}"
5959
enable-wire-path-attribute: true
60+
api-version: "2025-05-01-preview"
6061
linter:
6162
extends:
6263
- "@azure-tools/typespec-azure-rulesets/resource-manager"

specification/mysql/resource-manager/Microsoft.DBforMySQL/FlexibleServers/client.tsp

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,18 @@ using Microsoft.DBforMySQL;
1313
);
1414
@@clientName(Microsoft.DBforMySQL, "MySQLManagementClient", "python");
1515

16-
@@clientName(ServerVersion.`5.7`, "Five7", "javascript,go,csharp");
17-
@@clientName(ServerVersion.`8.0.21`, "Eight021", "javascript,go,csharp");
16+
@@clientName(ServerVersion.`5.7`, "Five7", "javascript,go");
17+
@@clientName(ServerVersion.`8.0.21`, "Eight021", "javascript,go");
18+
@@clientName(
19+
ServerVersion.`5.7`,
20+
Azure.ClientGenerator.Core.exact("Ver5_7"),
21+
"csharp"
22+
);
23+
@@clientName(
24+
ServerVersion.`8.0.21`,
25+
Azure.ClientGenerator.Core.exact("Ver8_0_21"),
26+
"csharp"
27+
);
1828
@@clientName(ServerVersion.`5.7`, "FIVE7", "python");
1929
@@clientName(ServerVersion.`8.0.21`, "EIGHT0_21", "python");
2030
@@clientName(ServerVersion.`8.4`, "EIGHT4", "python");

specification/postgresql/DBforPostgreSQL.Management/client.tsp

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -683,6 +683,31 @@ using Azure.ClientGenerator.Core;
683683
@@usage(AdminCredentialsForPatch, Usage.input, "csharp");
684684

685685
// Preserve backward-compatible version enum member names
686+
@@clientName(
687+
PostgresMajorVersion.`11`,
688+
Azure.ClientGenerator.Core.exact("Ver11"),
689+
"csharp"
690+
);
691+
@@clientName(
692+
PostgresMajorVersion.`12`,
693+
Azure.ClientGenerator.Core.exact("Ver12"),
694+
"csharp"
695+
);
696+
@@clientName(
697+
PostgresMajorVersion.`13`,
698+
Azure.ClientGenerator.Core.exact("Ver13"),
699+
"csharp"
700+
);
701+
@@clientName(
702+
PostgresMajorVersion.`14`,
703+
Azure.ClientGenerator.Core.exact("Ver14"),
704+
"csharp"
705+
);
706+
@@clientName(
707+
PostgresMajorVersion.`15`,
708+
Azure.ClientGenerator.Core.exact("Ver15"),
709+
"csharp"
710+
);
686711
@@clientName(PostgresMajorVersion.`16`, "Sixteen", "csharp");
687712
@@clientName(PostgresMajorVersion.`17`, "Seventeen", "csharp");
688713
@@clientName(PostgresMajorVersion.`18`, "Eighteen", "csharp");

specification/redisenterprise/resource-manager/Microsoft.Cache/RedisEnterprise/client.tsp

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,16 @@ using Microsoft.Cache;
105105
"RedisEnterpriseMigrationProvisioningState",
106106
"csharp"
107107
);
108+
@@clientName(
109+
MigrationValidationRequest,
110+
"RedisEnterpriseMigrationValidationRequestContent",
111+
"csharp"
112+
);
113+
@@clientName(
114+
MigrationValidationResponse,
115+
"RedisEnterpriseMigrationValidationResponseResult",
116+
"csharp"
117+
);
108118
@@clientName(OperationStatus, "RedisEnterpriseOperationStatus", "csharp");
109119
@@clientName(OperationStatus.error, "ErrorResponse", "csharp");
110120
@@clientName(OperationStatus.startTime, "StartOn", "csharp");
@@ -146,6 +156,21 @@ using Microsoft.Cache;
146156
@@clientName(SkuDetails, "RedisEnterpriseSkuDetails", "csharp");
147157
@@clientName(SkuDetailsList, "RedisEnterpriseSkuDetailsList", "csharp");
148158
@@clientName(TlsVersion, "RedisEnterpriseTlsVersion", "csharp");
159+
@@clientName(
160+
TlsVersion.One0,
161+
Azure.ClientGenerator.Core.exact("Tls1_0"),
162+
"csharp"
163+
);
164+
@@clientName(
165+
TlsVersion.One1,
166+
Azure.ClientGenerator.Core.exact("Tls1_1"),
167+
"csharp"
168+
);
169+
@@clientName(
170+
TlsVersion.One2,
171+
Azure.ClientGenerator.Core.exact("Tls1_2"),
172+
"csharp"
173+
);
149174
@@clientName(
150175
OperationsStatusOperationGroup.get,
151176
"GetRedisEnterpriseOperationsStatus",

specification/redisenterprise/resource-manager/Microsoft.Cache/RedisEnterprise/tspconfig.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ options:
4949
namespace: "Azure.ResourceManager.RedisEnterprise"
5050
emitter-output-dir: "{output-dir}/{service-dir}/{namespace}"
5151
enable-wire-path-attribute: true
52+
api-version: "2025-08-01-preview"
5253
linter:
5354
extends:
5455
- "@azure-tools/typespec-azure-rulesets/resource-manager"

0 commit comments

Comments
 (0)