Skip to content

Commit 5144b86

Browse files
committed
tsp validation issues
1 parent 3bedc95 commit 5144b86

3 files changed

Lines changed: 28 additions & 31 deletions

File tree

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

specification/advisor/resource-manager/Microsoft.Advisor/Advisor/RecommendationPatch.tsp

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,20 @@ namespace Microsoft.Advisor;
1010
/**
1111
* Advisor Recommendation.
1212
*/
13-
@added(Versions.v2026_02_01_preview)
13+
@added(Versions.v2026_02_01_preview)
1414
model RecommendationsPatchResponse
15-
is Azure.ResourceManager.ExtensionResource<RecommendationPatchProperties> {
16-
...ResourceNameParameter<
15+
is Azure.ResourceManager.ExtensionResource<RecommendationPatchProperties> {
16+
...ResourceNameParameter<
1717
Resource = RecommendationsPatchResponse,
18-
KeyName = "recommendationId",
19-
SegmentName = "recommendations",
20-
NamePattern = ""
21-
>;
18+
KeyName = "recommendationId",
19+
SegmentName = "recommendations",
20+
NamePattern = ""
21+
>;
2222
}
2323

2424
@armResourceOperations
2525
@added(Versions.v2026_02_01_preview)
2626
interface RecommendationsPatch {
27-
2827
/**
2928
* Update the state properties of a Recommendation.
3029
*/
@@ -36,5 +35,4 @@ interface RecommendationsPatch {
3635
BaseParameters = Azure.ResourceManager.Foundations.SubscriptionBaseParameters,
3736
Error = ArmDefaultErrorResponse
3837
>;
39-
40-
}
38+
}

specification/advisor/resource-manager/Microsoft.Advisor/Advisor/models.tsp

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ union NewState {
174174
#suppress "@azure-tools/typespec-azure-core/documentation-required" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
175175
Dismissed: "Dismissed",
176176
#suppress "@azure-tools/typespec-azure-core/documentation-required" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
177-
Completed: "Completed"
177+
Completed: "Completed",
178178
}
179179

180180
/**
@@ -199,7 +199,7 @@ union Reason {
199199
/**
200200
* The reason for dismissing the Recommendation.
201201
*/
202-
@added(Versions.v2026_02_01_preview)
202+
@added(Versions.v2026_02_01_preview)
203203
union RecommendationDismissReason {
204204
string,
205205
#suppress "@azure-tools/typespec-azure-core/documentation-required" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
@@ -572,30 +572,30 @@ model RecommendationProperties {
572572
@added(Versions.v2026_02_01_preview)
573573
state?: NewState;
574574

575-
/**
575+
/**
576576
* The reason the Recommendation was dismissed.
577577
*/
578578
@added(Versions.v2026_02_01_preview)
579579
recommendationDismissReason?: RecommendationDismissReason;
580580

581-
/**
581+
/**
582582
* The time the Recommendation was postponed until.
583583
*/
584584
// FIXME: (utcDateTime) Please double check that this is the correct type for your scenario.
585-
@added(Versions.v2026_02_01_preview)
586-
postponedUntilDateTime?: utcDateTime;
585+
@added(Versions.v2026_02_01_preview)
586+
postponedUntilDateTime?: utcDateTime;
587587

588588
/**
589589
* The most recent time that Advisor checked the validity of the recommendation.
590590
*/
591591
// FIXME: (utcDateTime) Please double check that this is the correct type for your scenario.
592-
@added(Versions.v2026_02_01_preview)
592+
@added(Versions.v2026_02_01_preview)
593593
lastRefreshed?: utcDateTime;
594594

595595
/**
596596
* The most recent time that Advisor recommendation was updated.
597597
*/
598-
lastUpdated?: utcDateTime;
598+
lastUpdated?: utcDateTime;
599599

600600
/**
601601
* The recommendation metadata.
@@ -627,7 +627,7 @@ model RecommendationProperties {
627627
/**
628628
* The single snoozed or dismissed rule for the recommendation.
629629
*/
630-
@added(Versions.v2026_02_01_preview)
630+
@added(Versions.v2026_02_01_preview)
631631
suppressionId?: string;
632632

633633
/**
@@ -714,18 +714,18 @@ model RecommendationProperties {
714714
/**
715715
* Properties for patch Recommendation API.
716716
*/
717-
#suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-provisioning-state" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
718-
@added(Versions.v2026_02_01_preview)
717+
#suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-provisioning-state" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
718+
@added(Versions.v2026_02_01_preview)
719719
model RecommendationPatchProperties {
720-
/**
720+
/**
721721
* The most recent time that Advisor checked the validity of the recommendation.
722722
*/
723723
// FIXME: (utcDateTime) Please double check that this is the correct type for your scenario.
724724
lastUpdated?: utcDateTime;
725725

726726
/**
727-
* The recommendation-type GUID.
728-
*/
727+
* The recommendation-type GUID.
728+
*/
729729
recommendationTypeId?: string;
730730

731731
/**
@@ -738,17 +738,17 @@ model RecommendationPatchProperties {
738738
*/
739739
recommendationDismissReason?: RecommendationDismissReason;
740740

741-
/**
741+
/**
742742
* The time the Recommendation was postponed until.
743743
*/
744744
// FIXME: (utcDateTime) Please double check that this is the correct type for your scenario.
745-
postponedUntilDateTime?: utcDateTime;
745+
postponedUntilDateTime?: utcDateTime;
746746
}
747747

748748
/**
749749
* Properties for recommendation state patch payload.
750750
*/
751-
@added(Versions.v2026_02_01_preview)
751+
@added(Versions.v2026_02_01_preview)
752752
model RecommendationStatePropertiesPayload {
753753
/**
754754
* The state of the recommendation.
@@ -766,7 +766,6 @@ model RecommendationStatePropertiesPayload {
766766
postponedUntilDateTime?: utcDateTime;
767767
}
768768

769-
770769
/**
771770
* A summary of the recommendation.
772771
*/

0 commit comments

Comments
 (0)