Skip to content

Commit 5df7289

Browse files
haiyuazhangCopilot
andcommitted
Remove non-adjacent duplicate csharp-no-url-suffix suppressions
6 properties (botservice x4, cost-management x2) had csharp-no-url-suffix suppressed twice with a pre-existing casing-style suppress between the two, so they were non-adjacent and missed by the first dedup pass. Collapse to a single csharp-no-url-suffix suppression per property. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 8d332ee commit 5df7289

2 files changed

Lines changed: 0 additions & 6 deletions

File tree

  • specification
    • botservice/resource-manager/Microsoft.BotService/BotService
    • cost-management/resource-manager/Microsoft.CostManagement/CostManagement

specification/botservice/resource-manager/Microsoft.BotService/BotService/models.tsp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1522,15 +1522,13 @@ model HostSettingsResponse {
15221522
*/
15231523
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
15241524
#suppress "@azure-tools/typespec-azure-core/casing-style" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
1525-
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
15261525
OAuthUrl?: string;
15271526

15281527
/**
15291528
* For verifying incoming tokens from the channels
15301529
*/
15311530
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
15321531
#suppress "@azure-tools/typespec-azure-core/casing-style" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
1533-
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
15341532
ToBotFromChannelOpenIdMetadataUrl?: string;
15351533

15361534
/**
@@ -1544,15 +1542,13 @@ model HostSettingsResponse {
15441542
*/
15451543
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
15461544
#suppress "@azure-tools/typespec-azure-core/casing-style" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
1547-
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
15481545
ToBotFromEmulatorOpenIdMetadataUrl?: string;
15491546

15501547
/**
15511548
* For getting access token to channels from bot host
15521549
*/
15531550
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
15541551
#suppress "@azure-tools/typespec-azure-core/casing-style" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
1555-
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
15561552
ToChannelFromBotLoginUrl?: string;
15571553

15581554
/**

specification/cost-management/resource-manager/Microsoft.CostManagement/CostManagement/models.tsp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2722,7 +2722,6 @@ model DownloadURL {
27222722
*/
27232723
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
27242724
#suppress "@azure-tools/typespec-client-generator-core/property-name-conflict" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
2725-
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
27262725
downloadUrl?: string;
27272726
}
27282727

@@ -3859,7 +3858,6 @@ model ReportURL {
38593858
*/
38603859
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
38613860
#suppress "@azure-tools/typespec-client-generator-core/property-name-conflict" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
3862-
#suppress "@azure-tools/typespec-client-generator-core/csharp-no-url-suffix" "Name kept for backward compatibility"
38633861
reportUrl?: ReservationReportSchema;
38643862

38653863
/**

0 commit comments

Comments
 (0)