Update for optional action body

Author: markcowl

.github/actions/setup-node-install-deps/action.yaml

@@ -7,7 +7,7 @@ inputs:
     default: 22.x
   install-command:
     description: 'Command to install dependencies'
-    default: 'npm ci'
+    default: 'npm i --no-package-lock --force'
   working-directory:
     description: 'Working directory'
     default: '.'

package.json

@@ -4,11 +4,11 @@
     "@azure-tools/spec-gen-sdk": "~0.6.1",
     "@azure-tools/specs-shared": "file:.github/shared",
     "@azure-tools/typespec-apiview": "0.7.2",
-    "@azure-tools/typespec-autorest": "0.56.0",
+    "@azure-tools/typespec-autorest": "https://artprodcus3.artifacts.visualstudio.com/A0fb41ef4-5012-48a9-bf39-4ee3de03ee35/29ec6040-b234-4e31-b139-33dc4287b756/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2F6dXJlLXNkay9wcm9qZWN0SWQvMjllYzYwNDAtYjIzNC00ZTMxLWIxMzktMzNkYzQyODdiNzU2L2J1aWxkSWQvNDg2Njc4MS9hcnRpZmFjdE5hbWUvcGFja2FnZXM1/content?format=file&subPath=%2Fazure-tools-typespec-autorest-0.57.0-pr-2674.20250514.10.tgz",
     "@azure-tools/typespec-azure-core": "0.56.0",
-    "@azure-tools/typespec-azure-portal-core": "0.56.0",
-    "@azure-tools/typespec-azure-resource-manager": "0.56.0",
-    "@azure-tools/typespec-azure-rulesets": "0.56.0",
+    "@azure-tools/typespec-azure-portal-core": "https://artprodcus3.artifacts.visualstudio.com/A0fb41ef4-5012-48a9-bf39-4ee3de03ee35/29ec6040-b234-4e31-b139-33dc4287b756/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2F6dXJlLXNkay9wcm9qZWN0SWQvMjllYzYwNDAtYjIzNC00ZTMxLWIxMzktMzNkYzQyODdiNzU2L2J1aWxkSWQvNDg2Njc4MS9hcnRpZmFjdE5hbWUvcGFja2FnZXM1/content?format=file&subPath=%2Fazure-tools-typespec-azure-portal-core-0.57.0-pr-2674.20250514.10.tgz",
+    "@azure-tools/typespec-azure-resource-manager": "https://artprodcus3.artifacts.visualstudio.com/A0fb41ef4-5012-48a9-bf39-4ee3de03ee35/29ec6040-b234-4e31-b139-33dc4287b756/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2F6dXJlLXNkay9wcm9qZWN0SWQvMjllYzYwNDAtYjIzNC00ZTMxLWIxMzktMzNkYzQyODdiNzU2L2J1aWxkSWQvNDg2Njc4MS9hcnRpZmFjdE5hbWUvcGFja2FnZXM1/content?format=file&subPath=%2Fazure-tools-typespec-azure-resource-manager-0.57.0-pr-2674.20250514.10.tgz",
+    "@azure-tools/typespec-azure-rulesets": "https://artprodcus3.artifacts.visualstudio.com/A0fb41ef4-5012-48a9-bf39-4ee3de03ee35/29ec6040-b234-4e31-b139-33dc4287b756/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2F6dXJlLXNkay9wcm9qZWN0SWQvMjllYzYwNDAtYjIzNC00ZTMxLWIxMzktMzNkYzQyODdiNzU2L2J1aWxkSWQvNDg2Njc4MS9hcnRpZmFjdE5hbWUvcGFja2FnZXM1/content?format=file&subPath=%2Fazure-tools-typespec-azure-rulesets-0.57.0-pr-2674.20250514.10.tgz",
     "@azure-tools/typespec-client-generator-cli": "0.21.0",
     "@azure-tools/typespec-client-generator-core": "0.56.2",
     "@azure-tools/typespec-liftr-base": "0.8.0",

specification/apicenter/ApiCenter.Management/ApiDefinition.tsp

@@ -44,7 +44,12 @@ interface ApiDefinitions {
   importSpecification is ArmResourceActionAsync<
     ApiDefinition,
     ApiSpecImportRequest,
-    ApiImportSuccess
+    ApiImportSuccess,
+    BodyParameter = {
+      @doc("The content of the action request")
+      @bodyRoot
+      body: ApiSpecImportRequest;
+    }
   >;
   @doc("Exports the API specification.")
   exportSpecification is ArmResourceActionAsync<

specification/apicenter/ApiCenter.Management/Service.tsp

@@ -47,6 +47,11 @@ interface Services {
   exportMetadataSchema is ArmResourceActionAsync<
     Service,
     MetadataSchemaExportRequest,
-    MetadataSchemaExportResult
+    MetadataSchemaExportResult,
+    BodyParameter = {
+      @doc("The content of the action request")
+      @bodyRoot
+      body: MetadataSchemaExportRequest;
+    }
   >;
 }

specification/apicenter/ApiCenter.Management/main.tsp

@@ -103,27 +103,6 @@ enum Versions {
 );
 @@clientName(Workspaces.createOrUpdate::parameters.resource, "payload");
 
-#suppress "deprecated" "LEGACY - DO NOT COPY THIS DOESN'T MAKE SENSE - FIX"
-@@encodedName(ApiDefinitions.importSpecification::parameters.body,
-  "application/json",
-  "payload"
-);
-
-@@encodedName(ApiDefinitions.exportSpecification::parameters.body,
-  "application/json",
-  "payload"
-);
-
-@@clientName(ApiDefinitions.exportSpecification::parameters.body, "payload");
-
-#suppress "deprecated" "LEGACY - DO NOT COPY THIS DOESN'T MAKE SENSE - FIX"
-@@encodedName(Services.exportMetadataSchema::parameters.body,
-  "application/json",
-  "payload"
-);
-
-@@clientName(Services.exportMetadataSchema::parameters.body, "payload");
-
 @@visibility(Azure.Core.Page.nextLink, Lifecycle.Read);
 @@visibility(Azure.Core.Page.value, Lifecycle.Read);
 /**

specification/apicenter/resource-manager/Microsoft.ApiCenter/preview/2024-03-15-preview/apicenter.json

@@ -617,14 +617,13 @@
             "pattern": "^[a-zA-Z0-9-]{3,90}$"
           },
           {
-            "name": "payload",
+            "name": "body",
             "in": "body",
             "description": "The content of the action request",
             "required": true,
             "schema": {
               "$ref": "#/definitions/MetadataSchemaExportRequest"
-            },
-            "x-ms-client-name": "body"
+            }
           }
         ],
         "responses": {
@@ -3137,14 +3136,13 @@
             "pattern": "^[a-zA-Z0-9-]{3,90}$"
           },
           {
-            "name": "payload",
+            "name": "body",
             "in": "body",
             "description": "The content of the action request",
             "required": true,
             "schema": {
               "$ref": "#/definitions/ApiSpecImportRequest"
-            },
-            "x-ms-client-name": "body"
+            }
           }
         ],
         "responses": {

specification/apicenter/resource-manager/Microsoft.ApiCenter/preview/2024-06-01-preview/apicenter.json

@@ -620,14 +620,13 @@
             "pattern": "^[a-zA-Z0-9-]{3,90}$"
           },
           {
-            "name": "payload",
+            "name": "body",
             "in": "body",
             "description": "The content of the action request",
             "required": true,
             "schema": {
               "$ref": "#/definitions/MetadataSchemaExportRequest"
-            },
-            "x-ms-client-name": "body"
+            }
           }
         ],
         "responses": {
@@ -3505,14 +3504,13 @@
             "pattern": "^[a-zA-Z0-9-]{3,90}$"
           },
           {
-            "name": "payload",
+            "name": "body",
             "in": "body",
             "description": "The content of the action request",
             "required": true,
             "schema": {
               "$ref": "#/definitions/ApiSpecImportRequest"
-            },
-            "x-ms-client-name": "body"
+            }
           }
         ],
         "responses": {

specification/apicenter/resource-manager/Microsoft.ApiCenter/stable/2024-03-01/apicenter.json

@@ -428,14 +428,13 @@
             "pattern": "^[a-zA-Z0-9-]{3,90}$"
           },
           {
-            "name": "payload",
+            "name": "body",
             "in": "body",
             "description": "The content of the action request",
             "required": true,
             "schema": {
               "$ref": "#/definitions/MetadataSchemaExportRequest"
-            },
-            "x-ms-client-name": "body"
+            }
           }
         ],
         "responses": {
@@ -2948,14 +2947,13 @@
             "pattern": "^[a-zA-Z0-9-]{3,90}$"
           },
           {
-            "name": "payload",
+            "name": "body",
             "in": "body",
             "description": "The content of the action request",
             "required": true,
             "schema": {
               "$ref": "#/definitions/ApiSpecImportRequest"
-            },
-            "x-ms-client-name": "body"
+            }
           }
         ],
         "responses": {

specification/appcomplianceautomation/AppComplianceAutomation.Management/resources/EvidenceResource.tsp

@@ -9,7 +9,6 @@ import "./ReportResource.tsp";
 using TypeSpec.Rest;
 using Azure.ResourceManager;
 using TypeSpec.Http;
-using OpenAPI;
 using Azure.ClientGenerator.Core;
 
 namespace Microsoft.AppComplianceAutomation;
@@ -47,8 +46,6 @@ interface Evidence {
   /**
    * Get the evidence metadata
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Evidence_Get")
   get is ArmResourceRead<
     EvidenceResource,
     {
@@ -59,8 +56,6 @@ interface Evidence {
   /**
    * Create or Update an evidence a specified report
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Evidence_CreateOrUpdate")
   createOrUpdate is ArmResourceCreateOrReplaceSync<
     EvidenceResource,
     {
@@ -72,15 +67,11 @@ interface Evidence {
   /**
    *  Delete an existent evidence from a specified report
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Evidence_Delete")
   delete is ArmResourceDeleteSync<EvidenceResource>;
 
   /**
    * Returns a paginated list of evidences for a specified report.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Evidence_ListByReport")
   listByReport is ArmResourceListByParent<
     EvidenceResource,
     {
@@ -92,23 +83,21 @@ interface Evidence {
   /**
    * Download evidence file.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Evidence_Download")
   download is ArmResourceActionSync<
     EvidenceResource,
     EvidenceFileDownloadRequest,
-    EvidenceFileDownloadResponse
+    EvidenceFileDownloadResponse,
+    BodyParameter = {
+      @doc("Parameters for the query operation")
+      @bodyRoot
+      body: EvidenceFileDownloadRequest;
+    }
   >;
 }
 
 @@doc(Evidence.createOrUpdate::parameters.resource,
   "Parameters for the create or update operation"
 );
-@@encodedName(Evidence.download::parameters.body,
-  "application/json",
-  "parameters"
-);
-@@doc(Evidence.download::parameters.body, "Parameters for the query operation");
 
 #suppress "deprecated" "LEGACY - DO NOT COPY - FIX"
 @@encodedName(Evidence.createOrUpdate::parameters.resource,

specification/appcomplianceautomation/AppComplianceAutomation.Management/resources/ReportResource.tsp

@@ -9,8 +9,6 @@ using Azure.ClientGenerator.Core;
 using TypeSpec.Rest;
 using Azure.ResourceManager;
 using TypeSpec.Http;
-using OpenAPI;
-using Azure.Core;
 
 namespace Microsoft.AppComplianceAutomation;
 /**
@@ -47,16 +45,12 @@ interface Report {
   /**
    * Get the AppComplianceAutomation report and its properties.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Report_Get")
   get is ArmResourceRead<ReportResource>;
 
   /**
    * Create a new AppComplianceAutomation report or update an exiting AppComplianceAutomation report.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
   #suppress "@azure-tools/typespec-azure-core/invalid-final-state" "MUST CHANGE ON NEXT UPDATE"
-  @operationId("Report_CreateOrUpdate")
   @Azure.Core.useFinalStateVia("azure-async-operation")
   createOrUpdate is ArmResourceCreateOrReplaceAsync<
     ReportResource,
@@ -67,9 +61,7 @@ interface Report {
   /**
    * Update an exiting AppComplianceAutomation report.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
   @patch(#{ implicitOptionality: false })
-  @operationId("Report_Update")
   update is ArmCustomPatchAsync<
     ReportResource,
     ReportResourcePatch,
@@ -79,8 +71,6 @@ interface Report {
   /**
    * Delete an AppComplianceAutomation report.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Report_Delete")
   delete is ArmResourceDeleteWithoutOkAsync<
     ReportResource,
     Azure.ResourceManager.Foundations.BaseParameters<ReportResource>
@@ -89,8 +79,6 @@ interface Report {
   /**
    * Get the AppComplianceAutomation report list for the tenant.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Report_List")
   list is ArmResourceListByParent<
     ReportResource,
     {
@@ -102,31 +90,36 @@ interface Report {
   /**
    * Synchronize attestation record from app compliance.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Report_SyncCertRecord")
   syncCertRecord is ArmResourceActionAsync<
     ReportResource,
     SyncCertRecordRequest,
     SyncCertRecordResponse,
-    Azure.ResourceManager.Foundations.BaseParameters<ReportResource>
+    Azure.ResourceManager.Foundations.BaseParameters<ReportResource>,
+    BodyParameter = {
+      @doc("Parameters for synchronize certification record operation")
+      @bodyRoot
+      body: SyncCertRecordRequest;
+    }
   >;
 
   /**
    * Checks the report's nested resource name availability, e.g: Webhooks, Evidences, Snapshots.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Report_NestedResourceCheckNameAvailability")
-  checkNameAvailability is ArmResourceActionSync<
+  @action("checkNameAvailability")
+  nestedResourceCheckNameAvailability is ArmResourceActionSync<
     ReportResource,
     Azure.ResourceManager.Foundations.CheckNameAvailabilityRequest,
-    Azure.ResourceManager.Foundations.CheckNameAvailabilityResponse
+    Azure.ResourceManager.Foundations.CheckNameAvailabilityResponse,
+    BodyParameter = {
+      @doc("NameAvailabilityRequest object.")
+      @bodyRoot
+      body: Azure.ResourceManager.Foundations.CheckNameAvailabilityRequest;
+    }
   >;
 
   /**
    * Fix the AppComplianceAutomation report error. e.g: App Compliance Automation Tool service unregistered, automation removed.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Report_Fix")
   fix is ArmResourceActionAsync<
     ReportResource,
     void,
@@ -137,8 +130,6 @@ interface Report {
   /**
    * Fix the AppComplianceAutomation report error. e.g: App Compliance Automation Tool service unregistered, automation removed.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Report_GetScopingQuestions")
   getScopingQuestions is ArmResourceActionSync<
     ReportResource,
     void,
@@ -149,8 +140,6 @@ interface Report {
   /**
    * Verify the AppComplianceAutomation report health status.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "For backward compatibility"
-  @operationId("Report_Verify")
   verify is ArmResourceActionAsync<
     ReportResource,
     void,
@@ -173,19 +162,9 @@ interface Report {
 @@doc(Report.update::parameters.properties,
   "Parameters for the create or update operation"
 );
-@@doc(Report.syncCertRecord::parameters.body,
-  "Parameters for synchronize certification record operation"
-);
-@@doc(Report.checkNameAvailability::parameters.body,
-  "NameAvailabilityRequest object."
-);
+
 #suppress "deprecated" "LEGACY - DO NOT COPY - FIX"
 @@encodedName(Report.update::parameters.properties,
   "application/json",
   "parameters"
 );
-
-@@encodedName(Report.syncCertRecord::parameters.body,
-  "application/json",
-  "parameters"
-);