Allow ARM Auto-Signoff for incremental TypeSpec even when NotReadyForARMReview

- Remove NotReadyForARMReview check from arm-auto-signoff workflow
- Update summarize-checks to respect auto-signoff labels and prevent ping-pong
- Add incremental TypeSpec test: department and jobTitle properties

Author: tejaswiMinnu

.github/workflows/arm-auto-signoff-status.yaml

@@ -49,7 +49,6 @@ jobs:
         github.event.label.name == 'ARMAutoSignedOff-Trivial' ||
         github.event.label.name == 'ARMReview' ||
         github.event.label.name == 'ARMSignedOff' ||
-        github.event.label.name == 'NotReadyForARMReview' ||
         github.event.label.name == 'SuppressionReviewRequired'))
 
     runs-on: ubuntu-slim

.github/workflows/src/arm-auto-signoff/arm-auto-signoff-status.js

@@ -157,7 +157,6 @@ export async function getLabelActionImpl({ owner, repo, issue_number, head_sha,
 
   const allLabelsMatch =
     labelNames.includes("ARMReview") &&
-    !labelNames.includes("NotReadyForARMReview") &&
     (!labelNames.includes("SuppressionReviewRequired") ||
       labelNames.includes("Approved-Suppression"));
 

.github/workflows/src/summarize-checks/labelling.js

@@ -659,18 +659,31 @@ function processARMReviewWorkflowLabels(
 
   const blocked = blockedOnRpaas || blockedOnVersioningPolicy || blockedOnArmModeling;
 
+  // Check if ARM auto-signoff workflow has determined the PR qualifies for auto sign-off.
+  // If so, respect that decision and don't remove ARMSignedOff even when blocked.
+  // This prevents ping-pong between arm-auto-signoff and summarize-checks workflows.
+  const hasAutoSignedOffLabels =
+    labelContext.present.has("ARMAutoSignedOff") ||
+    labelContext.present.has("ARMAutoSignedOff-IncrementalTSP") ||
+    labelContext.present.has("ARMAutoSignedOff-Trivial");
+
+  const autoSignedOff = hasAutoSignedOffLabels && armSignedOffLabel.present;
+
   // If given PR is in scope of ARM review and it is blocked for any reason,
   // the "NotReadyForARMReview" label should be present, to the exclusion
   // of all other ARM review workflow labels.
-  notReadyForArmReviewLabel.shouldBePresent = armReviewLabelShouldBePresent && blocked;
+  // Exception: If auto-signoff has determined the PR qualifies, ARMSignedOff takes precedence.
+  notReadyForArmReviewLabel.shouldBePresent =
+    armReviewLabelShouldBePresent && blocked && !autoSignedOff;
 
   // If given PR is in scope of ARM review and the review is not blocked,
   // then "ARMSignedOff" label should remain present on the PR if it was
   // already present. This means that labels "ARMChangesRequested"
   // and "WaitForARMFeedback" are invalid and will be removed by automation
   // in presence of "ARMSignedOff".
+  // Also preserve ARMSignedOff if auto-signoff labels are present (even when blocked).
   armSignedOffLabel.shouldBePresent =
-    armReviewLabelShouldBePresent && !blocked && armSignedOffLabel.present;
+    armReviewLabelShouldBePresent && (!blocked || autoSignedOff) && armSignedOffLabel.present;
 
   // If given PR is in scope of ARM review and the review is not blocked and
   // not signed-off, then the label "ARMChangesRequested" should remain present

.github/workflows/test/arm-auto-signoff/arm-auto-signoff-status.test.js

@@ -290,7 +290,7 @@ describe("getLabelActionImpl", () => {
 
   it.each([
     { labels: ["ARMAutoSignedOff-IncrementalTSP"] },
-    { labels: ["ARMAutoSignedOff-IncrementalTSP", "ARMReview", "NotReadyForARMReview"] },
+    // NotReadyForARMReview check removed - no longer blocks auto-signoff
     { labels: ["ARMAutoSignedOff-IncrementalTSP", "ARMReview", "SuppressionReviewRequired"] },
   ])("removes label if not all labels match ($labels)", async ({ labels }) => {
     const github = createMockGithub({ incrementalTypeSpec: true });

specification/widget/resource-manager/Microsoft.Widget/Widget/employee.tsp

@@ -23,6 +23,12 @@ model EmployeeProperties {
   /** City of employee */
   city?: string;
 
+  /** Department where the employee works */
+  department?: string;
+
+  /** Job title of the employee */
+  jobTitle?: string;
+
   /** Profile of employee */
   @encode("base64url")
   profile?: bytes;