Merge branch 'main' into compute-2026-03-02

Author: haagha

.github/workflows/spec-gen-sdk-status.yaml

@@ -3,6 +3,11 @@ name: "SDK Validation Status"
 on:
   check_run:
     types: [completed]
+  # Azure DevOps pipelines (which report the "SDK Validation" check runs) do not re-trigger when a
+  # PR is reopened, so the "check_run" event alone would never refresh the status. Re-evaluate the
+  # existing check runs on reopen using pull_request_target (privileged, runs in the target branch).
+  pull_request_target:
+    types: [reopened]
 
 permissions:
   contents: read
@@ -13,13 +18,23 @@ permissions:
 jobs:
   sdk-validation-status:
     if: |
-      github.event.check_run.check_suite.app.name == 'Azure Pipelines' &&
-      contains(github.event.check_run.name, 'SDK Validation')
+      github.event_name == 'pull_request_target' ||
+      (github.event.check_run.check_suite.app.name == 'Azure Pipelines' &&
+      contains(github.event.check_run.name, 'SDK Validation'))
     name: "SDK Validation Status"
     runs-on: ubuntu-slim
     steps:
+      # *** IMPORTANT ***
+      # For workflows that are triggered by the pull_request_target event, the workflow runs in the
+      # context of the base of the pull request.  You should make sure that you do not check out,
+      # build, or run untrusted code from the head of the pull request.
       - uses: actions/checkout@v6
         with:
+          # Only needs .github folder for automation, not the files in the PR (analyzed in a
+          # separate workflow).
+          #
+          # Uses the .github folder from the PR base branch (pull_request_target trigger),
+          # or the repo default branch (other triggers).
           sparse-checkout: |
             .github
 

.github/workflows/src/spec-gen-sdk-status.js

@@ -75,6 +75,14 @@ export async function setSpecGenSdkStatusImpl({
     core.info(`- ${check.name}: ${check.status} (${check.conclusion})`);
   }
 
+  // No SDK Validation check runs exist for this commit (e.g. a PR without SDK-relevant changes that
+  // was reopened). Skip setting a status, to avoid creating a spurious "pending" status that would
+  // never be resolved, since the Azure DevOps pipelines won't run for such PRs.
+  if (specGenSdkChecks.length === 0) {
+    core.info("No SDK Validation check runs found. Skipping status update.");
+    return;
+  }
+
   // Check if all SDK generation checks have completed
   const allCompleted =
     specGenSdkChecks.length > 0 &&

.github/workflows/test/spec-gen-sdk-status.test.js

@@ -352,4 +352,30 @@ describe("spec-gen-sdk-status", () => {
       }),
     );
   });
+
+  it("should skip status update when no SDK Validation checks are found", async () => {
+    // Simulates a reopened PR with no SDK-relevant changes: no SDK Validation check runs exist.
+    mockGithub.rest.checks.listForRef.mockResolvedValue({
+      data: {
+        check_runs: [],
+      },
+    });
+
+    await setSpecGenSdkStatusImpl({
+      owner: "testOwner",
+      repo: "testRepo",
+      head_sha: "testSha",
+      target_url: "https://example.com",
+      github: mockGithub,
+      core: mockCore,
+      issue_number: 123,
+    });
+
+    // No status should be set when there are no SDK Validation checks.
+    expect(mockGithub.rest.repos.createCommitStatus).not.toHaveBeenCalled();
+
+    // Outputs should still be set for downstream artifact upload steps.
+    expect(mockCore.setOutput).toBeCalledWith("head_sha", "testSha");
+    expect(mockCore.setOutput).toBeCalledWith("issue_number", 123);
+  });
 });

eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1

@@ -1240,8 +1240,6 @@ function Get-ReleasePlansForCPEXAttestation()
   $query += " AND [System.Tags] NOT CONTAINS 'APEX out of scope'"
   $query += " AND [System.Tags] NOT CONTAINS 'validate APEX out of scope'"
   $query += " AND [Custom.ProductServiceTreeID] <> ''"
-  $query += " AND [Custom.ProductLifecycle] <> ''"
-  $query += " AND [Custom.ProductType] IN ('Feature', 'Offering', 'Sku')"
 
   $workItems = Invoke-Query $fields $query
   return $workItems

specification/azureresiliencemanagement/resource-manager/Microsoft.AzureResilienceManagement/AzureResilienceManagement/client.tsp

@@ -4,6 +4,7 @@ import "@azure-tools/typespec-client-generator-core";
 using Azure.ClientGenerator.Core;
 using Microsoft.AzureResilienceManagement;
 using Azure.Core;
+using Azure.ResourceManager;
 
 @@clientName(
   Microsoft.AzureResilienceManagement,
@@ -146,3 +147,39 @@ using Azure.Core;
 @@clientName(GoalType, "ResilienceManagementGoalType", "csharp");
 @@clientName(MembershipType, "ResilienceManagementMembershipType", "csharp");
 @@clientName(JobStatus, "ResilienceManagementJobStatus", "csharp");
+
+// JavaScript SDK: use an update-specific model for RecoveryPlans.update.
+// RecoveryPlans.update is an ArmResourcePatch operation, but the modular JavaScript
+// emitter surfaces the full RecoveryPlanProperties on the PATCH body, exposing
+// server-side read-only and create-only fields (provisioningState, planType,
+// planState, latestFailoverStatus, latestValidationStatus, errorDetails) that
+// callers cannot set. The standalone models below mirror the generated PATCH body
+// (RecoveryPlanUpdate / RecoveryPlanPropertiesUpdate) and are substituted only for
+// JavaScript so the update payload contains just the updatable fields.
+// TODO: Remove this once the template has been updated to CustomPatch.
+
+@doc("Properties of the recovery orchestration plan that can be updated.")
+model RecoveryPlanUpdateProperties {
+  @doc("A description of the recovery orchestration plan.")
+  @minLength(5)
+  @maxLength(50)
+  planDescription?: string;
+
+  @doc("Settings for the recovery orchestration groups associated with the recovery orchestration plan.")
+  recoveryGroupsSetting?: RecoveryGroupsSetting;
+}
+
+@doc("Represents a recovery orchestration plan resource in the Azure Resilience Management provider namespace.")
+model RecoveryPlanUpdate {
+  @doc("The managed service identities assigned to this resource.")
+  identity?: CommonTypes.ManagedServiceIdentity;
+
+  @doc("The resource-specific properties for this resource.")
+  properties?: RecoveryPlanUpdateProperties;
+}
+
+@@alternateType(
+  Microsoft.AzureResilienceManagement.RecoveryPlans.update::parameters.properties,
+  RecoveryPlanUpdate,
+  "javascript"
+);

specification/azureresiliencemanagement/resource-manager/Microsoft.AzureResilienceManagement/AzureResilienceManagement/drillRun.tsp

@@ -31,10 +31,13 @@ interface DrillRuns {
   POST Actions
   */
   @route(ServiceGroupRoute)
+  @removed(Versions.v2026_06_01_preview)
+  @renamedFrom(Versions.v2026_06_01_preview, "failOver")
+  @sharedRoute
   @armResourceAction(DrillRun)
   @post
   @doc("This initiates a new Failover operation on this Drill Run.")
-  failOver is ArmResourceActionAsync<
+  failOverOld is ArmResourceActionAsync<
     DrillRun,
     DrillRunFailoverRequest,
     DrillRunActionResponse,
@@ -44,6 +47,23 @@ interface DrillRuns {
       Azure.Core.Foundations.RetryAfterHeader
   >;
 
+  @route(ServiceGroupRoute)
+  @added(Versions.v2026_06_01_preview)
+  @sharedRoute
+  @armResourceAction(DrillRun)
+  @post
+  @doc("This initiates a new Failover operation on this Drill Run.")
+  failOver is ArmResourceActionAsync<
+    DrillRun,
+    DrillRunFailoverRequest,
+    DrillRunActionResponse,
+    ServiceGroupAndRequestHeadersParameters,
+    LroHeaders = ArmAsyncOperationHeader &
+      ArmLroLocationHeader &
+      Azure.Core.Foundations.RetryAfterHeader,
+    OptionalRequestBody = true
+  >;
+
   @route(ServiceGroupRoute)
   @removed(Versions.v2026_04_01_preview)
   @armResourceAction(DrillRun)

specification/azureresiliencemanagement/resource-manager/Microsoft.AzureResilienceManagement/AzureResilienceManagement/examples/2026-04-01-preview/RecoveryJobs_Cancel_MaximumSet_Gen.json

@@ -4,6 +4,7 @@
   "parameters": {
     "serviceGroupName": "sampleServiceGroup",
     "api-version": "2026-04-01-preview",
+    "operation-id": "qmn",
     "recoveryPlanName": "samplePlanName",
     "recoveryJobName": "c56888ef-9ced-4001-a6d4-7145a0309bdb",
     "body": {

specification/azureresiliencemanagement/resource-manager/Microsoft.AzureResilienceManagement/AzureResilienceManagement/examples/2026-04-01-preview/RecoveryJobs_Resume_MaximumSet_Gen.json

@@ -4,6 +4,7 @@
   "parameters": {
     "serviceGroupName": "sampleServiceGroupName",
     "api-version": "2026-04-01-preview",
+    "operation-id": "qmn",
     "recoveryPlanName": "samplePlanName",
     "recoveryJobName": "c56888ef-9ced-4001-a6d4-7145a0309bdb",
     "body": {

specification/azureresiliencemanagement/resource-manager/Microsoft.AzureResilienceManagement/AzureResilienceManagement/examples/2026-04-01-preview/RecoveryJobs_Retry_MaximumSet_Gen.json

@@ -4,6 +4,7 @@
   "parameters": {
     "serviceGroupName": "sampleServiceGroupName",
     "api-version": "2026-04-01-preview",
+    "operation-id": "qmn",
     "recoveryPlanName": "samplePlanName",
     "recoveryJobName": "c56888ef-9ced-4001-a6d4-7145a0309bdb"
   },

specification/azureresiliencemanagement/resource-manager/Microsoft.AzureResilienceManagement/AzureResilienceManagement/examples/2026-04-01-preview/RecoveryPlanActions_FailoverCommit_MaximumSet_Gen.json

@@ -4,6 +4,7 @@
   "parameters": {
     "serviceGroupName": "sampleServiceGroupName",
     "api-version": "2026-04-01-preview",
+    "operation-id": "qmn",
     "recoveryPlanName": "samplePlanName"
   },
   "responses": {