Skip to content

Commit b630e1b

Browse files
melina5656melina5656
committed
remove operationid decorators
1 parent 7ff41b4 commit b630e1b

8 files changed

Lines changed: 32 additions & 48 deletions

File tree

‎specification/monitor/resource-manager/Microsoft.Insights/Insights/DiagnosticsSettings/DiagnosticSettingsCategoryResource.tsp‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ interface DiagnosticSettingsCategoryResources {
3030
/**
3131
* Gets the diagnostic settings category for the specified resource.
3232
*/
33-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
34-
@operationId("DiagnosticSettingsCategory_Get")
3533
@tag("DiagnosticSettingsCategories")
3634
get is Extension.Read<
3735
Extension.ScopeParameter,
@@ -42,8 +40,6 @@ interface DiagnosticSettingsCategoryResources {
4240
/**
4341
* Lists the diagnostic settings categories for the specified resource.
4442
*/
45-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
46-
@operationId("DiagnosticSettingsCategory_List")
4743
@tag("DiagnosticSettingsCategories")
4844
list is Extension.ListByTarget<
4945
Extension.ScopeParameter,

‎specification/monitor/resource-manager/Microsoft.Insights/Insights/DiagnosticsSettings/DiagnosticSettingsResource.tsp‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ interface DiagnosticSettingsResources {
3030
/**
3131
* Gets the active diagnostic settings for the specified resource.
3232
*/
33-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
34-
@operationId("DiagnosticSettings_Get")
3533
@tag("DiagnosticSettings")
3634
get is Extension.Read<
3735
Extension.ScopeParameter,
@@ -42,9 +40,7 @@ interface DiagnosticSettingsResources {
4240
/**
4341
* Creates or updates diagnostic settings for the specified resource.
4442
*/
45-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
4643
#suppress "@azure-tools/typespec-azure-resource-manager/arm-put-operation-response-codes" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
47-
@operationId("DiagnosticSettings_CreateOrUpdate")
4844
@tag("DiagnosticSettings")
4945
createOrUpdate is Extension.CreateOrReplaceSync<
5046
Extension.ScopeParameter,
@@ -56,8 +52,6 @@ interface DiagnosticSettingsResources {
5652
/**
5753
* Deletes existing diagnostic settings for the specified resource.
5854
*/
59-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
60-
@operationId("DiagnosticSettings_Delete")
6155
@tag("DiagnosticSettings")
6256
delete is Extension.DeleteSync<
6357
Extension.ScopeParameter,
@@ -68,8 +62,6 @@ interface DiagnosticSettingsResources {
6862
/**
6963
* Gets the active diagnostic settings list for the specified resource.
7064
*/
71-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
72-
@operationId("DiagnosticSettings_List")
7365
@tag("DiagnosticSettings")
7466
list is Extension.ListByTarget<
7567
Extension.ScopeParameter,

‎specification/monitor/resource-manager/Microsoft.Insights/Insights/DiagnosticsSettings/back-compatible.tsp‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,25 @@ using Azure.ClientGenerator.Core;
44
using Microsoft.Insights;
55

66
@@clientLocation(DiagnosticSettingsResources.get, "DiagnosticSettings");
7-
@@clientLocation(DiagnosticSettingsResources.createOrUpdate,
7+
@@clientLocation(
8+
DiagnosticSettingsResources.createOrUpdate,
89
"DiagnosticSettings"
910
);
10-
@@clientName(DiagnosticSettingsResources.createOrUpdate::parameters.resource,
11+
@@clientName(
12+
DiagnosticSettingsResources.createOrUpdate::parameters.resource,
1113
"parameters"
1214
);
1315
@@clientLocation(DiagnosticSettingsResources.delete, "DiagnosticSettings");
1416
@@clientLocation(DiagnosticSettingsResources.list, "DiagnosticSettings");
1517
#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
1618
@@Legacy.flattenProperty(DiagnosticSettingsResource.properties);
1719

18-
@@clientLocation(DiagnosticSettingsCategoryResources.get,
20+
@@clientLocation(
21+
DiagnosticSettingsCategoryResources.get,
1922
"DiagnosticSettingsCategory"
2023
);
21-
@@clientLocation(DiagnosticSettingsCategoryResources.list,
24+
@@clientLocation(
25+
DiagnosticSettingsCategoryResources.list,
2226
"DiagnosticSettingsCategory"
2327
);
2428
#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"

‎specification/monitor/resource-manager/Microsoft.Insights/Insights/TenantActionGroups/TenantActionGroupResource.tsp‎

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@ alias QuotaCounterKeyParentParameters = {
2727
...ApiVersionParameter;
2828

2929
/**
30-
* aaaaaaaaaaaaaaaaaaaaa
30+
* The management group id.
3131
*/
3232
@path
3333
@segment("managementGroups")
3434
@key
3535
managementGroupId: string;
3636

3737
/**
38-
* aaaaaaaaaaaaaaaaaaaaa
38+
* The name of the action group.
3939
*/
4040
@path
4141
@segment("tenantActionGroups")
@@ -48,7 +48,7 @@ alias QuotaCounterKeyParentParameters = {
4848

4949
alias QuotaCounterKeyParameters = {
5050
/**
51-
* aaaaaaaaaaaaaaaaaaaaaa
51+
* The notification id
5252
*/
5353
@path
5454
@key
@@ -69,8 +69,6 @@ interface TenantActionGroupResources {
6969
/**
7070
* Get a tenant action group.
7171
*/
72-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
73-
@operationId("TenantActionGroups_Get")
7472
get is Extension.Read<
7573
Extension.ManagementGroup<"managementGroupId">,
7674
TenantActionGroupResource,
@@ -88,8 +86,6 @@ interface TenantActionGroupResources {
8886
/**
8987
* Create a new tenant action group or update an existing one.
9088
*/
91-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
92-
@operationId("TenantActionGroups_CreateOrUpdate")
9389
createOrUpdate is Extension.CreateOrReplaceSync<
9490
Extension.ManagementGroup<"managementGroupId">,
9591
TenantActionGroupResource,
@@ -107,8 +103,6 @@ interface TenantActionGroupResources {
107103
/**
108104
* Updates an existing tenant action group's tags. To update other fields use the CreateOrUpdate method.
109105
*/
110-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
111-
@operationId("TenantActionGroups_Update")
112106
@patch(#{ implicitOptionality: false })
113107
update is Extension.CustomPatchSync<
114108
Extension.ManagementGroup<"managementGroupId">,
@@ -128,8 +122,6 @@ interface TenantActionGroupResources {
128122
/**
129123
* Delete a tenant action group.
130124
*/
131-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
132-
@operationId("TenantActionGroups_Delete")
133125
delete is Extension.DeleteSync<
134126
Extension.ManagementGroup<"managementGroupId">,
135127
TenantActionGroupResource,
@@ -147,8 +139,6 @@ interface TenantActionGroupResources {
147139
/**
148140
* Get a list of all tenant action groups in a management group.
149141
*/
150-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
151-
@operationId("TenantActionGroups_ListByManagementGroupId")
152142
listByManagementGroupId is Extension.ListByTarget<
153143
Extension.ManagementGroup<"managementGroupId">,
154144
TenantActionGroupResource,
@@ -167,8 +157,6 @@ interface TenantActionGroupResources {
167157
/**
168158
* Send test notifications to a set of provided receivers
169159
*/
170-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
171-
@operationId("CreateNotificationsAtTenantActionGroupResourceLevel")
172160
@action("createNotifications")
173161
createNotificationsAtTenantActionGroupResourceLevel is Extension.ActionAsync<
174162
Extension.ManagementGroup<"managementGroupId">,
@@ -188,8 +176,6 @@ interface TenantActionGroupResources {
188176
/**
189177
* Get the test notifications by the notification id
190178
*/
191-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
192-
@operationId("GetTestNotificationsAtTenantActionGroupResourceLevel")
193179
@get
194180
@action("{notificationId}")
195181
@route("/providers/microsoft.Management/managementGroups/{managementGroupId}/providers/microsoft.Insights/tenantActionGroups/{tenantActionGroupName}/notificationStatus/{notificationId}")

‎specification/monitor/resource-manager/Microsoft.Insights/Insights/TenantActionGroups/back-compatible.tsp‎

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,28 +7,35 @@ using Microsoft.Insights;
77
@@Legacy.flattenProperty(ActionGroupPatchBody.properties);
88

99
@@clientLocation(TenantActionGroupResources.get, "TenantActionGroups");
10-
@@clientLocation(TenantActionGroupResources.createOrUpdate,
10+
@@clientLocation(
11+
TenantActionGroupResources.createOrUpdate,
1112
"TenantActionGroups"
1213
);
13-
@@clientName(TenantActionGroupResources.createOrUpdate::parameters.resource,
14+
@@clientName(
15+
TenantActionGroupResources.createOrUpdate::parameters.resource,
1416
"actionGroup"
1517
);
1618
@@clientLocation(TenantActionGroupResources.update, "TenantActionGroups");
17-
@@clientName(TenantActionGroupResources.update::parameters.properties,
19+
@@clientName(
20+
TenantActionGroupResources.update::parameters.properties,
1821
"tenantActionGroupPatch"
1922
);
2023
@@clientLocation(TenantActionGroupResources.delete, "TenantActionGroups");
21-
@@clientLocation(TenantActionGroupResources.listByManagementGroupId,
24+
@@clientLocation(
25+
TenantActionGroupResources.listByManagementGroupId,
2226
"TenantActionGroups"
2327
);
24-
@@clientLocation(TenantActionGroupResources.createNotificationsAtTenantActionGroupResourceLevel,
25-
""
28+
@@clientLocation(
29+
TenantActionGroupResources.createNotificationsAtTenantActionGroupResourceLevel,
30+
Microsoft.Insights
2631
);
27-
@@clientName(TenantActionGroupResources.createNotificationsAtTenantActionGroupResourceLevel::parameters.body,
32+
@@clientName(
33+
TenantActionGroupResources.createNotificationsAtTenantActionGroupResourceLevel::parameters.body,
2834
"notificationRequest"
2935
);
30-
@@clientLocation(TenantActionGroupResources.getTestNotificationsAtTenantActionGroupResourceLevel,
31-
""
36+
@@clientLocation(
37+
TenantActionGroupResources.getTestNotificationsAtTenantActionGroupResourceLevel,
38+
Microsoft.Insights
3239
);
3340
#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
3441
@@Legacy.flattenProperty(TenantActionGroupResource.properties);

‎specification/monitor/resource-manager/Microsoft.Insights/Insights/VmInsightsOnboarding/VMInsightsOnboardingStatus.tsp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ interface VMInsightsOnboardingStatuses {
3333
/**
3434
* Retrieves the VM Insights onboarding status for the specified resource or resource scope.
3535
*/
36-
#suppress "@azure-tools/typespec-azure-core/no-openapi" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
37-
@operationId("VMInsights_GetOnboardingStatus")
3836
@tag("VM Insights Onboarding")
3937
getOnboardingStatus is Extension.Read<
4038
Extension.ScopeParameter,

‎specification/monitor/resource-manager/Microsoft.Insights/Insights/VmInsightsOnboarding/back-compatible.tsp‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ using Microsoft.Insights;
66
#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
77
@@Legacy.flattenProperty(WorkspaceInfo.properties);
88

9-
@@clientLocation(VMInsightsOnboardingStatuses.getOnboardingStatus,
9+
@@clientLocation(
10+
VMInsightsOnboardingStatuses.getOnboardingStatus,
1011
"VMInsights"
1112
);
1213
#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"

‎specification/monitor/resource-manager/Microsoft.Insights/Insights/preview/2023-05-01-preview/tenantActionGroups.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -420,14 +420,14 @@
420420
{
421421
"name": "managementGroupId",
422422
"in": "path",
423-
"description": "aaaaaaaaaaaaaaaaaaaaa",
423+
"description": "The management group id.",
424424
"required": true,
425425
"type": "string"
426426
},
427427
{
428428
"name": "tenantActionGroupName",
429429
"in": "path",
430-
"description": "aaaaaaaaaaaaaaaaaaaaa",
430+
"description": "The name of the action group.",
431431
"required": true,
432432
"type": "string",
433433
"minLength": 1,
@@ -437,7 +437,7 @@
437437
{
438438
"name": "notificationId",
439439
"in": "path",
440-
"description": "aaaaaaaaaaaaaaaaaaaaaa",
440+
"description": "The notification id",
441441
"required": true,
442442
"type": "string"
443443
},

0 commit comments

Comments
 (0)