Fix TypeSpec LRO operations: remove @extension, use @useFinalStateVia (#43308)

* Fix TypeSpec LRO: remove @extension, use @useFinalStateVia, GET returns 200+202

Root cause of the original bug: @extension("x-ms-long-running-operation", true)
only affects the OpenAPI document. Combined with @pollingOperation pointing
at a non-status-monitor endpoint, the SDK generators did not detect
ScenarioConfigurations.execute and ScenarioRuns.cancel as LROs, emitting
them as plain void methods.

This change:

* Removes @extension and @pollingOperation from execute/cancel.
* Adds @Azure.Core.useFinalStateVia("location") on the LRO templates in
  lro-helpers.tsp so SDK generators emit proper SyncPoller/ArmOperation
  methods that follow the Location header to poll for completion.
* Keeps the GET on ScenarioRun returning both 200 (final) and 202 (in
  progress, with body + Location/Retry-After headers). The Location-
  header polling protocol REQUIRES 202 while in progress and 200 on
  completion; @lroStatus on the status field is only consulted by the
  Azure-AsyncOperation status-monitor pattern, not by Location-header
  polling. Uses ArmResourceRead's Response template variable per
  reviewer's suggestion to express the 200|202 union.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address ScenarioRun polling response review comments

Use the built-in TypeSpec url scalar for the Location header and add explicit bounds for the Retry-After header on the in-progress polling response.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address Chaos .NET SDK API review naming comments

Add csharp client-name customizations for new public Chaos SDK model/resource names and model ARM ID fields as armResourceIdentifier so the generated .NET SDK uses ResourceIdentifier.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Format Chaos TypeSpec client customizations

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: 3 people

specification/chaos/resource-manager/Microsoft.Chaos/Chaos/client.tsp

@@ -9,6 +9,10 @@ using Microsoft.Chaos;
 @@clientName(Scenario, "ChaosScenario", "csharp");
 @@clientName(ScenarioRun, "ChaosScenarioRun", "csharp");
 @@clientName(ScenarioConfiguration, "ChaosScenarioConfiguration", "csharp");
+@@clientName(DiscoveredResource, "ChaosDiscovered", "csharp");
+@@clientName(PrivateAccess, "ChaosPrivateAccess", "csharp");
+@@clientName(PrivateAccessPatch, "ChaosPrivateAccessPatch", "csharp");
+@@clientName(PrivateAccessProperties, "ChaosPrivateAccessProperties", "csharp");
 @@clientName(ExperimentExecution, "ChaosExperimentExecution", "csharp");
 @@clientName(Experiment, "ChaosExperiment", "csharp");
 @@clientName(ExperimentExecution, "ChaosExperimentExecution", "csharp");
@@ -52,6 +56,25 @@ using Microsoft.Chaos;
 @@clientName(Action, "ChaosAction", "csharp");
 @@clientName(ActionVersion, "ChaosActionVersion", "csharp");
 @@clientName(ActionKind, "ChaosActionKind", "csharp");
+@@clientName(
+  ConfigurationExclusions,
+  "ChaosScenarioConfigurationExclusions",
+  "csharp"
+);
+@@clientName(
+  ConfigurationFilters,
+  "ChaosScenarioConfigurationFilters",
+  "csharp"
+);
+@@clientName(OperationError, "ChaosOperationError", "csharp");
+@@clientName(ScenarioParameter.required, "IsRequired", "csharp");
+@@clientName(ParameterType, "ChaosScenarioParameterType", "csharp");
+@@clientName(FixResourcePermissionsRequest.whatIf, "IsWhatIf", "csharp");
+@@clientName(PermissionsFix, "ChaosPermissionsFixData", "csharp");
+@@clientName(PermissionsFixProperties.whatIfMode, "IsWhatIfMode", "csharp");
+@@clientName(Recommendation, "ChaosScenarioRecommendation", "csharp");
+@@clientName(Validation, "ChaosScenarioValidationData", "csharp");
+@@clientName(WorkspaceEvaluation, "ChaosWorkspaceEvaluationData", "csharp");
 @@clientName(
   ActionSupportedTargetType,
   "ChaosActionSupportedTargetType",

specification/chaos/resource-manager/Microsoft.Chaos/Chaos/lro-helpers.tsp

@@ -2,13 +2,11 @@ import "@azure-tools/typespec-azure-core";
 import "@azure-tools/typespec-azure-resource-manager";
 import "@typespec/http";
 import "@typespec/rest";
-import "@typespec/openapi";
 
 using Azure.ResourceManager;
 using Azure.Core;
 using TypeSpec.Http;
 using TypeSpec.Rest;
-using TypeSpec.OpenAPI;
 
 namespace Microsoft.Chaos;
 
@@ -24,15 +22,10 @@ namespace Microsoft.Chaos;
 #suppress "@azure-tools/typespec-azure-core/documentation-required" "template"
 #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-operation" "template"
 #suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "Custom LRO operation with specific response codes"
-#suppress "@azure-tools/typespec-azure-core/no-openapi" "Required for LRO extensions in OpenAPI output"
 @autoRoute
 @armResourceAction(Resource)
 @post
-@extension("x-ms-long-running-operation", true)
-@extension(
-  "x-ms-long-running-operation-options",
-  #{ `final-state-via`: "location" }
-)
+@Azure.Core.useFinalStateVia("location")
 op ArmResourceActionAsyncWithLocation<
   Resource extends Azure.ResourceManager.Foundations.Resource,
   Request extends TypeSpec.Reflection.Model | void,
@@ -67,15 +60,10 @@ op ArmResourceActionAsyncWithLocation<
 #suppress "@azure-tools/typespec-azure-core/documentation-required" "template"
 #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-operation" "template"
 #suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "Custom LRO operation with specific response codes"
-#suppress "@azure-tools/typespec-azure-core/no-openapi" "Required for LRO extensions in OpenAPI output"
 @autoRoute
 @armResourceAction(Resource)
 @post
-@extension("x-ms-long-running-operation", true)
-@extension(
-  "x-ms-long-running-operation-options",
-  #{ `final-state-via`: "location" }
-)
+@Azure.Core.useFinalStateVia("location")
 op ArmResourceActionNoContentAsyncWithLocationResult<
   Resource extends Azure.ResourceManager.Foundations.Resource,
   Request extends TypeSpec.Reflection.Model | void,
@@ -107,15 +95,10 @@ op ArmResourceActionNoContentAsyncWithLocationResult<
 #suppress "@azure-tools/typespec-azure-core/documentation-required" "template"
 #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-operation" "template"
 #suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "Custom LRO operation with specific response codes"
-#suppress "@azure-tools/typespec-azure-core/no-openapi" "Required for LRO extensions in OpenAPI output"
 @autoRoute
 @armResourceAction(Resource)
 @post
-@extension("x-ms-long-running-operation", true)
-@extension(
-  "x-ms-long-running-operation-options",
-  #{ `final-state-via`: "location" }
-)
+@Azure.Core.useFinalStateVia("location")
 op ArmResourceActionNoBodyAsyncWithLocation<
   Resource extends Azure.ResourceManager.Foundations.Resource,
   Request extends TypeSpec.Reflection.Model | void,

specification/chaos/resource-manager/Microsoft.Chaos/Chaos/preview/2024-11-01-preview/openapi.json

@@ -1290,7 +1290,7 @@
         "tags": [
           "Experiments"
         ],
-        "description": "The operation to update an experiment.",
+        "description": "Update an experiment.",
         "parameters": [
           {
             "$ref": "../../../../../../common-types/resource-management/v5/types.json#/parameters/ApiVersionParameter"

specification/chaos/resource-manager/Microsoft.Chaos/Chaos/preview/2026-05-01-preview/openapi.json

@@ -85,10 +85,10 @@
       "name": "Scenarios"
     },
     {
-      "name": "ScenarioRuns"
+      "name": "ScenarioConfigurations"
     },
     {
-      "name": "ScenarioConfigurations"
+      "name": "ScenarioRuns"
     }
   ],
   "paths": {
@@ -3836,8 +3836,7 @@
         "tags": [
           "ScenarioRuns"
         ],
-        "summary": "Get a scenario run.",
-        "description": "Get a scenario run.",
+        "description": "Get a scenario run.\n\nThis endpoint is also the polling target for ScenarioConfigurations.execute\nand ScenarioRuns.cancel (final-state-via: location). While the run is in\nprogress the service returns 202 with a Location header pointing back to\nthis URL; clients must keep polling until they receive 200, which carries\nthe final ScenarioRun body.",
         "parameters": [
           {
             "$ref": "../../../../../../common-types/resource-management/v5/types.json#/parameters/ApiVersionParameter"
@@ -3883,19 +3882,22 @@
             }
           },
           "202": {
-            "description": "The request has been accepted for processing, but processing has not yet completed.",
+            "description": "Indicates the scenario run is still in progress. Clients polling via the\nLocation header should continue polling until a 200 response is returned.\nThe body reflects the current run state at the time of the poll.",
             "schema": {
               "$ref": "#/definitions/ScenarioRun"
             },
             "headers": {
               "Location": {
                 "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+                "format": "uri",
+                "description": "The URL where the status of the long-running operation can be polled."
               },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
-                "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
+                "description": "The number of seconds the client should wait before polling again.",
+                "minimum": 0,
+                "maximum": 2147483647
               }
             }
           },
@@ -5456,6 +5458,7 @@
       "properties": {
         "resourceId": {
           "type": "string",
+          "format": "arm-id",
           "description": "The resource id for the affected resource.",
           "readOnly": true
         },
@@ -6091,6 +6094,7 @@
       "properties": {
         "resourceId": {
           "type": "string",
+          "format": "arm-id",
           "description": "The resource id for the affected resource.",
           "readOnly": true
         },
@@ -6144,6 +6148,7 @@
       "properties": {
         "targetResourceId": {
           "type": "string",
+          "format": "arm-id",
           "description": "The target Azure resource ID.",
           "readOnly": true
         },
@@ -6174,6 +6179,7 @@
         },
         "roleAssignmentId": {
           "type": "string",
+          "format": "arm-id",
           "description": "The created role assignment resource ID (null if failed or what-if mode).",
           "readOnly": true
         },
@@ -7345,6 +7351,7 @@
         },
         "workspaceId": {
           "type": "string",
+          "format": "arm-id",
           "description": "The workspace ID this evaluation belongs to.",
           "readOnly": true
         },

specification/chaos/resource-manager/Microsoft.Chaos/Chaos/scenarioConfiguration.models.tsp

@@ -223,7 +223,7 @@ model PermissionError {
    * The resource id for the affected resource.
    */
   @visibility(Lifecycle.Read)
-  resourceId: string;
+  resourceId: Azure.Core.armResourceIdentifier;
 
   /**
    * The missing permissions.
@@ -275,7 +275,7 @@ model ResourceStateError {
    * The resource id for the affected resource.
    */
   @visibility(Lifecycle.Read)
-  resourceId: string;
+  resourceId: Azure.Core.armResourceIdentifier;
 
   /**
    * The error code.
@@ -418,7 +418,7 @@ model RoleAssignmentResult {
    * The target Azure resource ID.
    */
   @visibility(Lifecycle.Read)
-  targetResourceId: string;
+  targetResourceId: Azure.Core.armResourceIdentifier;
 
   /**
    * The managed identity principal ID.
@@ -454,7 +454,7 @@ model RoleAssignmentResult {
    * The created role assignment resource ID (null if failed or what-if mode).
    */
   @visibility(Lifecycle.Read)
-  roleAssignmentId?: string;
+  roleAssignmentId?: Azure.Core.armResourceIdentifier;
 
   /**
    * Error details if the assignment failed.

specification/chaos/resource-manager/Microsoft.Chaos/Chaos/scenarioConfiguration.tsp

@@ -48,8 +48,6 @@ interface ScenarioConfigurations {
   /**
    * Execute the scenario execution with the given scenario configuration.
    */
-  #suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "LRO POST returns 202 with Location header for polling; final result obtained by polling the Location URL"
-  @pollingOperation(ScenarioRuns.get)
   execute is ArmResourceActionNoContentAsyncWithLocationResult<
     ScenarioConfiguration,
     void,
@@ -59,9 +57,7 @@ interface ScenarioConfigurations {
   /**
    * Cancel the currently running scenario execution.
    */
-  #suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "LRO POST returns 202 with Location header for polling; final result obtained by polling the Location URL"
   @removed(Microsoft.Chaos.Versions.v2026_05_01_preview)
-  @pollingOperation(ScenarioRuns.get)
   cancel is ArmResourceActionNoContentAsyncWithLocationResult<
     ScenarioConfiguration,
     void,
@@ -71,7 +67,6 @@ interface ScenarioConfigurations {
   /**
    * Validate the given scenario configuration.
    */
-  #suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "LRO POST returns 202 with Location header for polling; final result obtained by polling the Location URL"
   validate is ArmResourceActionNoContentAsyncWithLocationResult<
     ScenarioConfiguration,
     void,
@@ -81,7 +76,6 @@ interface ScenarioConfigurations {
   /**
    * Fixes resource permissions for the given scenario configuration.
    */
-  #suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "LRO POST returns 202 with Location header for polling; final result obtained by polling the Location URL"
   fixResourcePermissions is ArmResourceActionNoContentAsyncWithLocationResult<
     ScenarioConfiguration,
     FixResourcePermissionsRequest,

specification/chaos/resource-manager/Microsoft.Chaos/Chaos/scenarioRun.models.tsp

@@ -5,12 +5,41 @@ import "@azure-tools/typespec-azure-resource-manager";
 import "./scenario.models.tsp";
 
 using TypeSpec.Rest;
+using TypeSpec.Http;
 using Azure.ResourceManager;
 using Azure.Core;
 using Azure.Core.Traits;
 
 namespace Microsoft.Chaos;
 
+/**
+ * Indicates the scenario run is still in progress. Clients polling via the
+ * Location header should continue polling until a 200 response is returned.
+ * The body reflects the current run state at the time of the poll.
+ */
+model ScenarioRunInProgressResponse {
+  ...AcceptedResponse;
+
+  /**
+   * The URL where the status of the long-running operation can be polled.
+   */
+  @header("Location")
+  location: url;
+
+  /**
+   * The number of seconds the client should wait before polling again.
+   */
+  @minValue(0)
+  @maxValue(2147483647)
+  @header("Retry-After")
+  retryAfter?: int32;
+
+  /**
+   * The current scenario run state at the time of the poll.
+   */
+  @bodyRoot body: ScenarioRun;
+}
+
 /**
  * Model that represents the scenario run.
  */

specification/chaos/resource-manager/Microsoft.Chaos/Chaos/scenarioRun.tsp

@@ -2,7 +2,6 @@ import "@azure-tools/typespec-azure-core";
 import "@azure-tools/typespec-azure-resource-manager";
 import "@typespec/rest";
 import "@typespec/http";
-import "@typespec/openapi";
 import "./scenarioRun.models.tsp";
 import "./lro-helpers.tsp";
 
@@ -11,37 +10,28 @@ using Azure.Core;
 using TypeSpec.Versioning;
 using TypeSpec.Http;
 using TypeSpec.Rest;
-using TypeSpec.OpenAPI;
 
 namespace Microsoft.Chaos;
 
 @added(Microsoft.Chaos.Versions.v2026_05_01_preview)
+@removed(Microsoft.Chaos.Versions.v2025_01_01)
 @armResourceOperations
 interface ScenarioRuns {
   /**
    * Get a scenario run.
+   *
+   * This endpoint is also the polling target for ScenarioConfigurations.execute
+   * and ScenarioRuns.cancel (final-state-via: location). While the run is in
+   * progress the service returns 202 with a Location header pointing back to
+   * this URL; clients must keep polling until they receive 200, which carries
+   * the final ScenarioRun body.
    */
-  #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-operation" "LRO polling endpoint that returns body in both 200 and 202"
-  #suppress "@azure-tools/typespec-azure-resource-manager/no-response-body" "LRO polling endpoint returns body in 202 to reflect current status"
-  #suppress "@azure-tools/typespec-azure-core/polling-operation-no-status-monitor" "LRO uses final-state-via:location pattern, not status monitor"
-  @summary("Get a scenario run.")
-  @autoRoute
-  @armResourceRead(ScenarioRun)
-  @get
-  get(...ResourceInstanceParameters<ScenarioRun>):
-    | ArmResponse<ScenarioRun>
-    | (AcceptedResponse & {
-        @doc("The Location header contains the URL where the status of the long running operation can be checked.")
-        @header("Location")
-        location: string;
-
-        @doc("The Retry-After header can indicate how long the client should wait before polling the operation status.")
-        @header("Retry-After")
-        retryAfter?: int32;
-
-        @bodyRoot body: ScenarioRun;
-      })
-    | ErrorResponse;
+  #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-operation" "LRO polling endpoint that returns body in both 200 and 202 responses."
+  #suppress "@azure-tools/typespec-azure-resource-manager/no-response-body" "LRO polling endpoint returns body in 202 to reflect the current run state."
+  get is ArmResourceRead<
+    ScenarioRun,
+    Response = ArmResponse<ScenarioRun> | ScenarioRunInProgressResponse
+  >;
 
   /**
    * Get a list of scenario runs.
@@ -54,10 +44,7 @@ interface ScenarioRuns {
   /**
    * Cancel the currently running scenario execution.
    */
-  #suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "LRO POST returns 202 with Location header for polling; final result obtained by polling the Location URL"
-  #suppress "@azure-tools/typespec-azure-core/polling-operation-no-status-monitor" "LRO uses final-state-via:location pattern"
   @added(Microsoft.Chaos.Versions.v2026_05_01_preview)
-  @pollingOperation(ScenarioRuns.get)
   cancel is ArmResourceActionNoContentAsyncWithLocationResult<
     ScenarioRun,
     void,

specification/chaos/resource-manager/Microsoft.Chaos/Chaos/workspace.tsp

@@ -71,7 +71,6 @@ interface Workspaces {
   /**
    * Refreshes recommendation status for all scenarios in a given workspace.
    */
-  #suppress "@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes" "Async LRO POST returning 202 + Location, not a synchronous POST"
   refreshRecommendations is ArmResourceActionNoContentAsyncWithLocationResult<
     Workspace,
     void,

specification/chaos/resource-manager/Microsoft.Chaos/Chaos/workspaceEvaluation.models.tsp

@@ -60,7 +60,7 @@ model WorkspaceEvaluationProperties {
    * The workspace ID this evaluation belongs to.
    */
   @visibility(Lifecycle.Read)
-  workspaceId: string;
+  workspaceId: Azure.Core.armResourceIdentifier;
 
   /**
    * The number of scenarios to evaluate.