Skip to content

Commit f9b172d

Browse files
Add csharp customizations for Monitor migration (#43812)
1 parent c8c062b commit f9b172d

6 files changed

Lines changed: 1340 additions & 34 deletions

File tree

specification/monitor/cspell.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ import:
99
words:
1010
- adece
1111
- amcs
12+
- ampm
1213
- azlogs
1314
- azmetrics
1415
- azns
16+
- bcdr
1517
- byval
1618
- ciis
1719
- dcrmetadata
@@ -46,4 +48,3 @@ overrides:
4648
- occurringlocation
4749
- routingid
4850
- tsgid
49-

specification/monitor/resource-manager/Microsoft.Insights/Insights/DataCollectionApi/DataCollectionRuleAssociationProxyOnlyResource.tsp

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,21 @@ model DataCollectionRuleAssociationProxyOnlyResource
2727
...Azure.ResourceManager.Legacy.EntityTagProperty;
2828
}
2929

30-
alias DataCollectionRuleAssociationProxyOnlyResourcesOps = Azure.ResourceManager.Legacy.LegacyOperations<
30+
alias DataCollectionRuleAssociationProxyOnlyResourcesOps = Azure.ResourceManager.Legacy.ExtensionOperations<
3131
{
3232
...ApiVersionParameter;
3333

3434
/**
35-
* The identifier of the resource.
35+
* The fully qualified Azure Resource manager identifier of the resource.
3636
*/
3737
@path(#{ allowReserved: true })
3838
@minLength(1)
3939
resourceUri: string;
40-
40+
},
41+
{
42+
...Azure.ResourceManager.Legacy.Provider;
43+
},
44+
{
4145
...Azure.ResourceManager.Legacy.Provider;
4246

4347
/**
@@ -47,7 +51,7 @@ alias DataCollectionRuleAssociationProxyOnlyResourcesOps = Azure.ResourceManager
4751
@segment("dataCollectionRuleAssociations")
4852
associationName: string;
4953
},
50-
{}
54+
"DataCollectionRuleAssociation"
5155
>;
5256

5357
@armResourceOperations(#{ omitTags: true })
@@ -57,10 +61,9 @@ interface DataCollectionRuleAssociationProxyOnlyResources {
5761
*/
5862
@tag("DataCollectionRuleAssociations")
5963
@summary("Returns the specified association.")
60-
get is Extension.Read<
61-
Extension.ScopeParameter,
64+
get is DataCollectionRuleAssociationProxyOnlyResourcesOps.Read<
6265
DataCollectionRuleAssociationProxyOnlyResource,
63-
Error = ErrorResponseCommonV2
66+
ErrorType = ErrorResponseCommonV2
6467
>;
6568

6669
/**
@@ -75,29 +78,27 @@ interface DataCollectionRuleAssociationProxyOnlyResources {
7578
Response =
7679
| DataCollectionRuleAssociationProxyOnlyResource
7780
| ArmResourceCreatedSyncResponse<DataCollectionRuleAssociationProxyOnlyResource>,
78-
OverrideErrorType = ErrorResponseCommonV2
81+
ErrorType = ErrorResponseCommonV2
7982
>;
8083

8184
/**
8285
* Deletes an association.
8386
*/
8487
@tag("DataCollectionRuleAssociations")
8588
@summary("Deletes an association.")
86-
delete is Extension.DeleteSync<
87-
Extension.ScopeParameter,
89+
delete is DataCollectionRuleAssociationProxyOnlyResourcesOps.DeleteSync<
8890
DataCollectionRuleAssociationProxyOnlyResource,
89-
Error = ErrorResponseCommonV2
91+
ErrorType = ErrorResponseCommonV2
9092
>;
9193

9294
/**
9395
* Lists associations for the specified resource.
9496
*/
9597
@tag("DataCollectionRuleAssociations")
9698
@summary("Lists associations for the specified resource.")
97-
listByResource is Extension.ListByTarget<
98-
Extension.ScopeParameter,
99+
listByResource is DataCollectionRuleAssociationProxyOnlyResourcesOps.List<
99100
DataCollectionRuleAssociationProxyOnlyResource,
100-
Error = ErrorResponseCommonV2
101+
ErrorType = ErrorResponseCommonV2
101102
>;
102103
}
103104

specification/monitor/resource-manager/Microsoft.Insights/Insights/PrivateLinkScopesApi/PrivateLinkResource.tsp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ namespace PrivateLinkScopesApi;
1414
/**
1515
* A private link resource
1616
*/
17-
@parentResource(AzureMonitorPrivateLinkScope)
1817
model PrivateLinkResource is PrivateLink;
1918
alias PrivateLinkOperations = PrivateLinks<PrivateLinkResource>;
2019

@@ -29,7 +28,7 @@ interface PrivateLinkResources {
2928
"privateLinkResourceName",
3029
"groupName"
3130
)
32-
get is PrivateLinkOperations.Read<PrivateLinkResource>;
31+
get is PrivateLinkOperations.Read<AzureMonitorPrivateLinkScope>;
3332

3433
/**
3534
* Gets the private link resources that need to be created for a Azure Monitor PrivateLinkScope.
@@ -41,7 +40,7 @@ interface PrivateLinkResources {
4140
"privateLinkResourceName",
4241
"groupName"
4342
)
44-
listByPrivateLinkScope is PrivateLinkOperations.ListSinglePageByParent<PrivateLinkResource>;
43+
listByPrivateLinkScope is PrivateLinkOperations.ListSinglePageByParent<AzureMonitorPrivateLinkScope>;
4544
}
4645

4746
@@doc(PrivateLinkResource.properties, "Resource properties.");

0 commit comments

Comments
 (0)