Merge branch 'main' into securitycontext-lease-only

Author: tejaswiMinnu

.github/shared/src/sdk-types.js

@@ -46,7 +46,8 @@ export const SpecGenSdkArtifactInfoSchema = z.object({
  *   breakingChange: string | undefined,
  *   breakingChangeApproved: string | undefined,
  *   breakingChangeSuppression: string | undefined,
- *   breakingChangeSuppressionApproved: string | undefined
+ *   breakingChangeSuppressionApproved: string | undefined,
+ *   buildFailed: string | undefined
  * }} SdkLabelInfo
  */
 
@@ -55,7 +56,7 @@ export const SpecGenSdkArtifactInfoSchema = z.object({
  */
 
 /**
- * SDK labels mapping for breaking change labels
+ * SDK labels mapping for breaking change and build-failure labels
  * @type {SdkLabels}
  * */
 export const sdkLabels = {
@@ -64,35 +65,41 @@ export const sdkLabels = {
     breakingChangeApproved: "BreakingChange-Go-Sdk-Approved",
     breakingChangeSuppression: "BreakingChange-Go-Sdk-Suppression",
     breakingChangeSuppressionApproved: "BreakingChange-Go-Sdk-Suppression-Approved",
+    buildFailed: undefined,
   },
   "azure-sdk-for-java": {
     breakingChange: undefined,
     breakingChangeApproved: undefined,
     breakingChangeSuppression: undefined,
     breakingChangeSuppressionApproved: undefined,
+    buildFailed: undefined,
   },
   "azure-sdk-for-js": {
     breakingChange: "BreakingChange-JavaScript-Sdk",
     breakingChangeApproved: "BreakingChange-JavaScript-Sdk-Approved",
     breakingChangeSuppression: "BreakingChange-JavaScript-Sdk-Suppression",
     breakingChangeSuppressionApproved: "BreakingChange-JavaScript-Sdk-Suppression-Approved",
+    buildFailed: undefined,
   },
   "azure-sdk-for-net": {
     breakingChange: undefined,
     breakingChangeApproved: undefined,
     breakingChangeSuppression: undefined,
     breakingChangeSuppressionApproved: undefined,
+    buildFailed: "auto-sdk-build-fix",
   },
   "azure-sdk-for-python": {
     breakingChange: "BreakingChange-Python-Sdk",
     breakingChangeApproved: "BreakingChange-Python-Sdk-Approved",
     breakingChangeSuppression: "BreakingChange-Python-Sdk-Suppression",
     breakingChangeSuppressionApproved: "BreakingChange-Python-Sdk-Suppression-Approved",
+    buildFailed: undefined,
   },
   "azure-sdk-for-rust": {
     breakingChange: undefined,
     breakingChangeApproved: undefined,
     breakingChangeSuppression: undefined,
     breakingChangeSuppressionApproved: undefined,
+    buildFailed: undefined,
   },
 };

eng/tools/spec-gen-sdk-runner/src/command-helpers.ts

@@ -1,5 +1,6 @@
 import {
   type APIViewRequestData,
+  sdkLabels,
   SdkName,
   SdkNameSchema,
   type SpecGenSdkArtifactInfo,
@@ -313,6 +314,53 @@ export function getBreakingChangeInfo(executionReport: ExecutionReport): boolean
   return false;
 }
 
+/**
+ * Determine whether the SDK generation succeeded but the package build failed.
+ *
+ * The `warning` execution result is the contract used by the .NET spec-gen-sdk
+ * script to signal "an SDK was generated but it did not build". That interpretation
+ * of `warning` is currently .NET-specific. It does not impact other languages because
+ * the build-failed label is only emitted for languages that configure a `buildFailed`
+ * label in the centralized `sdkLabels` map (today only .NET); see
+ * {@link setBuildFailedLabelVariable}. A language opts in by defining its own
+ * `buildFailed` label once its build-failed contract is established.
+ *
+ * @param executionReport - The spec-gen-sdk execution report.
+ * @returns true when the execution result is `warning`.
+ */
+export function getBuildFailedInfo(executionReport: ExecutionReport): boolean {
+  return executionReport.executionResult === "warning";
+}
+
+/**
+ * Emit the build-failed label pipeline variable for the SDK PR-creation flow.
+ *
+ * This is intended to be called only from the PR-creation flow (single-spec SDK release
+ * scenario) and never from plain spec-PR CI validation. The label is applied to the
+ * generated SDK pull request so that automated build-failure repair can be triggered.
+ * The label name is sourced from the centralized `sdkLabels` map; languages without a
+ * configured `buildFailed` label are skipped, which is what scopes this behavior to
+ * .NET today (see {@link getBuildFailedInfo} for the `warning` contract).
+ *
+ * @param commandInput - The command input (provides the SDK language).
+ * @param executionReport - The spec-gen-sdk execution report.
+ */
+export function setBuildFailedLabelVariable(
+  commandInput: SpecGenSdkCmdInput,
+  executionReport: ExecutionReport,
+): void {
+  if (!getBuildFailedInfo(executionReport)) {
+    return;
+  }
+  const buildFailedLabel = sdkLabels[commandInput.sdkLanguage]?.buildFailed;
+  if (buildFailedLabel) {
+    logMessage(
+      `Runner: SDK generation succeeded but the build failed; setting BuildFailedLabel variable to '${buildFailedLabel}'`,
+    );
+    setVsoVariable("BuildFailedLabel", buildFailedLabel);
+  }
+}
+
 /**
  * Generate the spec-gen-sdk artifacts.
  * @param commandInput - The command input.

eng/tools/spec-gen-sdk-runner/src/commands.ts

@@ -25,6 +25,7 @@ import {
   prepareSpecGenSdkCommand,
   resolvePackagePath,
   selectGenerationTool,
+  setBuildFailedLabelVariable,
   setPipelineVariables,
 } from "./command-helpers.ts";
 import { checkEmitterEnabled, type EmitterCheckResult } from "./emitter-check.ts";
@@ -253,6 +254,13 @@ export async function generateSdkForSingleSpec(): Promise<CommandResult> {
     installationInstructions,
   );
 
+  // Flag the generated SDK pull request for automated build-failure repair when the
+  // build failed (generation succeeded with a warning). This only runs in the PR-creation
+  // flow, never in plain spec-PR CI validation.
+  if (executionReport) {
+    setBuildFailedLabelVariable(commandInput, executionReport);
+  }
+
   logMessage("ending group logging", LogLevel.EndGroup);
   if (executionReport?.vsoLogPath) {
     logIssuesToPipeline(executionReport.vsoLogPath, specConfigPathText);

eng/tools/spec-gen-sdk-runner/test/command-helpers.test.ts

@@ -7,12 +7,14 @@ import {
   appendErrorsToVsoLog,
   generateArtifact,
   getBreakingChangeInfo,
+  getBuildFailedInfo,
   getRequiredSettingValue,
   getSpecPaths,
   logIssuesToPipeline,
   parseArguments,
   prepareSpecGenSdkCommand,
   selectGenerationTool,
+  setBuildFailedLabelVariable,
   setPipelineVariables,
 } from "../src/command-helpers.ts";
 import * as log from "../src/log.ts";
@@ -448,6 +450,84 @@ describe("commands.ts", () => {
     });
   });
 
+  describe("getBuildFailedInfo", () => {
+    test("should return true when the execution result is a warning", () => {
+      const mockExecutionReport: ExecutionReport = {
+        executionResult: "warning",
+        packages: [],
+      };
+
+      expect(getBuildFailedInfo(mockExecutionReport)).toBe(true);
+    });
+
+    test("should return false when the execution result is not a warning", () => {
+      for (const executionResult of ["succeeded", "failed", "notEnabled"] as const) {
+        const mockExecutionReport: ExecutionReport = {
+          executionResult,
+          packages: [],
+        };
+
+        expect(getBuildFailedInfo(mockExecutionReport)).toBe(false);
+      }
+    });
+  });
+
+  describe("setBuildFailedLabelVariable", () => {
+    const mockCommandInput = (sdkLanguage: SdkName) => ({
+      workingFolder: "/working/folder",
+      sdkLanguage,
+      runMode: "",
+      localSpecRepoPath: "",
+      localSdkRepoPath: "",
+      sdkRepoName: "",
+      specCommitSha: "abc123",
+      specRepoHttpsUrl: "",
+    });
+
+    beforeEach(() => {
+      vi.clearAllMocks();
+    });
+
+    test("should set the BuildFailedLabel variable for .NET when the build failed", () => {
+      vi.spyOn(log, "setVsoVariable").mockImplementation(() => {
+        // mock implementation intentionally left blank
+      });
+
+      setBuildFailedLabelVariable(mockCommandInput(SdkName.Net), {
+        executionResult: "warning",
+        packages: [],
+      });
+
+      expect(log.setVsoVariable).toHaveBeenCalledWith("BuildFailedLabel", "auto-sdk-build-fix");
+    });
+
+    test("should not set the variable when the build did not fail", () => {
+      vi.spyOn(log, "setVsoVariable").mockImplementation(() => {
+        // mock implementation intentionally left blank
+      });
+
+      setBuildFailedLabelVariable(mockCommandInput(SdkName.Net), {
+        executionResult: "succeeded",
+        packages: [],
+      });
+
+      expect(log.setVsoVariable).not.toHaveBeenCalled();
+    });
+
+    test("should not set the variable for languages without a configured build-failed label", () => {
+      vi.spyOn(log, "setVsoVariable").mockImplementation(() => {
+        // mock implementation intentionally left blank
+      });
+
+      setBuildFailedLabelVariable(mockCommandInput(SdkName.Python), {
+        executionResult: "warning",
+        packages: [],
+      });
+
+      expect(log.setVsoVariable).not.toHaveBeenCalled();
+    });
+  });
+
   describe("generateArtifact", () => {
     beforeEach(() => {
       vi.clearAllMocks();