Search Service Quota Exceptions Don't Include an Error Code

[alzimmermsft]

(Please move this issue to the appropriate location if this isn't it)

While working with Azure Cognitive Search I had a bug in test code where I wasn't properly deleting service resources, and Search has hard cap limits for service resources based on the service SKU. The error response, 429, is one which is automatically retried in the Azure SDKs, but given that this requires service resource deletion it shouldn't be eagerly retried given this isn't an appropriate back-off scenario given the requirements to make the request resolve. There is a code field in the error response model used by Search but it isn't populated, it would be useful for this code to be populated so that systems which automatically retry 429 could inspect it to determine whether a retry would actually result in a successful response.

This is the raw error response received from the service:

{
  "error": {
    "code":"",
    "message":"Skillset quota of 3 has been exceeded for this service. You currently have 3 skillsets. You must either delete unused skillsets first, or upgrade the service for higher limits."
  }
}

There are other service resource which have a hard cap that haven't been validated for whether or not a code is returned, these should also be checked and follow-up on.

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @brjohnstmsft, @bleroy, @tjacobhi, @MarkHeff, @miwelsh.

Issue Details

---

(Please move this issue to the appropriate location if this isn't it)

While working with Azure Cognitive Search I had a bug in test code where I wasn't properly deleting service resources, and Search has hard cap limits for service resources based on the service SKU. The error response, 429, is one which is automatically retried in the Azure SDKs, but given that this requires service resource deletion it shouldn't be eagerly retried given this isn't an appropriate back-off scenario given the requirements to make the request resolve. There is a code field in the error response model used by Search but it isn't populated, it would be useful for this code to be populated so that systems which automatically retry 429 could inspect it to determine whether a retry would actually result in a successful response.

This is the raw error response received from the service:

{
  "error": {
    "code":"",
    "message":"Skillset quota of 3 has been exceeded for this service. You currently have 3 skillsets. You must either delete unused skillsets first, or upgrade the service for higher limits."
  }
}

There are other service resource which have a hard cap that haven't been validated for whether or not a code is returned, these should also be checked and follow-up on.

Author:	alzimmermsft
Assignees:	-
Labels:	Search, Service Attention
Milestone:	-

[brjohnstmsft]

Attn: @jennifermarsman