[Role] `RoleAssignmentProperties.principalType` should not have default value `User`

[jiasli]

During Azure CLI's migration to azure-mgmt-authorization Track 2 SDK (Azure/azure-cli#23372), this change is spotted.

In the previous API 2020-04-01-preview, RoleAssignmentProperties.principalType has no default value:

azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json

Lines 508 to 527 in b02ad20

	"principalType": {
	"type": "string",
	"description": "The principal type of the assigned principal ID.",
	"enum": [
	"User",
	"Group",
	"ServicePrincipal",
	"Unknown",
	"DirectoryRoleTemplate",
	"ForeignGroup",
	"Application",
	"MSI",
	"DirectoryObjectOrGroup",
	"Everyone"
	],
	"x-ms-enum": {
	"name": "PrincipalType",
	"modelAsString": true
	}
	},

In the latest API 2022-04-01, it has a default value of User:

azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json

Lines 574 to 593 in 495363b

	"principalType": {
	"type": "string",
	"description": "The principal type of the assigned principal ID.",
	"enum": [
	"User",
	"Group",
	"ServicePrincipal",
	"ForeignGroup",
	"Device"
	],
	"default": "User",
	"x-ms-enum": {
	"name": "PrincipalType",
	"modelAsString": true
	}
	},
	"description": {
	"type": "string",
	"description": "Description of role assignment"
	},

This breaks Azure CLI as we assume principalType is by default None:

https://github.com/Azure/azure-cli/blob/7232ac23b23c8b5b26a6cfd514600207bb79ebce/src/azure-cli/azure/cli/command_modules/role/_multi_api_adaptor.py#L50-L51

        if assignee_principal_type:
            parameters.principal_type = assignee_principal_type

There should be no assumption that principalType is a User.

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @darshanhs90, @AshishGargMicrosoft.

Issue Details

---

During Azure CLI's migration to azure-mgmt-authorization Track 2 SDK (Azure/azure-cli#23372), this change is spotted.

In the previous API 2020-04-01-preview, RoleAssignmentProperties.principalType has no default value:

azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json

Lines 508 to 527 in b02ad20

	"principalType": {
	"type": "string",
	"description": "The principal type of the assigned principal ID.",
	"enum": [
	"User",
	"Group",
	"ServicePrincipal",
	"Unknown",
	"DirectoryRoleTemplate",
	"ForeignGroup",
	"Application",
	"MSI",
	"DirectoryObjectOrGroup",
	"Everyone"
	],
	"x-ms-enum": {
	"name": "PrincipalType",
	"modelAsString": true
	}
	},

In the latest API 2022-04-01, it has a default value of User:

azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json

Lines 574 to 593 in 495363b

	"principalType": {
	"type": "string",
	"description": "The principal type of the assigned principal ID.",
	"enum": [
	"User",
	"Group",
	"ServicePrincipal",
	"ForeignGroup",
	"Device"
	],
	"default": "User",
	"x-ms-enum": {
	"name": "PrincipalType",
	"modelAsString": true
	}
	},
	"description": {
	"type": "string",
	"description": "Description of role assignment"
	},

This breaks Azure CLI as we assume principalType is by default None:

https://github.com/Azure/azure-cli/blob/7232ac23b23c8b5b26a6cfd514600207bb79ebce/src/azure-cli/azure/cli/command_modules/role/_multi_api_adaptor.py#L50-L51

        if assignee_principal_type:
            parameters.principal_type = assignee_principal_type

There should be no assumption that principalType is a User.

Author:	jiasli
Assignees:	-
Labels:	Authorization, Service Attention, needs-triage
Milestone:	-