Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppConfiguration add data plane API 2024-09-01 #29859

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

hahahahahaiyiwen
Copy link
Member

@hahahahahaiyiwen hahahahahaiyiwen commented Jul 16, 2024

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Getting help

  • First, please carefully read through this PR description, from top to bottom.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

fix #32511

@hahahahahaiyiwen hahahahahaiyiwen requested a review from a team as a code owner July 16, 2024 22:28
@hahahahahaiyiwen hahahahahaiyiwen requested review from DominikMe and marclerwick and removed request for a team July 16, 2024 22:28
Copy link

openapi-pipeline-app bot commented Jul 16, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jul 16, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from af81bdf7dca50754aa363e7130a26168853b0362. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[automation_init.sh] npm notice
    warn		Warning: azure-sdk-for-python cannot be found in specification/appconfiguration/data-plane/readme.md. This SDK will be skipped from SDK generation. Please add the right config to the readme file according to this guidance https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/code-gen/configure-go-sdk.md#swagger-to-sdk.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-appconfiguration [Preview SDK Changes]
    info	[Changelog] data-plan skip changelog generation temporarily
️⚠️ azure-sdk-for-net-track2 warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from af81bdf7dca50754aa363e7130a26168853b0362. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    warn		Warning: azure-sdk-for-net-track2 cannot be found in specification/appconfiguration/data-plane/readme.md. This SDK will be skipped from SDK generation. Please add the right config to the readme file according to this guidance https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/code-gen/configure-go-sdk.md#swagger-to-sdk.
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'PutKeyValueRequestContentType' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'CreateSnapshotRequestContentType' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'UpdateSnapshotRequestContentType' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'GetKeysResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'GetKeyValuesResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'GetKeyValueResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'PutKeyValueResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'DeleteKeyValueResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'GetSnapshotsResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'GetSnapshotResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'CreateSnapshotResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'UpdateSnapshotResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'GetLabelsResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'PutLockResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'DeleteLockResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'GetRevisionsResponseContentTypeHeader' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] System.InvalidOperationException: Unable to find a model or framework type that corresponds to Azure.Data.AppConfiguration.ConfigurationSnapshotStatus?
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Generation.Types.TypeFactory.CreateType(ITypeSymbol symbol) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\Generation\Types\TypeFactory.cs:line 140
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Output.Builders.BuilderHelpers.GetTypeFromExisting(ISymbol existingMember, CSharpType defaultType, TypeFactory typeFactory) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\Output\Builders\BuilderHelpers.cs:line 225
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Output.Models.Types.ModelTypeProviderFields.CreateFieldFromExisting(ISymbol existingMember, CSharpType originalType, ValueExpression initializationValue, SerializationFormat serializationFormat, TypeFactory typeFactory, Boolean isRequired, Boolean optionalViaNullability) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\Output\Models\Types\ModelTypeProviderFields.cs:line 293
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Output.Models.Types.ModelTypeProviderFields..ctor(IReadOnlyList`1 properties, String modelName, InputModelTypeUsage inputModelUsage, TypeFactory typeFactory, ModelTypeMapping modelTypeMapping, InputType additionalPropertiesValueType, Boolean isStruct, Boolean isPropertyBag) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\Output\Models\Types\ModelTypeProviderFields.cs:line 57
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Output.Models.Types.ModelTypeProvider.get_Fields() in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\Output\Models\Types\ModelTypeProvider.cs:line 52
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Output.Models.Types.ModelTypeProvider.EnsureAdditionalPropertiesProperty() in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\Output\Models\Types\ModelTypeProvider.cs:line 59
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Output.Models.Types.ModelTypeProvider.get_AdditionalPropertiesProperty() in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\Output\Models\Types\ModelTypeProvider.cs:line 56
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Output.Models.Types.ModelTypeProvider.get_RawDataField() in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\Output\Models\Types\ModelTypeProvider.cs:line 77
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Generation.Writers.ModelWriter.WritePrivateRawDataField(CodeWriter writer, ObjectType schema) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\Generation\Writers\ModelWriter.cs:line 102
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Generation.Writers.ModelWriter.WriteObjectSchema(CodeWriter writer, ObjectType schema) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\Generation\Writers\ModelWriter.cs:line 75
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Generation.Writers.ModelWriter.WriteModel(CodeWriter writer, TypeProvider model) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\Generation\Writers\ModelWriter.cs:line 26
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.AutoRest.Plugins.LowLevelTarget.ExecuteAsync(GeneratedCodeWorkspace project, InputNamespace inputNamespace, SourceInputModel sourceInputModel, Boolean isTspInput) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\LowLevel\AutoRest\LowLevelTarget.cs:line 27
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.AutoRest.Plugins.CSharpGen.ExecuteAsync(InputNamespace rootNamespace) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\AutoRest\Plugins\CSharpGen.cs:line 103
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.AutoRest.Communication.StandaloneGeneratorRunner.RunAsync(CommandLineOptions options) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Common\AutoRest\Communication\StandaloneGeneratorRunner.cs:line 62
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Program.Run(CommandLineOptions options) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Program.cs:line 47
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Program.<>c.<<Main>b__2_0>d.MoveNext() in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Program.cs:line 29
    cmderr	[Invoke-GenerateAndBuildV2.ps1] --- End of stack trace from previous location ---
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Program.Main(String[] args) in D:\a\_work\1\s\autorest.csharp\src\AutoRest.CSharp\Program.cs:line 26
    cmderr	[Invoke-GenerateAndBuildV2.ps1]    at AutoRest.CSharp.Program.<Main>(String[] args)
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Aborted (core dumped)
    cmderr	[Invoke-GenerateAndBuildV2.ps1] ExternalError: Emitter "@azure-tools/typespec-csharp" crashed! This is a bug.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Please file an issue at https://github.com/Azure/autorest.csharp/issues
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Error: Command failed: dotnet --roll-forward Major /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appconfiguration/Azure.Data.AppConfiguration/TempTypeSpecFiles/AppConfiguration/node_modules/@autorest/csharp/AutoRest.CSharp.dll --project-path /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appconfiguration/Azure.Data.AppConfiguration   --clear-output-folder true
    cmderr	[Invoke-GenerateAndBuildV2.ps1]     at checkExecSyncError (node:child_process:890:11)
    cmderr	[Invoke-GenerateAndBuildV2.ps1]     at execSync (node:child_process:962:15)
    cmderr	[Invoke-GenerateAndBuildV2.ps1]     at Object.$onEmit [as emitFunction] (file:///mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appconfiguration/Azure.Data.AppConfiguration/TempTypeSpecFiles/AppConfiguration/node_modules/@azure-tools/typespec-csharp/dist/src/emitter.js:65:13)
    cmderr	[Invoke-GenerateAndBuildV2.ps1]     at async runEmitter (file:///mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appconfiguration/Azure.Data.AppConfiguration/TempTypeSpecFiles/AppConfiguration/node_modules/@typespec/compiler/dist/src/core/program.js:452:13)
    cmderr	[Invoke-GenerateAndBuildV2.ps1]     at async compile (file:///mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appconfiguration/Azure.Data.AppConfiguration/TempTypeSpecFiles/AppConfiguration/node_modules/@typespec/compiler/dist/src/core/program.js:132:9)
    cmderr	[Invoke-GenerateAndBuildV2.ps1]     at async compileTsp (file:///home/cloudtest/.npm/_npx/6d3fef9cb048a1df/node_modules/@azure-tools/typespec-client-generator-cli/dist/typespec.js:78:21)
    cmderr	[Invoke-GenerateAndBuildV2.ps1]     at async generate (file:///home/cloudtest/.npm/_npx/6d3fef9cb048a1df/node_modules/@azure-tools/typespec-client-generator-cli/dist/index.js:196:5)
    cmderr	[Invoke-GenerateAndBuildV2.ps1]     at async main (file:///home/cloudtest/.npm/_npx/6d3fef9cb048a1df/node_modules/@azure-tools/typespec-client-generator-cli/dist/index.js:274:17)
    cmderr	[Invoke-GenerateAndBuildV2.ps1] --------------------------------------------------
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Library Version                0.2.0-beta.20240716.2
    cmderr	[Invoke-GenerateAndBuildV2.ps1] TypeSpec Compiler Version      0.57.0
    cmderr	[Invoke-GenerateAndBuildV2.ps1] --------------------------------------------------
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice To update run: npm install -g [email protected]
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Write-Error: Failed to generate typespec project. Exit code: 1
    error	GenerationError: The packageName is empty in the generation output, please confirm if the package has been generated from the SDK generation step.
️❌ azure-sdk-for-js failed [Detail]
    For more instructions, please refer to the FAQ .
  • Failed in generating from af81bdf7dca50754aa363e7130a26168853b0362. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    warn		Warning: azure-sdk-for-js cannot be found in specification/appconfiguration/data-plane/readme.md. This SDK will be skipped from SDK generation. Please add the right config to the readme file according to this guidance https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/code-gen/configure-go-sdk.md#swagger-to-sdk.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    cmderr	[automation_generate.sh] [ERROR] Error:
    cmderr	[automation_generate.sh] [ERROR] Error:
    cmderr	[automation_generate.sh] [ERROR] An error occurred while run build for typespec project: "specification/appconfiguration/AppConfiguration":
    cmderr	[automation_generate.sh] [ERROR] An error occurred while run build for typespec project: "specification/appconfiguration/AppConfiguration":
    cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: rush build -t @azure-rest/azure-appconfiguration-rest
    cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: rush build -t @azure-rest/azure-appconfiguration-rest
    cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
    cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
    cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
    cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
    cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: rush build -t @azure-rest/azure-appconfiguration-rest
    cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: rush build -t @azure-rest/azure-appconfiguration-rest
    cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:885:11)
    cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:885:11)
    cmderr	[automation_generate.sh] [ERROR]     at execSync (node:child_process:957:15)
    cmderr	[automation_generate.sh] [ERROR]     at execSync (node:child_process:957:15)
    cmderr	[automation_generate.sh] [ERROR]     at /home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/llc/generateRLCInPipeline/generateRLCInPipeline.js:209:42
    cmderr	[automation_generate.sh] [ERROR]     at /home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/llc/generateRLCInPipeline/generateRLCInPipeline.js:209:42
    cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
    cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
    cmderr	[automation_generate.sh] [ERROR]     at fulfilled (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:112:62)
    cmderr	[automation_generate.sh] [ERROR]     at fulfilled (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:112:62)
    cmderr	[automation_generate.sh] [ERROR]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
    cmderr	[automation_generate.sh] [ERROR]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
    info	[Changelog]
  • @azure-rest/azure-appconfiguration-rest [Preview SDK Changes]
    info	[Changelog]
️❌ azure-sdk-for-java failed [Detail]
    For more instructions, please refer to the FAQ .
  • Failed in generating from af81bdf7dca50754aa363e7130a26168853b0362. SDK Automation 14.0.0
    command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    warn		Warning: azure-sdk-for-java cannot be found in specification/appconfiguration/data-plane/readme.md. This SDK will be skipped from SDK generation. Please add the right config to the readme file according to this guidance https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/code-gen/configure-go-sdk.md#swagger-to-sdk.
    command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[Java-Sdk-Automation] [COMPILE] Maven build fail.
    cmderr	[Java-Sdk-Automation] [COMPILE] Maven build fail.
    cmderr	[Java-Sdk-Automation] [COMPILE] Maven build fail.
    cmderr	[Java-Sdk-Automation] [COMPILE] Maven build fail.
    info	[Changelog]
    command	./eng/automation/install_instruction.py ../azure-sdk-for-java_tmp/installInstructionInput.json ../azure-sdk-for-java_tmp/installInstructionOutput.json
  • azure-data-appconfiguration [Preview SDK Changes]
    info	[Changelog]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jul 16, 2024

@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Aug 7, 2024
@hahahahahaiyiwen hahahahahaiyiwen changed the title AppConfiguration add data plane API 2024-09-01-preview AppConfiguration add data plane API 2024-09-01 Jan 13, 2025
@hahahahahaiyiwen hahahahahaiyiwen removed the no-recent-activity There has been no recent activity on this issue. label Feb 7, 2025
@hahahahahaiyiwen hahahahahaiyiwen added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Feb 7, 2025
@hahahahahaiyiwen
Copy link
Member Author

@mikekistler could you help get us API stewardship board review of this new stable api version that only has one minor query parameter change.

@hahahahahaiyiwen hahahahahaiyiwen added the offline-review-requested Service team has requested PR review be conducted offline. label Feb 7, 2025
Copy link
Member

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@hahahahahaiyiwen
Copy link
Member Author

@mikekistler could we get the APIStewardshipBoard-SignedOff label? I have also followed the step and sent an email to request an offline api review.

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For the added tags query parameter in the 2 APIs, you may want to add this query parameter in some of your example JSON, so that user may know how to use them in your new api-version.

@mikekistler mikekistler added the APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. label Feb 21, 2025
Copy link
Contributor

Hi, @hahahahahaiyiwen. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane new-api-version no-recent-activity There has been no recent activity on this issue. offline-review-requested Service team has requested PR review be conducted offline. PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Azure App Configuration - Azure App Configuration] API Review
8 participants