Skip to content

Port OPS + Recording changes to GA5 #34514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Port OPS + Recording changes to GA5 #34514

wants to merge 34 commits into from

Conversation

antonsamson-msft
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@antonsamson-msft antonsamson-msft requested a review from a team as a code owner May 7, 2025 23:25
@antonsamson-msft antonsamson-msft requested review from allenjzhang and mario-guerra and removed request for a team May 7, 2025 23:25
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 7, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 7, 2025 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@antonsamson-msft antonsamson-msft requested review from fhaghbin-msft and v-dharmarajv and removed request for allenjzhang and mario-guerra May 7, 2025 23:25
@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label May 7, 2025
@azure-sdk azure-sdk mentioned this pull request May 12, 2025
Open
Base automatically changed from callautomation/ga5 to main May 12, 2025 20:11
@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@mikekistler mikekistler linked an issue May 12, 2025 that may be closed by this pull request
[ACS Call Automation ] REST API Review #34509
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger CallAutomation-CallAutomation

@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label May 12, 2025
@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented May 15, 2025 •
edited
Loading

Why this is a change on existing GAed api-version? <-- OK I get the context in Teams chat

weidongxu-microsoft
weidongxu-microsoft reviewed May 15, 2025
View reviewed changes
...ication/data-plane/CallAutomation/stable/2025-05-15/communicationservicescallautomation.json
},
"CommunicationIdentifierModel": {
"$ref": "../../../Common/stable/2023-11-15/common.json#/definitions/CommunicationIdentifierModel"
"$ref": "../../../Common/preview/2025-03-15-preview/common.json#/definitions/CommunicationIdentifierModel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a stable api-version refers to model from a preview?

@antonsamson-msft antonsamson-msft marked this pull request as draft May 15, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft left review comments

@fhaghbin-msft fhaghbin-msft Awaiting requested review from fhaghbin-msft

@v-dharmarajv v-dharmarajv Awaiting requested review from v-dharmarajv

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. data-plane
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ACS Call Automation ] REST API Review
4 participants
@antonsamson-msft @weidongxu-microsoft @AzureRestAPISpecReview @fhaghbin-msft