Skip to content

Conversation

@viveklingaiah
Copy link
Contributor

@viveklingaiah viveklingaiah commented Mar 18, 2025

Closed. Created a different PR from my fork #33511

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 18, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named Swagger Avocado has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 18, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/compute/armcompute Create ApiView timeout. Package is too large and we cannot create ApiView for it.
Java azure-resourcemanager-compute-generated https://apiview.dev/Assemblies/Review/eb099b2efb0f4373a854e09003a6b31d?revisionId=32eac08673c148a5bd3721aeb97479ba
JavaScript @azure/arm-compute https://apiview.dev/Assemblies/Review/a802869b6345406cbb6d1e487132d7dd?revisionId=0ffa2d27ec1540fdb8d3e60dba23462b

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Compute

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Mar 19, 2025
@rkmanda
Copy link
Member

rkmanda commented Mar 22, 2025

Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 22, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 22, 2025
@viveklingaiah viveklingaiah closed this by deleting the head repository Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Compute new-api-version resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants