Skip to content

Conversation

@viveklingaiah
Copy link
Contributor

@viveklingaiah viveklingaiah commented Mar 26, 2025

===

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 26, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 26, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@ramoka178
Copy link
Contributor

@viveklingaiah Please fix the Swagger Avocado and Swagger Lintdiff errors and place it back in queue for review.

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 26, 2025
@gary-x-li
Copy link
Contributor

Can you please address the two latest comments regarding headers for PUT?

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 22, 2025
@viveklingaiah
Copy link
Contributor Author

Can you please address the two latest comments regarding headers for PUT?

Yes, addressed.

@gary-x-li
Copy link
Contributor

The description of the Location header you added is "Geo-location (region) of the resource". This is not correct. Please make sure you go through the RPC for async operations below; and make sure your service behaves the same way as how this is defined in swagger.

https://github.com/cloud-and-ai-microsoft/resource-provider-contract/blob/master/v1.0/async-api-reference.md#creating-replacing-or-updating-resources-asynchronously

In particular, if you are following the async 200/201 PUT pattern, the Location header is not relevant (since it's for the 202 Accepted pattern). The Azure-AsyncOperation header is optional. You should make sure the swagger definition is consistent with what your service would respond.

@viveklingaiah
Copy link
Contributor Author

The description of the Location header you added is "Geo-location (region) of the resource". This is not correct. Please make sure you go through the RPC for async operations below; and make sure your service behaves the same way as how this is defined in swagger.

https://github.com/cloud-and-ai-microsoft/resource-provider-contract/blob/master/v1.0/async-api-reference.md#creating-replacing-or-updating-resources-asynchronously

In particular, if you are following the async 200/201 PUT pattern, the Location header is not relevant (since it's for the 202 Accepted pattern). The Azure-AsyncOperation header is optional. You should make sure the swagger definition is consistent with what your service would respond.

I think addressed this time. Please check

@grizzlytheodore grizzlytheodore added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Apr 24, 2025
@gary-x-li gary-x-li added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 24, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 24, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jun 2, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Jul 7, 2025
@grizzlytheodore
Copy link
Contributor

migrated to PR parallel for TypeSpec change
#35887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Compute resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.