From f727e48aa8c0a0f6151d7754a431353c90e5c2fa Mon Sep 17 00:00:00 2001 From: Vikeshi Tiwari Date: Fri, 22 May 2026 14:21:28 -0400 Subject: [PATCH 1/8] Add ARM modeling leases for 10 partner PRs Covers partner PRs: #28432, #28469, #28474, #28561, #28595, #28599, #28628, #28630, #28651, #28665 --- .../Microsoft.Authorization/PrivilegedAccess/lease.yaml | 5 +++++ .../liftrcommvault/Commvault.ContentStore/lease.yaml | 5 +++++ .../Microsoft.Migrate/PlatformLandingZones/lease.yaml | 5 +++++ .../oracle/Oracle.Database/OracleDatabase/lease.yaml | 5 +++++ .github/arm-leases/oracle/Oracle.Database/lease.yaml | 5 +++++ .../PaloAltoNetworks.Cloudngfw/cloudngfw/lease.yaml | 5 +++++ .../Microsoft.PartnerEnrollment/PartnerProgram/lease.yaml | 5 +++++ .../resources/Microsoft.Resources/deleteOptions/lease.yaml | 5 +++++ .../Microsoft.Resources/deletedResources/lease.yaml | 5 +++++ .../workloads/Microsoft.Workloads/Workloads/lease.yaml | 5 +++++ 10 files changed, 50 insertions(+) create mode 100644 .github/arm-leases/authorization/Microsoft.Authorization/PrivilegedAccess/lease.yaml create mode 100644 .github/arm-leases/liftrcommvault/Commvault.ContentStore/lease.yaml create mode 100644 .github/arm-leases/migrate/Microsoft.Migrate/PlatformLandingZones/lease.yaml create mode 100644 .github/arm-leases/oracle/Oracle.Database/OracleDatabase/lease.yaml create mode 100644 .github/arm-leases/oracle/Oracle.Database/lease.yaml create mode 100644 .github/arm-leases/paloaltonetworks/PaloAltoNetworks.Cloudngfw/cloudngfw/lease.yaml create mode 100644 .github/arm-leases/partnerprogram/Microsoft.PartnerEnrollment/PartnerProgram/lease.yaml create mode 100644 .github/arm-leases/resources/Microsoft.Resources/deleteOptions/lease.yaml create mode 100644 .github/arm-leases/resources/Microsoft.Resources/deletedResources/lease.yaml create mode 100644 .github/arm-leases/workloads/Microsoft.Workloads/Workloads/lease.yaml diff --git a/.github/arm-leases/authorization/Microsoft.Authorization/PrivilegedAccess/lease.yaml b/.github/arm-leases/authorization/Microsoft.Authorization/PrivilegedAccess/lease.yaml new file mode 100644 index 000000000000..894b0d696bcf --- /dev/null +++ b/.github/arm-leases/authorization/Microsoft.Authorization/PrivilegedAccess/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.Authorization + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/liftrcommvault/Commvault.ContentStore/lease.yaml b/.github/arm-leases/liftrcommvault/Commvault.ContentStore/lease.yaml new file mode 100644 index 000000000000..b06630108145 --- /dev/null +++ b/.github/arm-leases/liftrcommvault/Commvault.ContentStore/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Commvault.ContentStore + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/migrate/Microsoft.Migrate/PlatformLandingZones/lease.yaml b/.github/arm-leases/migrate/Microsoft.Migrate/PlatformLandingZones/lease.yaml new file mode 100644 index 000000000000..4197a55a1482 --- /dev/null +++ b/.github/arm-leases/migrate/Microsoft.Migrate/PlatformLandingZones/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.Migrate + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/oracle/Oracle.Database/OracleDatabase/lease.yaml b/.github/arm-leases/oracle/Oracle.Database/OracleDatabase/lease.yaml new file mode 100644 index 000000000000..cd01e60caab0 --- /dev/null +++ b/.github/arm-leases/oracle/Oracle.Database/OracleDatabase/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Oracle.Database + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/oracle/Oracle.Database/lease.yaml b/.github/arm-leases/oracle/Oracle.Database/lease.yaml new file mode 100644 index 000000000000..cd01e60caab0 --- /dev/null +++ b/.github/arm-leases/oracle/Oracle.Database/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Oracle.Database + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/paloaltonetworks/PaloAltoNetworks.Cloudngfw/cloudngfw/lease.yaml b/.github/arm-leases/paloaltonetworks/PaloAltoNetworks.Cloudngfw/cloudngfw/lease.yaml new file mode 100644 index 000000000000..1f15f8b98f75 --- /dev/null +++ b/.github/arm-leases/paloaltonetworks/PaloAltoNetworks.Cloudngfw/cloudngfw/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: PaloAltoNetworks.Cloudngfw + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/partnerprogram/Microsoft.PartnerEnrollment/PartnerProgram/lease.yaml b/.github/arm-leases/partnerprogram/Microsoft.PartnerEnrollment/PartnerProgram/lease.yaml new file mode 100644 index 000000000000..03c81422da1e --- /dev/null +++ b/.github/arm-leases/partnerprogram/Microsoft.PartnerEnrollment/PartnerProgram/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.PartnerEnrollment + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/resources/Microsoft.Resources/deleteOptions/lease.yaml b/.github/arm-leases/resources/Microsoft.Resources/deleteOptions/lease.yaml new file mode 100644 index 000000000000..76931c7e7113 --- /dev/null +++ b/.github/arm-leases/resources/Microsoft.Resources/deleteOptions/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.Resources + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/resources/Microsoft.Resources/deletedResources/lease.yaml b/.github/arm-leases/resources/Microsoft.Resources/deletedResources/lease.yaml new file mode 100644 index 000000000000..76931c7e7113 --- /dev/null +++ b/.github/arm-leases/resources/Microsoft.Resources/deletedResources/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.Resources + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/workloads/Microsoft.Workloads/Workloads/lease.yaml b/.github/arm-leases/workloads/Microsoft.Workloads/Workloads/lease.yaml new file mode 100644 index 000000000000..d06d74aa998e --- /dev/null +++ b/.github/arm-leases/workloads/Microsoft.Workloads/Workloads/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.Workloads + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" From 20ee4d306c4732828d0b27816411004baf1cadcf Mon Sep 17 00:00:00 2001 From: Vikeshi Tiwari Date: Tue, 26 May 2026 12:55:16 -0400 Subject: [PATCH 2/8] Add ARM modeling lease for Microsoft.Marketplace/Skus (PR #42753) --- .../marketplacecatalog/Microsoft.Marketplace/Skus/lease.yaml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .github/arm-leases/marketplacecatalog/Microsoft.Marketplace/Skus/lease.yaml diff --git a/.github/arm-leases/marketplacecatalog/Microsoft.Marketplace/Skus/lease.yaml b/.github/arm-leases/marketplacecatalog/Microsoft.Marketplace/Skus/lease.yaml new file mode 100644 index 000000000000..dd113437c85a --- /dev/null +++ b/.github/arm-leases/marketplacecatalog/Microsoft.Marketplace/Skus/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.Marketplace + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" From 30fd85b7931af6abcc5ab4054c79c20de4b65cba Mon Sep 17 00:00:00 2001 From: Vikeshi Tiwari Date: Tue, 26 May 2026 13:18:30 -0400 Subject: [PATCH 3/8] Add ARM modeling leases for 5 additional partner PRs Covers partner PRs: #28213, #28284, #28328, #28678, #28689 --- .../Microsoft.ApplicationMigration/Container/lease.yaml | 5 +++++ .../Microsoft.BillingTrust/BillingTrust/lease.yaml | 5 +++++ .../Microsoft.FoundryLocal/foundrylocal/lease.yaml | 5 +++++ .../PeripheralResourceAssessments/lease.yaml | 5 +++++ .github/arm-leases/pki/Microsoft.Pki/lease.yaml | 5 +++++ 5 files changed, 25 insertions(+) create mode 100644 .github/arm-leases/applicationmigration/Microsoft.ApplicationMigration/Container/lease.yaml create mode 100644 .github/arm-leases/billingtrust/Microsoft.BillingTrust/BillingTrust/lease.yaml create mode 100644 .github/arm-leases/foundrylocal/Microsoft.FoundryLocal/foundrylocal/lease.yaml create mode 100644 .github/arm-leases/migrate/Microsoft.Migrate/PeripheralResourceAssessments/lease.yaml create mode 100644 .github/arm-leases/pki/Microsoft.Pki/lease.yaml diff --git a/.github/arm-leases/applicationmigration/Microsoft.ApplicationMigration/Container/lease.yaml b/.github/arm-leases/applicationmigration/Microsoft.ApplicationMigration/Container/lease.yaml new file mode 100644 index 000000000000..cc525dfc1120 --- /dev/null +++ b/.github/arm-leases/applicationmigration/Microsoft.ApplicationMigration/Container/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.ApplicationMigration + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/billingtrust/Microsoft.BillingTrust/BillingTrust/lease.yaml b/.github/arm-leases/billingtrust/Microsoft.BillingTrust/BillingTrust/lease.yaml new file mode 100644 index 000000000000..9b5678955890 --- /dev/null +++ b/.github/arm-leases/billingtrust/Microsoft.BillingTrust/BillingTrust/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.BillingTrust + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/foundrylocal/Microsoft.FoundryLocal/foundrylocal/lease.yaml b/.github/arm-leases/foundrylocal/Microsoft.FoundryLocal/foundrylocal/lease.yaml new file mode 100644 index 000000000000..4fbe203cf54d --- /dev/null +++ b/.github/arm-leases/foundrylocal/Microsoft.FoundryLocal/foundrylocal/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.FoundryLocal + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/migrate/Microsoft.Migrate/PeripheralResourceAssessments/lease.yaml b/.github/arm-leases/migrate/Microsoft.Migrate/PeripheralResourceAssessments/lease.yaml new file mode 100644 index 000000000000..4197a55a1482 --- /dev/null +++ b/.github/arm-leases/migrate/Microsoft.Migrate/PeripheralResourceAssessments/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.Migrate + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/pki/Microsoft.Pki/lease.yaml b/.github/arm-leases/pki/Microsoft.Pki/lease.yaml new file mode 100644 index 000000000000..177181529a9a --- /dev/null +++ b/.github/arm-leases/pki/Microsoft.Pki/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.Pki + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" From 000d4395c932249eb3a65adc549f2b127c13720a Mon Sep 17 00:00:00 2001 From: Vikeshi Tiwari Date: Tue, 26 May 2026 13:40:05 -0400 Subject: [PATCH 4/8] Add ARM modeling leases for PRs #43196 and #43445 --- .../AgriculturePlatform/lease.yaml | 5 +++++ .../Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml | 5 +++++ 2 files changed, 10 insertions(+) create mode 100644 .github/arm-leases/agricultureplatform/Microsoft.AgriculturePlatform/AgriculturePlatform/lease.yaml create mode 100644 .github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml diff --git a/.github/arm-leases/agricultureplatform/Microsoft.AgriculturePlatform/AgriculturePlatform/lease.yaml b/.github/arm-leases/agricultureplatform/Microsoft.AgriculturePlatform/AgriculturePlatform/lease.yaml new file mode 100644 index 000000000000..818e9d234ca8 --- /dev/null +++ b/.github/arm-leases/agricultureplatform/Microsoft.AgriculturePlatform/AgriculturePlatform/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.AgriculturePlatform + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" diff --git a/.github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml b/.github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml new file mode 100644 index 000000000000..3afb4cfc77fc --- /dev/null +++ b/.github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml @@ -0,0 +1,5 @@ +lease: + resource-provider: Microsoft.DBforPostgreSQL + startdate: "2026-05-22" + duration: P180D + reviewer: "@vikeshi26" From ca79dac8de819c3c7282e92ca36ab44b44259fbc Mon Sep 17 00:00:00 2001 From: Vikeshi Tiwari Date: Tue, 26 May 2026 14:53:35 -0400 Subject: [PATCH 5/8] Fix prettier formatting in eval-typespec.yaml Quote style: prefer double quotes for strings without inner double quotes (Prettier default for YAML). --- .../skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml b/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml index ffca056092e4..6f0b5d162571 100644 --- a/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml +++ b/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml @@ -156,6 +156,6 @@ stimuli: - 'Flagged the vague "Matching AiGateway pattern" suppression reason on firewallRules -- suppressions must stand on their own with a real technical justification (TSP-4.1)' - 'Recommended using @identifiers(#["volumeId"]) on volumes or @key on volumeId in the StorageVolume model instead of suppressing the rule' - 'Did NOT flag the @identifiers(#["moveId"]) on pendingMoves -- this is the correct pattern (positive control)' - - 'Did NOT flag the @identifiers(#[]) on diagnosticSnapshots -- explicit empty identifier list is the correct pattern for arrays with no identity (positive control)' - - 'Did NOT flag customLabels -- the ClusterLabel item type uses @key on labelKey, which automatically derives x-ms-identifiers (positive control)' + - "Did NOT flag the @identifiers(#[]) on diagnosticSnapshots -- explicit empty identifier list is the correct pattern for arrays with no identity (positive control)" + - "Did NOT flag customLabels -- the ClusterLabel item type uses @key on labelKey, which automatically derives x-ms-identifiers (positive control)" - 'Never suggested @extension("x-ms-identifiers", ...) as a fix in any finding' From 69eb00e68155bddeff27467c774be2fa798c9099 Mon Sep 17 00:00:00 2001 From: Vikeshi Tiwari Date: Tue, 26 May 2026 18:17:54 -0400 Subject: [PATCH 6/8] Revert eval-typespec.yaml prettier formatting change This PR should only contain ARM lease files. --- .../skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml b/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml index 6f0b5d162571..ffca056092e4 100644 --- a/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml +++ b/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml @@ -156,6 +156,6 @@ stimuli: - 'Flagged the vague "Matching AiGateway pattern" suppression reason on firewallRules -- suppressions must stand on their own with a real technical justification (TSP-4.1)' - 'Recommended using @identifiers(#["volumeId"]) on volumes or @key on volumeId in the StorageVolume model instead of suppressing the rule' - 'Did NOT flag the @identifiers(#["moveId"]) on pendingMoves -- this is the correct pattern (positive control)' - - "Did NOT flag the @identifiers(#[]) on diagnosticSnapshots -- explicit empty identifier list is the correct pattern for arrays with no identity (positive control)" - - "Did NOT flag customLabels -- the ClusterLabel item type uses @key on labelKey, which automatically derives x-ms-identifiers (positive control)" + - 'Did NOT flag the @identifiers(#[]) on diagnosticSnapshots -- explicit empty identifier list is the correct pattern for arrays with no identity (positive control)' + - 'Did NOT flag customLabels -- the ClusterLabel item type uses @key on labelKey, which automatically derives x-ms-identifiers (positive control)' - 'Never suggested @extension("x-ms-identifiers", ...) as a fix in any finding' From 755b2242f41a84357de8ae2d18c7993d52b74efc Mon Sep 17 00:00:00 2001 From: Vikeshi Tiwari Date: Tue, 26 May 2026 18:18:27 -0400 Subject: [PATCH 7/8] Revert "Revert eval-typespec.yaml prettier formatting change" This reverts commit 69eb00e68155bddeff27467c774be2fa798c9099. --- .../skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml b/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml index ffca056092e4..6f0b5d162571 100644 --- a/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml +++ b/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml @@ -156,6 +156,6 @@ stimuli: - 'Flagged the vague "Matching AiGateway pattern" suppression reason on firewallRules -- suppressions must stand on their own with a real technical justification (TSP-4.1)' - 'Recommended using @identifiers(#["volumeId"]) on volumes or @key on volumeId in the StorageVolume model instead of suppressing the rule' - 'Did NOT flag the @identifiers(#["moveId"]) on pendingMoves -- this is the correct pattern (positive control)' - - 'Did NOT flag the @identifiers(#[]) on diagnosticSnapshots -- explicit empty identifier list is the correct pattern for arrays with no identity (positive control)' - - 'Did NOT flag customLabels -- the ClusterLabel item type uses @key on labelKey, which automatically derives x-ms-identifiers (positive control)' + - "Did NOT flag the @identifiers(#[]) on diagnosticSnapshots -- explicit empty identifier list is the correct pattern for arrays with no identity (positive control)" + - "Did NOT flag customLabels -- the ClusterLabel item type uses @key on labelKey, which automatically derives x-ms-identifiers (positive control)" - 'Never suggested @extension("x-ms-identifiers", ...) as a fix in any finding' From 16986a96f9127fdb9f737cca01d09a0abe494d00 Mon Sep 17 00:00:00 2001 From: Vikeshi Tiwari Date: Tue, 26 May 2026 18:19:01 -0400 Subject: [PATCH 8/8] Remove eval-typespec.yaml change; PR is lease-files only --- .../skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml b/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml index 6f0b5d162571..ffca056092e4 100644 --- a/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml +++ b/.github/skills/evals/arm-api-reviewer/evaluate/eval-typespec.yaml @@ -156,6 +156,6 @@ stimuli: - 'Flagged the vague "Matching AiGateway pattern" suppression reason on firewallRules -- suppressions must stand on their own with a real technical justification (TSP-4.1)' - 'Recommended using @identifiers(#["volumeId"]) on volumes or @key on volumeId in the StorageVolume model instead of suppressing the rule' - 'Did NOT flag the @identifiers(#["moveId"]) on pendingMoves -- this is the correct pattern (positive control)' - - "Did NOT flag the @identifiers(#[]) on diagnosticSnapshots -- explicit empty identifier list is the correct pattern for arrays with no identity (positive control)" - - "Did NOT flag customLabels -- the ClusterLabel item type uses @key on labelKey, which automatically derives x-ms-identifiers (positive control)" + - 'Did NOT flag the @identifiers(#[]) on diagnosticSnapshots -- explicit empty identifier list is the correct pattern for arrays with no identity (positive control)' + - 'Did NOT flag customLabels -- the ClusterLabel item type uses @key on labelKey, which automatically derives x-ms-identifiers (positive control)' - 'Never suggested @extension("x-ms-identifiers", ...) as a fix in any finding'