API Cleanup initial pass(merge sqush jugonzales/agents-optimization-v2preview)#43927
Conversation
…optimization-v2preview
YoYoJa
requested review from
AkhilaIlla,
MSEvanhi,
balapv,
dargilco,
glecaros,
johanste,
qubitron,
raosuhas,
tejaswiMinnu and
trrwilson
as code owners
Next Steps to MergeImportant checks have failed. As of today they are not blocking this PR, but in near future they may.Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
| data_generation_jobs_v1_preview: "DataGenerationJobs=V1Preview", | ||
| models_v1_preview: "Models=V1Preview", | ||
| agents_optimization_v1_preview: "AgentsOptimization=V1Preview", | ||
| agents_optimization_v2_preview: "AgentsOptimization=V2Preview", |
There was a problem hiding this comment.
asked in the other PR, is there a strong reason not to use the opt-in key we were using before?
There was a problem hiding this comment.
As V2 removed lots of useless properties from V1 to align with the job guidelines more correctly, but V1 is already released in previous sdk version per Justin, so bumped to V2 here to make it less confusion.
And service side is still supporting V1 as a backward now for smooth inergration from UI and kinds of tests platform while rollout the change.
There was a problem hiding this comment.
the whole point of the endpoints being in preview, is to signal users that breaking changes are to be expected, not sure the value we are adding by replacing the string for the opt-in key.
There was a problem hiding this comment.
We still need do backward from service side, since UI and kinds of our tests also need time to rollout to different region to switch from V1 to V2.
glecaros
merged commit daccc7f
into
Azure:feature/foundry-release
…2preview) (Azure#43927) * rebase to /feature/foundry-release and merge sqush jugonzales/agents-optimization-v2preview * resolve missing file * address comment for minValue of max_candidates * address comments of OptimizationInlineDatasetInput.type * address coment of OptimizationJobListItem
3 participants
…optimization-v2preview
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.