You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/workflows/mgmt-review.md
+8-6Lines changed: 8 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -47,13 +47,15 @@ Fetch the PR details. If the PR is in **draft** state, mark it as ready for revi
47
47
48
48
1. Fetch PR details and changed files using GitHub MCP tools.
49
49
2. Identify the module path from the changed files (e.g., `sdk/resourcemanager/<service>/arm<package>/`).
50
-
3. Determine if this is a **first on-board service** (first beta version): check whether the PR adds a new `ci.yml` file under the module path (i.e., `ci.yml` appears in the changed files with status `added`). If so, mark this PR as a first on-board service for Step 2.
50
+
3. Determine if this is a **first on-board service** (first beta version): check whether the PR adds a new `ci.yml` file under the module path (i.e., `ci.yml` appears in the changed files with status `added`). If so, record this for the Step 5 comment.
51
51
52
-
### Step 2 — Note first on-board service
52
+
### Step 2 — Wait for all pipeline checks to complete
53
53
54
-
> **This step only applies when Step 1 identified a first on-board service.** Skip this step entirely otherwise.
54
+
Before analyzing CI results, ensure all pipeline checks have finished running.
55
55
56
-
For a brand-new service, release pipelines do not exist yet. The service team must create them by commenting `/azp run prepare-pipelines` on the PR. Record that this is a first on-board service so that the Step 5 comment includes instructions for the service team. This does **not** block the remaining steps — proceed to Step 3 immediately.
56
+
1. Fetch **check runs** for the PR head commit. Find the `go - pullrequest` parent check and its child jobs (`go - pullrequest (Build <job_name>)`). These are **Azure DevOps pipeline** results — do NOT call `get_job_logs` (returns 404).
57
+
2. If the `go - pullrequest` parent check or any of its child jobs have a `status` of `queued` or `in_progress`, poll check runs periodically (e.g., every 60 seconds) until **all** pipeline checks reach a **completed** status. If checks have not completed within **30 minutes**, stop waiting and analyze whatever results are available — note incomplete checks in the Step 5 comment.
58
+
3. Once all checks are completed, read success/failure from the `conclusion` field and extract the `target_url` for ADO log links. NEVER fabricate ADO URLs.
57
59
58
60
### Step 3 — Check for manual edits to auto-generated files
59
61
@@ -69,7 +71,7 @@ Auto-generated Go files contain the comment `// Code generated by Microsoft (R)
69
71
70
72
If the PR is mergeable (`Squash and merge` enabled), skip to Step 5 and comment `## PR is ready to merge`.
71
73
72
-
Otherwise, fetch **check runs** for the PR head commit and classify every blocking check using the reference table below. These are **Azure DevOps pipeline** results — do NOT call `get_job_logs` (returns 404). Read success/failure from the `conclusion` field and extract the `target_url` for ADO log links. NEVER fabricate ADO URLs. Also inspect the PR's changed files directly when useful (e.g., reading code for compile errors) and note any `Merging is blocked` messages.
74
+
Otherwise, classify every blocking check using the reference table below. Also inspect the PR's changed files directly when useful (e.g., reading code for compile errors) and note any `Merging is blocked` messages.
73
75
74
76
#### CI Check → Failure → Fix Reference
75
77
@@ -114,7 +116,7 @@ Post **exactly one** PR comment via `add_comment`. Include the marker `<!-- gh-a
114
116
## PR is ready to merge
115
117
```
116
118
117
-
**If this is a first on-board service** (detected in Step 2), include this block in the comment:
119
+
**If this is a first on-board service** (detected in Step 1), include this block in the comment:
118
120
119
121
```markdown
120
122
## ⚠️ First On-Board Service — Pipeline Setup Required
0 commit comments