Skip to content

Commit 2af2388

Browse files
Copilottadelesh
andauthored
Revert last change; remove Step 2 (Note first on-board) instead of polling step
Agent-Logs-Url: https://github.com/Azure/azure-sdk-for-go/sessions/7fe3e166-c9ef-48ba-8748-bac9b3044f62 Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
1 parent b5bb730 commit 2af2388

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

.github/workflows/mgmt-review.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,15 @@ Fetch the PR details. If the PR is in **draft** state, mark it as ready for revi
4747

4848
1. Fetch PR details and changed files using GitHub MCP tools.
4949
2. Identify the module path from the changed files (e.g., `sdk/resourcemanager/<service>/arm<package>/`).
50-
3. Determine if this is a **first on-board service** (first beta version): check whether the PR adds a new `ci.yml` file under the module path (i.e., `ci.yml` appears in the changed files with status `added`). If so, mark this PR as a first on-board service for Step 2.
50+
3. Determine if this is a **first on-board service** (first beta version): check whether the PR adds a new `ci.yml` file under the module path (i.e., `ci.yml` appears in the changed files with status `added`). If so, record this for the Step 5 comment.
5151

52-
### Step 2 — Note first on-board service
52+
### Step 2 — Wait for all pipeline checks to complete
5353

54-
> **This step only applies when Step 1 identified a first on-board service.** Skip this step entirely otherwise.
54+
Before analyzing CI results, ensure all pipeline checks have finished running.
5555

56-
For a brand-new service, release pipelines do not exist yet. The service team must create them by commenting `/azp run prepare-pipelines` on the PR. Record that this is a first on-board service so that the Step 5 comment includes instructions for the service team. This does **not** block the remaining steps — proceed to Step 3 immediately.
56+
1. Fetch **check runs** for the PR head commit. Find the `go - pullrequest` parent check and its child jobs (`go - pullrequest (Build <job_name>)`). These are **Azure DevOps pipeline** results — do NOT call `get_job_logs` (returns 404).
57+
2. If the `go - pullrequest` parent check or any of its child jobs have a `status` of `queued` or `in_progress`, poll check runs periodically (e.g., every 60 seconds) until **all** pipeline checks reach a **completed** status. If checks have not completed within **30 minutes**, stop waiting and analyze whatever results are available — note incomplete checks in the Step 5 comment.
58+
3. Once all checks are completed, read success/failure from the `conclusion` field and extract the `target_url` for ADO log links. NEVER fabricate ADO URLs.
5759

5860
### Step 3 — Check for manual edits to auto-generated files
5961

@@ -69,7 +71,7 @@ Auto-generated Go files contain the comment `// Code generated by Microsoft (R)
6971

7072
If the PR is mergeable (`Squash and merge` enabled), skip to Step 5 and comment `## PR is ready to merge`.
7173

72-
Otherwise, fetch **check runs** for the PR head commit and classify every blocking check using the reference table below. These are **Azure DevOps pipeline** results — do NOT call `get_job_logs` (returns 404). Read success/failure from the `conclusion` field and extract the `target_url` for ADO log links. NEVER fabricate ADO URLs. Also inspect the PR's changed files directly when useful (e.g., reading code for compile errors) and note any `Merging is blocked` messages.
74+
Otherwise, classify every blocking check using the reference table below. Also inspect the PR's changed files directly when useful (e.g., reading code for compile errors) and note any `Merging is blocked` messages.
7375

7476
#### CI Check → Failure → Fix Reference
7577

@@ -114,7 +116,7 @@ Post **exactly one** PR comment via `add_comment`. Include the marker `<!-- gh-a
114116
## PR is ready to merge
115117
```
116118

117-
**If this is a first on-board service** (detected in Step 2), include this block in the comment:
119+
**If this is a first on-board service** (detected in Step 1), include this block in the comment:
118120

119121
```markdown
120122
## ⚠️ First On-Board Service — Pipeline Setup Required

0 commit comments

Comments
 (0)