Skip to content

Commit aaede56

Browse files
adopt sub package
1 parent f92e0c2 commit aaede56

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

eng/tools/generator/cmd/v2/common/fileProcessor.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ func ChangeConfigWithLocalPath(path, readmeFile, readmeGoFile string) error {
189189
}
190190

191191
// replace repo URL and commit id in autorest.md file
192-
func ChangeConfigWithCommitID(path, repoURL, commitID, specRPName string) error {
192+
func ChangeConfigWithCommitID(path, repoURL, commitID, specRPName, specSubRPName string) error {
193193
log.Printf("Replacing repo URL and commit id in autorest.md ...")
194194
b, err := os.ReadFile(path)
195195
if err != nil {
@@ -203,7 +203,9 @@ func ChangeConfigWithCommitID(path, repoURL, commitID, specRPName string) error
203203
indexReadme := strings.Index(line, autorest_md_file_suffix)
204204
resourceManagerPath := []byte(line)
205205
resourceManagerPath = resourceManagerPath[indexResourceManager : indexReadme-1]
206-
206+
if specSubRPName != "" {
207+
resourceManagerPath = append(resourceManagerPath, []byte("/"+specSubRPName)...)
208+
}
207209
lines[i] = fmt.Sprintf("- %s/blob/%s/specification/%s/%s/readme.md", repoURL, commitID, specRPName, resourceManagerPath)
208210
lines[i+1] = fmt.Sprintf("- %s/blob/%s/specification/%s/%s/readme.go.md", repoURL, commitID, specRPName, resourceManagerPath)
209211
break

eng/tools/generator/cmd/v2/common/generation.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ type GenerateParam struct {
4949
SpecificVersion string
5050
SpecificPackageTitle string
5151
SpecRPName string
52+
SpecSubRPName string
5253
ReleaseDate string
5354
SkipGenerateExample bool
5455
GoVersion string
@@ -232,7 +233,7 @@ func (t *SwaggerCommonGenerator) PreGenerate(generateParam *GenerateParam) error
232233
} else {
233234
log.Printf("Change swagger config in `autorest.md` according to repo URL and commit ID...")
234235
autorestMdPath := filepath.Join(packagePath, "autorest.md")
235-
if err := ChangeConfigWithCommitID(autorestMdPath, t.SpecRepoURL, t.SpecCommitHash, generateParam.SpecRPName); err != nil {
236+
if err := ChangeConfigWithCommitID(autorestMdPath, t.SpecRepoURL, t.SpecCommitHash, generateParam.SpecRPName, generateParam.SpecSubRPName); err != nil {
236237
return err
237238
}
238239
}

eng/tools/generator/cmd/v2/release/releaseCmd.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ type Flags struct {
6868
PackageTitle string
6969
SDKRepo string
7070
SpecRPName string
71+
SpecSubRPName string
7172
ReleaseDate string
7273
SkipCreateBranch bool
7374
SkipGenerateExample bool
@@ -85,6 +86,7 @@ func BindFlags(flagSet *pflag.FlagSet) {
8586
flagSet.String("sdk-repo", "https://github.com/Azure/azure-sdk-for-go", "Specifies the sdk repo URL for generation")
8687
flagSet.String("spec-repo", "https://github.com/Azure/azure-rest-api-specs", "Specifies the swagger repo URL for generation")
8788
flagSet.String("spec-rp-name", "", "Specifies the swagger spec RP name, default is RP name")
89+
flagSet.String("spec-sub-rp-name", "", "Specifies the swagger spec sub RP name")
8890
flagSet.String("release-date", "", "Specifies the release date in changelog")
8991
flagSet.Bool("skip-create-branch", false, "Skip create release branch after generation")
9092
flagSet.Bool("skip-generate-example", false, "Skip generate example for SDK in the same time")
@@ -103,6 +105,7 @@ func ParseFlags(flagSet *pflag.FlagSet) Flags {
103105
SDKRepo: flags.GetString(flagSet, "sdk-repo"),
104106
SwaggerRepo: flags.GetString(flagSet, "spec-repo"),
105107
SpecRPName: flags.GetString(flagSet, "spec-rp-name"),
108+
SpecSubRPName: flags.GetString(flagSet, "spec-sub-rp-name"),
106109
ReleaseDate: flags.GetString(flagSet, "release-date"),
107110
SkipCreateBranch: flags.GetBool(flagSet, "skip-create-branch"),
108111
SkipGenerateExample: flags.GetBool(flagSet, "skip-generate-example"),
@@ -195,6 +198,10 @@ func (c *commandContext) generate(sdkRepo repo.SDKRepository, specCommitHash str
195198
ReleaseDate: c.flags.ReleaseDate,
196199
SkipGenerateExample: c.flags.SkipGenerateExample,
197200
GoVersion: c.flags.GoVersion,
201+
ForceStableVersion: c.flags.ForceStableVersion,
202+
SpecSubRPName: c.flags.SpecSubRPName,
203+
})
204+
}
198205
})
199206
if len(errs) > 0 {
200207
// GenerateFromSwagger is a batch run function, one error means one package is failed.

0 commit comments

Comments
 (0)