use HttpResponseException

Author: samvaity

sdk/clientcore/annotation-processor-test/src/main/java/io/clientcore/annotation/processor/test/test/SimpleXmlSerializableServiceImpl.java renamed to sdk/clientcore/annotation-processor-test/src/main/java/io/clientcore/annotation/processor/test/SimpleXmlSerializableServiceImpl.java

@@ -21,6 +21,8 @@
 import java.lang.reflect.ParameterizedType;
 import java.lang.reflect.Type;
 import java.util.List;
+import io.clientcore.core.http.models.HttpResponseException;
+import java.nio.charset.StandardCharsets;
 
 /**
  * Initializes a new instance of the SimpleXmlSerializableServiceImpl type.
@@ -70,7 +72,12 @@ public void sendApplicationXml(SimpleXmlSerializable simpleXmlSerializable) {
         int responseCode = networkResponse.getStatusCode();
         boolean expectedResponse = responseCode == 200;
         if (!expectedResponse) {
-            throw new RuntimeException("Unexpected response code: " + responseCode);
+            if (networkResponse.getValue() == null || networkResponse.getValue().toBytes().length == 0) {
+                throw instantiateUnexpectedException(responseCode, networkResponse, null, null);
+            } else {
+                ParameterizedType returnType = null;
+                throw instantiateUnexpectedException(responseCode, networkResponse, networkResponse.getValue(), decodeNetworkResponse(networkResponse.getValue(), jsonSerializer, returnType));
+            }
         }
         networkResponse.close();
     }
@@ -95,7 +102,12 @@ public void sendTextXml(SimpleXmlSerializable simpleXmlSerializable) {
         int responseCode = networkResponse.getStatusCode();
         boolean expectedResponse = responseCode == 200;
         if (!expectedResponse) {
-            throw new RuntimeException("Unexpected response code: " + responseCode);
+            if (networkResponse.getValue() == null || networkResponse.getValue().toBytes().length == 0) {
+                throw instantiateUnexpectedException(responseCode, networkResponse, null, null);
+            } else {
+                ParameterizedType returnType = null;
+                throw instantiateUnexpectedException(responseCode, networkResponse, networkResponse.getValue(), decodeNetworkResponse(networkResponse.getValue(), jsonSerializer, returnType));
+            }
         }
         networkResponse.close();
     }
@@ -112,7 +124,12 @@ public SimpleXmlSerializable getXml(String contentType) {
         int responseCode = networkResponse.getStatusCode();
         boolean expectedResponse = responseCode == 200;
         if (!expectedResponse) {
-            throw new RuntimeException("Unexpected response code: " + responseCode);
+            if (networkResponse.getValue() == null || networkResponse.getValue().toBytes().length == 0) {
+                throw instantiateUnexpectedException(responseCode, networkResponse, null, null);
+            } else {
+                ParameterizedType returnType = CoreUtils.createParameterizedType(io.clientcore.annotation.processor.test.implementation.models.SimpleXmlSerializable.class);
+                throw instantiateUnexpectedException(responseCode, networkResponse, networkResponse.getValue(), decodeNetworkResponse(networkResponse.getValue(), jsonSerializer, returnType));
+            }
         }
         Object result = null;
         ParameterizedType returnType = CoreUtils.createParameterizedType(io.clientcore.annotation.processor.test.implementation.models.SimpleXmlSerializable.class);
@@ -130,16 +147,22 @@ public SimpleXmlSerializable getXml(String contentType) {
 
     @SuppressWarnings({ "unchecked", "cast" })
     @Override
-    public SimpleXmlSerializable getInvalidXml() {
+    public SimpleXmlSerializable getInvalidXml(String contentType) {
         String url = "http://localhost/getInvalidXml";
         // Create the HTTP request
         HttpRequest httpRequest = new HttpRequest().setMethod(HttpMethod.GET).setUri(url);
+        httpRequest.getHeaders().add(HttpHeaderName.CONTENT_TYPE, contentType);
         // Send the request through the httpPipeline
         Response<BinaryData> networkResponse = this.httpPipeline.send(httpRequest);
         int responseCode = networkResponse.getStatusCode();
         boolean expectedResponse = responseCode == 200;
         if (!expectedResponse) {
-            throw new RuntimeException("Unexpected response code: " + responseCode);
+            if (networkResponse.getValue() == null || networkResponse.getValue().toBytes().length == 0) {
+                throw instantiateUnexpectedException(responseCode, networkResponse, null, null);
+            } else {
+                ParameterizedType returnType = CoreUtils.createParameterizedType(io.clientcore.annotation.processor.test.implementation.models.SimpleXmlSerializable.class);
+                throw instantiateUnexpectedException(responseCode, networkResponse, networkResponse.getValue(), decodeNetworkResponse(networkResponse.getValue(), jsonSerializer, returnType));
+            }
         }
         Object result = null;
         ParameterizedType returnType = CoreUtils.createParameterizedType(io.clientcore.annotation.processor.test.implementation.models.SimpleXmlSerializable.class);
@@ -177,7 +200,25 @@ private static Object decodeNetworkResponse(BinaryData data, ObjectSerializer se
             }
             return serializer.deserializeFromBytes(data.toBytes(), token);
         } catch (IOException e) {
-            throw LOGGER.logThrowableAsError(CoreException.from(e));
+            LOGGER.atWarning().setThrowable(e).log(() -> "Failed to deserialize the error entity.");
+            return null;
+        }
+    }
+
+    private static HttpResponseException instantiateUnexpectedException(int responseCode, Response<BinaryData> response, BinaryData data, Object decodedValue) {
+        StringBuilder exceptionMessage = new StringBuilder("Status code ").append(responseCode).append(", ");
+        String contentType = response.getHeaders().getValue(HttpHeaderName.CONTENT_TYPE);
+        if ("application/octet-stream".equalsIgnoreCase(contentType)) {
+            String contentLength = response.getHeaders().getValue(HttpHeaderName.CONTENT_LENGTH);
+            exceptionMessage.append("(").append(contentLength).append("-byte body)");
+        } else if (data == null || data.toBytes().length == 0) {
+            exceptionMessage.append("(empty body)");
+        } else {
+            exceptionMessage.append('"').append(new String(data.toBytes(), StandardCharsets.UTF_8)).append('"');
+        }
+        if (decodedValue instanceof IOException || decodedValue instanceof IllegalStateException) {
+            return new HttpResponseException(exceptionMessage.toString(), response, (Throwable) decodedValue);
         }
+        return new HttpResponseException(exceptionMessage.toString(), response, decodedValue);
     }
 }

sdk/clientcore/annotation-processor-test/src/main/java/io/clientcore/annotation/processor/test/implementation/SimpleXmlSerializableService.java

@@ -70,5 +70,5 @@ static SimpleXmlSerializableService getNewInstance(HttpPipeline pipeline) {
      * @return The retrieved invalid XML payload.
      */
     @HttpRequestInformation(method = HttpMethod.GET, path = "getInvalidXml", expectedStatusCodes = { 200 })
-    SimpleXmlSerializable getInvalidXml();
+    SimpleXmlSerializable getInvalidXml(@HeaderParam("Content-Type") String contentType);
 }