Skip to content

Commit d32decb

Browse files
committed
adding missing tests from PR 44678
1 parent a5578ff commit d32decb

File tree

4 files changed

+114
-0
lines changed

4 files changed

+114
-0
lines changed

sdk/openai/azure-ai-openai/src/test/java/com/azure/ai/openai/NonAzureOpenAIAsyncClientTest.java

+29
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import com.azure.ai.openai.models.ChatCompletionsFunctionToolSelection;
1818
import com.azure.ai.openai.models.ChatCompletionsNamedFunctionToolSelection;
1919
import com.azure.ai.openai.models.ChatCompletionsOptions;
20+
import com.azure.ai.openai.models.ChatCompletionStreamOptions;
2021
import com.azure.ai.openai.models.ChatCompletionsToolCall;
2122
import com.azure.ai.openai.models.ChatCompletionsToolSelection;
2223
import com.azure.ai.openai.models.ChatCompletionsToolSelectionPreset;
@@ -2131,4 +2132,32 @@ public void testListBatchesFailure(HttpClient httpClient, OpenAIServiceVersion s
21312132
assertNotNull(httpResponseException.getMessage());
21322133
});
21332134
}
2135+
2136+
@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
2137+
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
2138+
public void testGetCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
2139+
client = getNonAzureOpenAIAsyncClient(httpClient);
2140+
2141+
getCompletionsRunnerForNonAzure((deploymentId, prompt) -> {
2142+
StepVerifier.create(client.getCompletionsStream(deploymentId, new CompletionsOptions(prompt),
2143+
new ChatCompletionStreamOptions())).recordWith(ArrayList::new).thenConsumeWhile(completion -> {
2144+
assertNotNull(completion);
2145+
return true;
2146+
}).consumeRecordedWith(messageList -> assertFalse(messageList.isEmpty())).verifyComplete();
2147+
});
2148+
}
2149+
2150+
@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
2151+
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
2152+
public void testGetChatCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
2153+
client = getNonAzureOpenAIAsyncClient(httpClient);
2154+
2155+
getChatCompletionsRunnerForNonAzure((deploymentId, prompt) -> {
2156+
StepVerifier.create(client.getChatCompletionsStream(deploymentId, new ChatCompletionsOptions(prompt),
2157+
new ChatCompletionStreamOptions())).recordWith(ArrayList::new).thenConsumeWhile(chatCompletion -> {
2158+
assertNotNull(chatCompletion);
2159+
return true;
2160+
}).consumeRecordedWith(messageList -> assertFalse(messageList.isEmpty())).verifyComplete();
2161+
});
2162+
}
21342163
}

sdk/openai/azure-ai-openai/src/test/java/com/azure/ai/openai/NonAzureOpenAISyncClientTest.java

+28
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import com.azure.ai.openai.models.ChatCompletionsFunctionToolSelection;
2020
import com.azure.ai.openai.models.ChatCompletionsNamedFunctionToolSelection;
2121
import com.azure.ai.openai.models.ChatCompletionsOptions;
22+
import com.azure.ai.openai.models.ChatCompletionStreamOptions;
2223
import com.azure.ai.openai.models.ChatCompletionsToolCall;
2324
import com.azure.ai.openai.models.ChatCompletionsToolSelection;
2425
import com.azure.ai.openai.models.ChatCompletionsToolSelectionPreset;
@@ -52,6 +53,7 @@
5253
import com.azure.core.util.BinaryData;
5354
import com.azure.core.util.CoreUtils;
5455
import com.azure.core.util.IterableStream;
56+
import org.junit.jupiter.api.Assertions;
5557
import org.junit.jupiter.params.ParameterizedTest;
5658
import org.junit.jupiter.params.provider.MethodSource;
5759

@@ -1796,4 +1798,30 @@ public void testListBatchesFailure(HttpClient httpClient, OpenAIServiceVersion s
17961798
assertEquals(400, exception.getResponse().getStatusCode());
17971799
assertNotNull(exception.getMessage());
17981800
}
1801+
1802+
@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
1803+
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
1804+
public void testGetCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
1805+
client = getNonAzureOpenAISyncClient(httpClient);
1806+
1807+
getCompletionsRunnerForNonAzure((deploymentId, prompt) -> {
1808+
IterableStream<Completions> completionsList = client.getCompletionsStream(deploymentId,
1809+
new CompletionsOptions(prompt), new ChatCompletionStreamOptions());
1810+
1811+
completionsList.forEach(Assertions::assertNotNull);
1812+
});
1813+
}
1814+
1815+
@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
1816+
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
1817+
public void testGetChatCompletionsEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
1818+
client = getNonAzureOpenAISyncClient(httpClient);
1819+
1820+
getChatCompletionsRunnerForNonAzure((deploymentId, prompt) -> {
1821+
IterableStream<ChatCompletions> chatCompletionsList = client.getChatCompletionsStream(deploymentId,
1822+
new ChatCompletionsOptions(prompt), new ChatCompletionStreamOptions());
1823+
1824+
chatCompletionsList.forEach(Assertions::assertNotNull);
1825+
});
1826+
}
17991827
}

sdk/openai/azure-ai-openai/src/test/java/com/azure/ai/openai/OpenAIAsyncClientTest.java

+29
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import com.azure.ai.openai.models.Completions;
3131
import com.azure.ai.openai.models.CompletionsFinishReason;
3232
import com.azure.ai.openai.models.CompletionsOptions;
33+
import com.azure.ai.openai.models.ChatCompletionStreamOptions;
3334
import com.azure.ai.openai.models.CompletionsUsage;
3435
import com.azure.ai.openai.models.Embeddings;
3536
import com.azure.ai.openai.models.FileDeletionStatus;
@@ -2323,4 +2324,32 @@ public void testListBatchesFailure(HttpClient httpClient, OpenAIServiceVersion s
23232324
assertNotNull(httpResponseException.getMessage());
23242325
});
23252326
}
2327+
2328+
@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
2329+
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
2330+
public void testGetCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
2331+
client = getOpenAIAsyncClient(httpClient, serviceVersion);
2332+
2333+
getCompletionsRunner((deploymentId, prompt) -> {
2334+
StepVerifier.create(client.getCompletionsStream(deploymentId, new CompletionsOptions(prompt),
2335+
new ChatCompletionStreamOptions())).recordWith(ArrayList::new).thenConsumeWhile(completion -> {
2336+
assertNotNull(completion);
2337+
return true;
2338+
}).consumeRecordedWith(messageList -> assertFalse(messageList.isEmpty())).verifyComplete();
2339+
});
2340+
}
2341+
2342+
@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
2343+
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
2344+
public void testGetChatCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
2345+
client = getOpenAIAsyncClient(httpClient, serviceVersion);
2346+
2347+
getChatCompletionsRunner((deploymentId, prompt) -> {
2348+
StepVerifier.create(client.getChatCompletionsStream(deploymentId, new ChatCompletionsOptions(prompt),
2349+
new ChatCompletionStreamOptions())).recordWith(ArrayList::new).thenConsumeWhile(chatCompletion -> {
2350+
assertNotNull(chatCompletion);
2351+
return true;
2352+
}).consumeRecordedWith(messageList -> assertFalse(messageList.isEmpty())).verifyComplete();
2353+
});
2354+
}
23262355
}

sdk/openai/azure-ai-openai/src/test/java/com/azure/ai/openai/OpenAISyncClientTest.java

+28
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.azure.ai.openai.models.ChatCompletionsFunctionToolSelection;
2222
import com.azure.ai.openai.models.ChatCompletionsNamedFunctionToolSelection;
2323
import com.azure.ai.openai.models.ChatCompletionsOptions;
24+
import com.azure.ai.openai.models.ChatCompletionStreamOptions;
2425
import com.azure.ai.openai.models.ChatCompletionsToolCall;
2526
import com.azure.ai.openai.models.ChatCompletionsToolSelection;
2627
import com.azure.ai.openai.models.ChatCompletionsToolSelectionPreset;
@@ -56,6 +57,7 @@
5657
import com.azure.core.util.BinaryData;
5758
import com.azure.core.util.CoreUtils;
5859
import com.azure.core.util.IterableStream;
60+
import org.junit.jupiter.api.Assertions;
5961
import org.junit.jupiter.api.Disabled;
6062
import org.junit.jupiter.params.ParameterizedTest;
6163
import org.junit.jupiter.params.provider.MethodSource;
@@ -1981,4 +1983,30 @@ public void testListBatchesFailure(HttpClient httpClient, OpenAIServiceVersion s
19811983
assertEquals(400, exception.getResponse().getStatusCode());
19821984
assertNotNull(exception.getMessage());
19831985
}
1986+
1987+
@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
1988+
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
1989+
public void testGetCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
1990+
client = getOpenAIClient(httpClient, serviceVersion);
1991+
1992+
getCompletionsRunner((deploymentId, prompt) -> {
1993+
IterableStream<Completions> completionsList = client.getCompletionsStream(deploymentId,
1994+
new CompletionsOptions(prompt), new ChatCompletionStreamOptions());
1995+
1996+
completionsList.forEach(Assertions::assertNotNull);
1997+
});
1998+
}
1999+
2000+
@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
2001+
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
2002+
public void testGetChatCompletionsEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
2003+
client = getOpenAIClient(httpClient, serviceVersion);
2004+
2005+
getChatCompletionsRunner((deploymentId, prompt) -> {
2006+
IterableStream<ChatCompletions> chatCompletionsList = client.getChatCompletionsStream(deploymentId,
2007+
new ChatCompletionsOptions(prompt), new ChatCompletionStreamOptions());
2008+
2009+
chatCompletionsList.forEach(Assertions::assertNotNull);
2010+
});
2011+
}
19842012
}

0 commit comments

Comments
 (0)