Changing parameters names in CosmosPagedFlux back to original names (#45087)

* Initial draft

* Added unit test

* Update CosmosClientBuilderTest.java

* Update CosmosClientBuilderTest.java

* Adding simple extensibility for CosmosPagedFlux

* Refactoring the refactoring to avoid LINT errors

* Update sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncDatabase.java

Co-authored-by: Tomas Varon <[email protected]>

* Reacting to code review feedback

* Revert "Reacting to code review feedback"

This reverts commit d54c91b.

* Reapply "Reacting to code review feedback"

This reverts commit 4f280d0.

* Update CosmosAsyncClient.java

* Update CosmosPagedFlux.java

* Update CosmosPagedFlux.java

* Renaming CosmosPagedFlux.createFromList to CosmosPagedFlux.fromList

* Update CHANGELOG.md

---------

Co-authored-by: Tomas Varon <[email protected]>

Author: FabianMeiswinkel

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosClientBuilderTest.java

@@ -361,7 +361,7 @@ public <T> CosmosPagedFlux<T> queryItems(SqlQuerySpec querySpec, CosmosQueryRequ
             CacheKey key = new CacheKey(classType.getCanonicalName(), querySpec);
             List<?> cachedResult = this.queryCache.get(key);
             if (cachedResult != null) {
-                return CosmosPagedFlux.createFromList((List<T>)cachedResult, false);
+                return CosmosPagedFlux.fromList((List<T>)cachedResult, false);
             }
 
             return super

sdk/cosmos/azure-cosmos/CHANGELOG.md

@@ -3,6 +3,7 @@
 ### 4.69.0-beta.1 (Unreleased)
 
 #### Features Added
+* Added API to allow customers to wrap/extend `CosmosAsyncContainer` - [PR 43724](https://github.com/Azure/azure-sdk-for-java/pull/43724) and [PR 45087](https://github.com/Azure/azure-sdk-for-java/pull/45087) 
 
 #### Breaking Changes
 

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/util/CosmosPagedFlux.java

@@ -31,26 +31,64 @@ public class CosmosPagedFlux<T> extends ContinuablePagedFlux<String, T, FeedResp
     // Ensure there can only be package-internal implementations
     CosmosPagedFlux() {}
 
+    /**
+     * Gets a {@link Flux} of {@link FeedResponse} starting at the first page.
+     *
+     * @return A {@link Flux} of {@link FeedResponse}.
+     */
     @Override
     public Flux<FeedResponse<T>> byPage() {
         throw new UnsupportedOperationException("Has to be overridden in child classes.");
     }
 
+    /**
+     * Gets a {@link Flux} of {@link FeedResponse} beginning at the page identified by the given continuation token.
+     *
+     * @param continuationToken A continuation token identifying the page to select.
+     * @return A {@link Flux} of {@link FeedResponse}.
+     */
     @Override
-    public Flux<FeedResponse<T>> byPage(String s) {
+    public Flux<FeedResponse<T>> byPage(String continuationToken) {
         throw new UnsupportedOperationException("Has to be overridden in child classes.");
     }
 
+    /**
+     * Gets a {@link Flux} of {@link FeedResponse} starting at the first page requesting each page to contain a
+     * number of elements equal to the preferred page size.
+     * <p>
+     * The service may or may not honor the preferred page size therefore the client <em>MUST</em> be prepared to handle
+     * pages with different page sizes.
+     *
+     * @param preferredPageSize The preferred page size.
+     * @return A {@link Flux} of {@link FeedResponse}.
+     */
     @Override
-    public Flux<FeedResponse<T>> byPage(int i) {
+    public Flux<FeedResponse<T>> byPage(int preferredPageSize) {
         throw new UnsupportedOperationException("Has to be overridden in child classes.");
     }
 
+    /**
+     * Gets a {@link Flux} of {@link FeedResponse} beginning at the page identified by the given continuation token
+     * requesting each page to contain the number of elements equal to the preferred page size.
+     * <p>
+     * The service may or may not honor the preferred page size therefore the client <em>MUST</em> be prepared to handle
+     * pages with different page sizes.
+     *
+     * @param continuationToken A continuation token identifying the page to select.
+     * @param preferredPageSize The preferred page size.
+     * @return A {@link Flux} of {@link FeedResponse}.
+     */
     @Override
-    public Flux<FeedResponse<T>> byPage(String s, int i) {
+    public Flux<FeedResponse<T>> byPage(String continuationToken, int preferredPageSize) {
         throw new UnsupportedOperationException("Has to be overridden in child classes.");
     }
 
+    /**
+     * Handle for invoking "side-effects" on each FeedResponse returned by CosmosPagedFlux
+     *
+     * @param newFeedResponseConsumer handler
+     * @return CosmosPagedFlux instance with attached handler
+     */
     public CosmosPagedFlux<T> handle(Consumer<FeedResponse<T>> newFeedResponseConsumer) {
         throw new UnsupportedOperationException("Has to be overridden in child classes.");
     }
@@ -81,11 +119,11 @@ public void subscribe(CoreSubscriber<? super T> coreSubscriber) {
      * Creates an instance of a CosmosPagedFlux for mocking purposes or when injecting CosmosPagedFlux
      * instances from a different data source
      * @param items - the list of items to be returned
-     * @param isChangeFeed - a flag incidcating whether the CosmsoPagedFluy will be returned from a change feed API
+     * @param isChangeFeed - a flag indicating whether the CosmosPagedFlux will be returned from a change feed API
      * @return an instance of CosmosPagedFlux
      * @param <T> The type of the items
      */
-    public static <T> CosmosPagedFlux<T> createFromList(List<T> items, boolean isChangeFeed) {
+    public static <T> CosmosPagedFlux<T> fromList(List<T> items, boolean isChangeFeed) {
         return new CosmosPagedFluxStaticListImpl<>(
             items,
             isChangeFeed