Skip to content

Look at possibly changing a few things in ci.yml #43984

Open
@JimSuplizio

Description

@JimSuplizio

This issue is due to comments made by @weshaggard in this PR review.

  1. Look at using verify-readmes.yml in all cases.
  2. Look at using verify-links.yml in call cases
  3. Look at using verify-changelogs.yml in call cases.

There are a couple of issues with these

  1. In order to do these, we'd have to make the Analyze job depend on the Build job which is not something I'm wanting to do, I don't like the idea of losing the parallelization. For something like core, this isn't a big deal but for smaller pipelines, like template it'll overall increase the run time.
  2. Even if we did the first item, above, there would still need to be a check for the PR pipeline in the case of verify-samples.yml since I'd need to get the ServiceDirectory list from the diff.json

Metadata

Metadata

Assignees

Labels

EngSysThis issue is impacting the engineering system.

Type

No type

Projects

Status

🤔 Triage

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions