Skip to content

Merge annotation-processor-test into annotation-processor #44639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alzimmermsft
Copy link
Member

Description

Prototype merging annotation-processor-test into annotation-processor to contain both the processor and end-to-end testing code in the same package. This removes the need to indicate an annotation dependency anywhere and will ensure processing and testing are using the same processor version, limiting the possibility for breaking changes.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Mar 13, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

io.clientcore:annotation-processor

@JimSuplizio
Copy link
Contributor

@alzimmermsft @srnagar @samvaity
Why is annotation-processor, which has multiple libraries, in a subdirectory of sdk\clientcore instead of being in an sdk\annotation-processor subdirectory?

@samvaity
Copy link
Member

@alzimmermsft @srnagar @samvaity Why is annotation-processor, which has multiple libraries, in a subdirectory of sdk\clientcore instead of being in an sdk\annotation-processor subdirectory?

@JimSuplizio annotation-processor is a tooling package for clientcore and hence we wanted to retain it under clientcore grouping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants