Skip to content

AppConfig-v2: update exception logging #45295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025

Conversation

lmolkova
Copy link
Member

Follow up on #45136

@Copilot Copilot AI review requested due to automatic review settings May 12, 2025 19:30
@github-actions github-actions bot added the App Configuration Azure.ApplicationModel.Configuration label May 12, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates exception logging across the AppConfig v2 Java SDK by replacing the older LOGGER.logThrowableAsError(...) calls with the new LOGGER.throwableAtError().log(...) pattern.

  • Updated logging behavior in SecretReferenceConfigurationSetting, FeatureFlagConfigurationSetting, Utility, SyncTokenPolicy, SyncToken, and other client classes.
  • Adjusted exception handling in methods to improve consistency and clarity in error propagation.
  • Added a new dependency in the pom.xml to support core functionalities.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/models/SecretReferenceConfigurationSetting.java Updated exception logging in getValue() and checkValid() methods.
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/models/FeatureFlagConfigurationSetting.java Updated exception logging in getValue(), checkValid(), and tryParseValue() methods.
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/Utility.java Modified exception propagation in handleNotModifiedErrorToValidResponse.
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/SyncTokenPolicy.java Changed catch block to only catch RuntimeException and removed the logging call.
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/SyncToken.java Updated exception logging for invalid token formats and parse errors.
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/ConfigurationSettingDeserializationHelper.java Updated logging for deserialization errors.
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/ConfigurationClientCredentials.java Updated logging in setAuthorizationHeaders.
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/ConfigurationClientBuilder.java Updated exception logging for connection string and credential validation errors.
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/ConfigurationClient.java Updated exception handling in getConfigurationSettingWithResponse and listConfigurationSettings.
sdk/appconfiguration/azure-data-appconfiguration-v2/pom.xml Added a new dependency for core functionalities.

@lmolkova lmolkova merged commit a0c7823 into Azure:main May 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants