-
Notifications
You must be signed in to change notification settings - Fork 2.1k
AppConfig-v2: update exception logging #45295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates exception logging across the AppConfig v2 Java SDK by replacing the older LOGGER.logThrowableAsError(...) calls with the new LOGGER.throwableAtError().log(...) pattern.
- Updated logging behavior in SecretReferenceConfigurationSetting, FeatureFlagConfigurationSetting, Utility, SyncTokenPolicy, SyncToken, and other client classes.
- Adjusted exception handling in methods to improve consistency and clarity in error propagation.
- Added a new dependency in the pom.xml to support core functionalities.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/models/SecretReferenceConfigurationSetting.java | Updated exception logging in getValue() and checkValid() methods. |
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/models/FeatureFlagConfigurationSetting.java | Updated exception logging in getValue(), checkValid(), and tryParseValue() methods. |
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/Utility.java | Modified exception propagation in handleNotModifiedErrorToValidResponse. |
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/SyncTokenPolicy.java | Changed catch block to only catch RuntimeException and removed the logging call. |
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/SyncToken.java | Updated exception logging for invalid token formats and parse errors. |
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/ConfigurationSettingDeserializationHelper.java | Updated logging for deserialization errors. |
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/ConfigurationClientCredentials.java | Updated logging in setAuthorizationHeaders. |
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/ConfigurationClientBuilder.java | Updated exception logging for connection string and credential validation errors. |
sdk/appconfiguration/azure-data-appconfiguration-v2/src/main/java/com/azure/v2/data/appconfiguration/ConfigurationClient.java | Updated exception handling in getConfigurationSettingWithResponse and listConfigurationSettings. |
sdk/appconfiguration/azure-data-appconfiguration-v2/pom.xml | Added a new dependency for core functionalities. |
...tion-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/SyncTokenPolicy.java
Show resolved
Hide resolved
lmolkova
commented
May 12, 2025
...tion-v2/src/main/java/com/azure/v2/data/appconfiguration/implementation/SyncTokenPolicy.java
Show resolved
Hide resolved
lmolkova
commented
May 12, 2025
...src/main/java/com/azure/v2/data/appconfiguration/models/FeatureFlagConfigurationSetting.java
Show resolved
Hide resolved
lmolkova
commented
May 12, 2025
...main/java/com/azure/v2/data/appconfiguration/models/SecretReferenceConfigurationSetting.java
Show resolved
Hide resolved
alzimmermsft
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #45136