Fix ResponseHandler for return of generic BinaryData types #45299
+65
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samvaity
requested review from
vcolin7,
JonathanGiles,
srnagar and
alzimmermsft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the ResponseHandler to properly support generic BinaryData types, specifically responses encapsulated as a List.
- Added runtime checks for generic return types and delegated handling to a new helper method when a List is detected.
- Updated the test service interface and implementation to verify correct behavior for List responses.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/clientcore/annotation-processor/src/main/java/io/clientcore/annotation/processor/utils/ResponseHandler.java | Enhanced generic BinaryData detection and added handleDeclaredTypes for declared type responses |
| sdk/clientcore/annotation-processor-test/src/main/java/io/clientcore/annotation/processor/test/implementation/SpecialReturnBodiesService.java | Added a new endpoint for returning a Response<List> along with related annotations |
| sdk/clientcore/annotation-processor-test/src/main/java/io/clientcore/annotation/processor/test/SpecialReturnBodiesServiceImpl.java | Implemented deserialization and error handling for the List response case |
...st/src/main/java/io/clientcore/annotation/processor/test/SpecialReturnBodiesServiceImpl.java
Outdated
Show resolved
Hide resolved
...tation-processor/src/main/java/io/clientcore/annotation/processor/utils/ResponseHandler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the ResponseHandler for the return of generic BinaryData types. Earlier we were assuming the BinaryData return subtype did not include any generics, this fixes and currently adds support for List.class.