Skip to content

Commit 400144c

Browse files
authored
[monitor-opentelemetry] fix type checking build error (#34297)
The latest @types/node changes add `string[]` to the `RequestOptions.headers` type: DefinitelyTyped/DefinitelyTyped#72617 nodejs/node#58049 This PR adds a check and narrow the type to `http.OutgoingHttpHeaders` before accessing user-agent property. We don't ever set the user agent header using the `string[]` form so this should be fine.
1 parent 83b93ec commit 400144c

File tree

1 file changed

+6
-5
lines changed
  • sdk/monitor/monitor-opentelemetry/src/utils

1 file changed

+6
-5
lines changed

sdk/monitor/monitor-opentelemetry/src/utils/common.ts

+6-5
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,15 @@ import {
1212
import { diag } from "@opentelemetry/api";
1313

1414
export function ignoreOutgoingRequestHook(request: http.RequestOptions): boolean {
15-
if (request && request.headers) {
15+
if (request && request.headers && !Array.isArray(request.headers)) {
16+
const outgoingHeaders = request.headers as http.OutgoingHttpHeaders;
1617
if (
17-
(request.headers["User-Agent"] &&
18-
request.headers["User-Agent"]
18+
(outgoingHeaders["User-Agent"] &&
19+
outgoingHeaders["User-Agent"]
1920
.toString()
2021
.indexOf("azsdk-js-monitor-opentelemetry-exporter") > -1) ||
21-
(request.headers["user-agent"] &&
22-
request.headers["user-agent"]
22+
(outgoingHeaders["user-agent"] &&
23+
outgoingHeaders["user-agent"]
2324
.toString()
2425
.indexOf("azsdk-js-monitor-opentelemetry-exporter") > -1)
2526
) {

0 commit comments

Comments
 (0)