[notification-hubs] fix samples build

jeremymeng · jeremymeng · commit e8845fe778ee · 2026-06-02T11:42:28.000-07:00
update type-only imports and publish samples
diff --git a/sdk/notificationhubs/notification-hubs/samples-dev/exportRegistrationsJob.ts b/sdk/notificationhubs/notification-hubs/samples-dev/exportRegistrationsJob.ts
@@ -19,7 +19,7 @@ import {
   getNotificationHubJob,
   submitNotificationHubJob,
 } from "@azure/notification-hubs/api";
-import { NotificationHubJob } from "@azure/notification-hubs/models";
+import type { NotificationHubJob } from "@azure/notification-hubs/models";
 import { delay } from "@azure/core-util";
 
 // Define connection string and hub name
diff --git a/sdk/notificationhubs/notification-hubs/samples-dev/importRegistrationsJob.ts b/sdk/notificationhubs/notification-hubs/samples-dev/importRegistrationsJob.ts
@@ -19,7 +19,7 @@ import {
   getNotificationHubJob,
   submitNotificationHubJob,
 } from "@azure/notification-hubs/api";
-import { NotificationHubJob } from "@azure/notification-hubs/models";
+import type { NotificationHubJob } from "@azure/notification-hubs/models";
 import { delay } from "@azure/core-util";
 
 // Define connection string and hub name
diff --git a/sdk/notificationhubs/notification-hubs/samples-dev/listRegistrationsByChannel.ts b/sdk/notificationhubs/notification-hubs/samples-dev/listRegistrationsByChannel.ts
@@ -15,7 +15,7 @@
 
 import "dotenv/config";
 import { createClientContext, listRegistrationsByChannel } from "@azure/notification-hubs/api";
-import { AppleRegistrationChannel } from "@azure/notification-hubs/models";
+import type { AppleRegistrationChannel } from "@azure/notification-hubs/models";
 
 // Define connection string and hub name
 const connectionString = process.env.NOTIFICATIONHUBS_CONNECTION_STRING || "<connection string>";
diff --git a/sdk/notificationhubs/notification-hubs/samples-dev/sendBroadcastNotification.ts b/sdk/notificationhubs/notification-hubs/samples-dev/sendBroadcastNotification.ts
@@ -16,15 +16,15 @@
 
 import "dotenv/config";
 import {
-  NotificationHubsClientContext,
+  type NotificationHubsClientContext,
   createClientContext,
   getNotificationOutcomeDetails,
   sendBroadcastNotification,
 } from "@azure/notification-hubs/api";
 import {
   createAppleNotification,
-  NotificationDetails,
-  NotificationOutcomeState,
+  type NotificationDetails,
+  type NotificationOutcomeState,
 } from "@azure/notification-hubs/models";
 import { delay } from "@azure/core-util";
 
diff --git a/sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotification.fcmLegacy.ts b/sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotification.fcmLegacy.ts
@@ -16,12 +16,12 @@
 
 import "dotenv/config";
 import {
-  NotificationDetails,
-  NotificationOutcomeState,
+  type NotificationDetails,
+  type NotificationOutcomeState,
   createFcmLegacyNotification,
 } from "@azure/notification-hubs/models";
 import {
-  NotificationHubsClientContext,
+  type NotificationHubsClientContext,
   createClientContext,
   getNotificationOutcomeDetails,
   sendNotification,
diff --git a/sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotification.fcmV1.ts b/sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotification.fcmV1.ts
@@ -16,12 +16,12 @@
 
 import "dotenv/config";
 import {
-  NotificationDetails,
-  NotificationOutcomeState,
+  type NotificationDetails,
+  type NotificationOutcomeState,
   createFcmV1Notification,
 } from "@azure/notification-hubs/models";
 import {
-  NotificationHubsClientContext,
+  type NotificationHubsClientContext,
   createClientContext,
   getNotificationOutcomeDetails,
   sendNotification,
diff --git a/sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotification.ts b/sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotification.ts
@@ -16,12 +16,12 @@
 
 import "dotenv/config";
 import {
-  NotificationDetails,
-  NotificationOutcomeState,
+  type NotificationDetails,
+  type NotificationOutcomeState,
   createAppleNotification,
 } from "@azure/notification-hubs/models";
 import {
-  NotificationHubsClientContext,
+  type NotificationHubsClientContext,
   createClientContext,
   getNotificationOutcomeDetails,
   sendNotification,
diff --git a/sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotificationBatch.ts b/sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotificationBatch.ts
@@ -16,12 +16,12 @@
 
 import "dotenv/config";
 import {
-  NotificationDetails,
-  NotificationOutcomeState,
+  type NotificationDetails,
+  type NotificationOutcomeState,
   createAppleNotification,
 } from "@azure/notification-hubs/models";
 import {
-  NotificationHubsClientContext,
+  type NotificationHubsClientContext,
   createClientContext,
   getNotificationOutcomeDetails,
   sendNotification,
diff --git a/sdk/notificationhubs/notification-hubs/samples-dev/sendTagExpression.ts b/sdk/notificationhubs/notification-hubs/samples-dev/sendTagExpression.ts
@@ -16,12 +16,12 @@
 
 import "dotenv/config";
 import {
-  NotificationDetails,
-  NotificationOutcomeState,
+  type NotificationDetails,
+  type NotificationOutcomeState,
   createAppleNotification,
 } from "@azure/notification-hubs/models";
 import {
-  NotificationHubsClientContext,
+  type NotificationHubsClientContext,
   createClientContext,
   getNotificationOutcomeDetails,
   sendNotification,
diff --git a/sdk/notificationhubs/notification-hubs/samples-dev/sendTagsList.ts b/sdk/notificationhubs/notification-hubs/samples-dev/sendTagsList.ts
@@ -16,13 +16,13 @@
 
 import "dotenv/config";
 import {
-  NotificationDetails,
-  NotificationOutcomeState,
+  type NotificationDetails,
+  type NotificationOutcomeState,
   createAppleNotification,
   createTagExpression,
 } from "@azure/notification-hubs/models";
 import {
-  NotificationHubsClientContext,
+  type NotificationHubsClientContext,
   createClientContext,
   getNotificationOutcomeDetails,
   sendNotification,
diff --git a/sdk/notificationhubs/notification-hubs/samples-dev/updateInstallation.ts b/sdk/notificationhubs/notification-hubs/samples-dev/updateInstallation.ts
@@ -16,7 +16,7 @@
 
 import "dotenv/config";
 import { createClientContext, updateInstallation } from "@azure/notification-hubs/api";
-import { JsonPatch } from "@azure/notification-hubs/models";
+import type { JsonPatch } from "@azure/notification-hubs/models";
 
 // Define connection string and hub name
 const connectionString = process.env.NOTIFICATIONHUBS_CONNECTION_STRING || "<connection string>";
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/javascript/README.md b/sdk/notificationhubs/notification-hubs/samples/v2/javascript/README.md
@@ -59,10 +59,10 @@ npm install
 node createInstallation.fcmLegacy.js
 ```
 
-Alternatively, run a single sample with the correct environment variables set (setting up the `.env` file is not required if you do this), for example (cross-platform):
+Alternatively, run a single sample with the required environment variables set (setting up the `.env` file is not required if you do this), for example (cross-platform):
 
 ```bash
-cross-env NOTIFICATIONHUBS_CONNECTION_STRING="<notificationhubs connection string>" NOTIFICATION_HUB_NAME="<notification hub name>" FCM_REGISTRATION_ID="<fcm registration id>" node createInstallation.fcmLegacy.js
+npx cross-env NOTIFICATIONHUBS_CONNECTION_STRING="<notificationhubs connection string>" NOTIFICATION_HUB_NAME="<notification hub name>" FCM_REGISTRATION_ID="<fcm registration id>" node createInstallation.fcmLegacy.js
 ```
 
 ## Next Steps
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/javascript/createInstallation.fcmV1.js b/sdk/notificationhubs/notification-hubs/samples/v2/javascript/createInstallation.fcmV1.js
@@ -1,5 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
+
 /**
  * This sample demonstrates how the createOrUpdateInstallation() method can be used to create or overwrite an
  * installation in place.
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/javascript/exportRegistrationsJob.polling.js b/sdk/notificationhubs/notification-hubs/samples/v2/javascript/exportRegistrationsJob.polling.js
@@ -17,7 +17,6 @@ const {
   beginSubmitNotificationHubJob,
   createClientContext,
 } = require("@azure/notification-hubs/api");
-
 // Define connection string and hub name
 const connectionString = process.env.NOTIFICATIONHUBS_CONNECTION_STRING || "<connection string>";
 const hubName = process.env.NOTIFICATION_HUB_NAME || "<hub name>";
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/javascript/importRegistrationsJob.js b/sdk/notificationhubs/notification-hubs/samples/v2/javascript/importRegistrationsJob.js
@@ -1,5 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
+
 /**
  * This sample demonstrates how the createNotificationJob() method can be used to import registrations
  * descriptions from an existing set of exports.
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/javascript/importRegistrationsJob.poller.js b/sdk/notificationhubs/notification-hubs/samples/v2/javascript/importRegistrationsJob.poller.js
@@ -17,7 +17,6 @@ const {
   beginSubmitNotificationHubJob,
   createClientContext,
 } = require("@azure/notification-hubs/api");
-
 // Define connection string and hub name
 const connectionString = process.env.NOTIFICATIONHUBS_CONNECTION_STRING || "<connection string>";
 const hubName = process.env.NOTIFICATION_HUB_NAME || "<hub name>";
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/javascript/listRegistrationsByChannel.js b/sdk/notificationhubs/notification-hubs/samples/v2/javascript/listRegistrationsByChannel.js
@@ -14,7 +14,6 @@
 
 require("dotenv/config");
 const { createClientContext, listRegistrationsByChannel } = require("@azure/notification-hubs/api");
-
 // Define connection string and hub name
 const connectionString = process.env.NOTIFICATIONHUBS_CONNECTION_STRING || "<connection string>";
 const hubName = process.env.NOTIFICATION_HUB_NAME || "<hub name>";
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/javascript/package.json b/sdk/notificationhubs/notification-hubs/samples/v2/javascript/package.json
@@ -27,5 +27,8 @@
     "dotenv": "latest",
     "@azure/core-util": "^1.11.0",
     "@azure/core-rest-pipeline": "^1.19.0"
+  },
+  "devDependencies": {
+    "cross-env": "latest"
   }
 }
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/javascript/updateInstallation.js b/sdk/notificationhubs/notification-hubs/samples/v2/javascript/updateInstallation.js
@@ -15,7 +15,6 @@
 
 require("dotenv/config");
 const { createClientContext, updateInstallation } = require("@azure/notification-hubs/api");
-
 // Define connection string and hub name
 const connectionString = process.env.NOTIFICATIONHUBS_CONNECTION_STRING || "<connection string>";
 const hubName = process.env.NOTIFICATION_HUB_NAME || "<hub name>";
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/javascript/updateRegistration.js b/sdk/notificationhubs/notification-hubs/samples/v2/javascript/updateRegistration.js
@@ -36,7 +36,7 @@ async function main() {
     registration.tags = [];
   }
 
-  await registration.tags.push("likes_sports");
+  registration.tags.push("likes_sports");
 
   const registrationResponse = await updateRegistration(context, registration);
 
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/README.md b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/README.md
@@ -71,10 +71,10 @@ npm run build
 node dist/createInstallation.fcmLegacy.js
 ```
 
-Alternatively, run a single sample with the correct environment variables set (setting up the `.env` file is not required if you do this), for example (cross-platform):
+Alternatively, run a single sample with the required environment variables set (setting up the `.env` file is not required if you do this), for example (cross-platform):
 
 ```bash
-cross-env NOTIFICATIONHUBS_CONNECTION_STRING="<notificationhubs connection string>" NOTIFICATION_HUB_NAME="<notification hub name>" FCM_REGISTRATION_ID="<fcm registration id>" node dist/createInstallation.fcmLegacy.js
+npx cross-env NOTIFICATIONHUBS_CONNECTION_STRING="<notificationhubs connection string>" NOTIFICATION_HUB_NAME="<notification hub name>" FCM_REGISTRATION_ID="<fcm registration id>" node dist/createInstallation.fcmLegacy.js
 ```
 
 ## Next Steps
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/package.json b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/package.json
@@ -34,7 +34,8 @@
   },
   "devDependencies": {
     "@types/node": "^20.0.0",
-    "typescript": "~5.8.2",
-    "rimraf": "latest"
+    "cross-env": "latest",
+    "rimraf": "latest",
+    "typescript": "~6.0.2"
   }
 }
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/createInstallation.fcmV1.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/createInstallation.fcmV1.ts
@@ -1,5 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
+
 /**
  * This sample demonstrates how the createOrUpdateInstallation() method can be used to create or overwrite an
  * installation in place.
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/exportRegistrationsJob.polling.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/exportRegistrationsJob.polling.ts
@@ -14,7 +14,7 @@
 
 import "dotenv/config";
 import { beginSubmitNotificationHubJob, createClientContext } from "@azure/notification-hubs/api";
-import { NotificationHubJob } from "@azure/notification-hubs/models";
+import type { NotificationHubJob, NotificationHubJobPoller } from "@azure/notification-hubs/models";
 
 // Define connection string and hub name
 const connectionString = process.env.NOTIFICATIONHUBS_CONNECTION_STRING || "<connection string>";
@@ -31,7 +31,10 @@ async function main(): Promise<void> {
     type: "ExportRegistrations",
   };
 
-  const poller = await beginSubmitNotificationHubJob(context, exportJob);
+  const poller = (await beginSubmitNotificationHubJob(
+    context,
+    exportJob,
+  )) as unknown as NotificationHubJobPoller;
   exportJob = await poller.pollUntilDone();
 
   console.log(`Notification Hub Job status: ${exportJob.status}`);
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/exportRegistrationsJob.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/exportRegistrationsJob.ts
@@ -18,7 +18,7 @@ import {
   getNotificationHubJob,
   submitNotificationHubJob,
 } from "@azure/notification-hubs/api";
-import { NotificationHubJob } from "@azure/notification-hubs/models";
+import type { NotificationHubJob } from "@azure/notification-hubs/models";
 import { delay } from "@azure/core-util";
 
 // Define connection string and hub name
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/importRegistrationsJob.poller.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/importRegistrationsJob.poller.ts
@@ -14,7 +14,7 @@
 
 import "dotenv/config";
 import { beginSubmitNotificationHubJob, createClientContext } from "@azure/notification-hubs/api";
-import { NotificationHubJob } from "@azure/notification-hubs/models";
+import type { NotificationHubJob, NotificationHubJobPoller } from "@azure/notification-hubs/models";
 
 // Define connection string and hub name
 const connectionString = process.env.NOTIFICATIONHUBS_CONNECTION_STRING || "<connection string>";
@@ -33,7 +33,10 @@ async function main(): Promise<void> {
     type: "ImportCreateRegistrations",
   };
 
-  const poller = await beginSubmitNotificationHubJob(context, importJob);
+  const poller = (await beginSubmitNotificationHubJob(
+    context,
+    importJob,
+  )) as unknown as NotificationHubJobPoller;
   importJob = await poller.pollUntilDone();
 
   console.log(`Notification Hub Job status: ${importJob.status}`);
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/importRegistrationsJob.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/importRegistrationsJob.ts
@@ -1,5 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
+
 /**
  * This sample demonstrates how the createNotificationJob() method can be used to import registrations
  * descriptions from an existing set of exports.
@@ -17,7 +18,7 @@ import {
   getNotificationHubJob,
   submitNotificationHubJob,
 } from "@azure/notification-hubs/api";
-import { NotificationHubJob } from "@azure/notification-hubs/models";
+import type { NotificationHubJob } from "@azure/notification-hubs/models";
 import { delay } from "@azure/core-util";
 
 // Define connection string and hub name
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/listRegistrationsByChannel.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/listRegistrationsByChannel.ts
@@ -14,7 +14,7 @@
 
 import "dotenv/config";
 import { createClientContext, listRegistrationsByChannel } from "@azure/notification-hubs/api";
-import { AppleRegistrationChannel } from "@azure/notification-hubs/models";
+import type { AppleRegistrationChannel } from "@azure/notification-hubs/models";
 
 // Define connection string and hub name
 const connectionString = process.env.NOTIFICATIONHUBS_CONNECTION_STRING || "<connection string>";
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendBroadcastNotification.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendBroadcastNotification.ts
@@ -15,15 +15,15 @@
 
 import "dotenv/config";
 import {
-  NotificationHubsClientContext,
+  type NotificationHubsClientContext,
   createClientContext,
   getNotificationOutcomeDetails,
   sendBroadcastNotification,
 } from "@azure/notification-hubs/api";
 import {
   createAppleNotification,
-  NotificationDetails,
-  NotificationOutcomeState,
+  type NotificationDetails,
+  type NotificationOutcomeState,
 } from "@azure/notification-hubs/models";
 import { delay } from "@azure/core-util";
 
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotification.fcmLegacy.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotification.fcmLegacy.ts
@@ -15,12 +15,12 @@
 
 import "dotenv/config";
 import {
-  NotificationDetails,
-  NotificationOutcomeState,
+  type NotificationDetails,
+  type NotificationOutcomeState,
   createFcmLegacyNotification,
 } from "@azure/notification-hubs/models";
 import {
-  NotificationHubsClientContext,
+  type NotificationHubsClientContext,
   createClientContext,
   getNotificationOutcomeDetails,
   sendNotification,
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotification.fcmV1.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotification.fcmV1.ts
@@ -15,12 +15,12 @@
 
 import "dotenv/config";
 import {
-  NotificationDetails,
-  NotificationOutcomeState,
+  type NotificationDetails,
+  type NotificationOutcomeState,
   createFcmV1Notification,
 } from "@azure/notification-hubs/models";
 import {
-  NotificationHubsClientContext,
+  type NotificationHubsClientContext,
   createClientContext,
   getNotificationOutcomeDetails,
   sendNotification,
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotification.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotification.ts
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotificationBatch.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotificationBatch.ts
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendTagExpression.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendTagExpression.ts
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendTagsList.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendTagsList.ts
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/updateInstallation.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/updateInstallation.ts
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/updateRegistration.ts b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/updateRegistration.ts
diff --git a/sdk/notificationhubs/notification-hubs/samples/v2/typescript/tsconfig.json b/sdk/notificationhubs/notification-hubs/samples/v2/typescript/tsconfig.json
