address review comments.

Author: haiyuazhang

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/ResourceClientProvider.cs

@@ -370,22 +370,21 @@ private IReadOnlyList<MethodBodyStatement> BuildLroHandling(
             var statements = new List<MethodBodyStatement>();
 
             var finalStateVia = method.GetOperationFinalStateVia();
-            var responseBodyInputType = method.GetResponseBodyInputType();
-            var isNullBody = responseBodyInputType == null;
+            var isGeneric = method.GetResponseBodyType == null;
 
-            var armOperationType = isNullBody
+            var armOperationType = isGeneric
                 ? ManagementClientGenerator.Instance.OutputLibrary.ArmOperation.Type
                 : ManagementClientGenerator.Instance.OutputLibrary.GenericArmOperation.Type.MakeGenericType([resourceClientType]);
 
             ValueExpression[] armOperationArguments = [
                 _clientDiagnosticsField,
                 This.Property("Pipeline"),
                 messageVariable.Property("Request"),
-                isNullBody ? responseVariable : responseVariable.Invoke("GetRawResponse"),
+                isGeneric ? responseVariable : responseVariable.Invoke("GetRawResponse"),
                 Static(typeof(OperationFinalStateVia)).Property(finalStateVia.ToString())
             ];
 
-            var operationInstanceArguments = isNullBody
+            var operationInstanceArguments = isGeneric
                 ? armOperationArguments
                 : [New.Instance(operationSourceType, armClientProperty), .. armOperationArguments];
 
@@ -395,8 +394,8 @@ private IReadOnlyList<MethodBodyStatement> BuildLroHandling(
             var waitIfCompletedStatement = new IfStatement(KnownAzureParameters.WaitUntil.Equal(Static(typeof(WaitUntil)).Property(nameof(WaitUntil.Completed))))
             {
                 isAsync
-                ? operationVariable.Invoke(isNullBody ? "WaitForCompletionResponseAsync" : "WaitForCompletionAsync", [cancellationTokenParameter], null, isAsync).Terminate()
-                : operationVariable.Invoke(isNullBody ? "WaitForCompletionResponse" : "WaitForCompletion", cancellationTokenParameter).Terminate()
+                ? operationVariable.Invoke(isGeneric ? "WaitForCompletionResponseAsync" : "WaitForCompletionAsync", [cancellationTokenParameter], null, isAsync).Terminate()
+                : operationVariable.Invoke(isGeneric ? "WaitForCompletionResponse" : "WaitForCompletion", cancellationTokenParameter).Terminate()
             };
             statements.Add(waitIfCompletedStatement);
 

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/InputMethodExtensions.cs renamed to eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/InputServiceMethodExtensions.cs

@@ -8,20 +8,13 @@
 
 namespace Azure.Generator.Management.Utilities
 {
-    internal static class InputMethodExtensions
+    internal static class InputServiceMethodExtensions
     {
         public static bool IsLongRunningOperation(this InputServiceMethod method)
         {
             return method is InputLongRunningServiceMethod || method is InputLongRunningPagingServiceMethod;
         }
 
-        public static InputType? GetResponseBodyInputType(this InputServiceMethod method)
-        {
-            var operationResponses = method.Operation.Responses;
-            var response = operationResponses.FirstOrDefault(r => !r.IsErrorResponse);
-            return response?.BodyType;
-        }
-
         public static OperationFinalStateVia GetOperationFinalStateVia(this InputServiceMethod method)
         {
             if (method is InputLongRunningServiceMethod lroMethod)
@@ -35,16 +28,18 @@ public static OperationFinalStateVia GetOperationFinalStateVia(this InputService
             return OperationFinalStateVia.Location;
         }
 
-        public static CSharpType? GetResponseBodyCSharpType(this InputServiceMethod method)
+        public static CSharpType? GetResponseBodyType(this InputServiceMethod method)
         {
-            var responseBodyType = method.GetResponseBodyInputType();
+            var operationResponses = method.Operation.Responses;
+            var response = operationResponses.FirstOrDefault(r => !r.IsErrorResponse);
+            var responseBodyType = response?.BodyType;
             return responseBodyType is null ? null : ManagementClientGenerator.Instance.TypeFactory.CreateCSharpType(responseBodyType);
         }
 
         public static CSharpType GetOperationMethodReturnType(this InputServiceMethod method, bool isAsync, CSharpType resourceClientCSharpType, CSharpType resourceDataType)
         {
             bool isLongRunningOperation = method.IsLongRunningOperation();
-            var responseBodyCSharpType = method.GetResponseBodyCSharpType();
+            var responseBodyCSharpType = method.GetResponseBodyType();
             CSharpType rawReturnType = method.GetOperationMethodRawReturnType(resourceClientCSharpType, resourceDataType);
 
             if (isLongRunningOperation)
@@ -63,7 +58,7 @@ public static CSharpType GetOperationMethodReturnType(this InputServiceMethod me
 
         private static CSharpType GetOperationMethodRawReturnType(this InputServiceMethod method, CSharpType resourceClientCSharpType, CSharpType resourceDataType)
         {
-            var responseBodyCSharpType = method.GetResponseBodyCSharpType();
+            var responseBodyCSharpType = method.GetResponseBodyType();
             CSharpType genericReturnType = resourceClientCSharpType;
 
             if (responseBodyCSharpType is not null && responseBodyCSharpType != resourceDataType)