[BUG] ADF Pipeline Runs query can't do pagination

[DavidKarlas]

Library name and version

Azure.ResourceManager.DataFactory 1.0.0-beta.4

Describe the bug

Can't query more than 100 PipelineRuns via API because ContinuationToken is not exposed.
Only way to call Pipeline Runs - Query By Factory is by calling DataFactoryResource.GetPipelineRunsAsync.
Problem is that all you get from this call is AsyncPageable<DataFactoryPipelineRunInfo> which means ContinuationToken value is lost...
Since pagination is implemented via RunFilterContent property it means "default" nextLink logic for pages can't work...

Expected behavior

Ideally DataFactoryResource.GetPipelineRunsAsync would do whole pagination itself with ContinuationToken hidden away, but getting ContinuationToken is also acceptable I guess.

Actual behavior

No way to do pagination...

Reproduction Steps

Have ADF with more than 100 pipeline runs and try to query them...
I guess only way today would be by requesting ordered by update time, and keep updating RunFilterContent.LastUpdatedAfter, which feels a bit tricky, do I need to do minus one second?

Environment

Visual Studio 17.8

[jsquire]

Thank you for your feedback. Tagging and routing to the team member best able to assist.

[ruowan]

Thanks @DavidKarlas I can reproduce this issue locally. The root cause is ContinuationToken is somehow hidden by SDK, client cannot get the nextPage result. @ArthurMa1978 need your help on this issues

[archerzz]

I think in track2 mgmt, this method was generated as pageable method in a way the customers didn't expect.

• Here is the swagger definition, as you can see, it's not marked as x-ms-pageable, and as @ruowan indicated, this method provides a non-standard way to do the pagination.
• In track1 SDK, this method is not pageable.
• The problem is in our v3 generator, we'll make a List method as pageable.

So, in this case, a custom pageable operation is considered a List operation so that it is generated as a pageable method. Customers took it from granted that this new method will do the custom pagination.

[DavidKarlas]

While I have you all here, could someone please take a look into #39187 and Azure/azure-rest-api-specs#26334 that fixes it... Thank you!

[ArthurMa1978]

I think in track2 mgmt, this method was generated as pageable method in a way the customers didn't expect.

• Here is the swagger definition, as you can see, it's not marked as x-ms-pageable, and as @ruowan

          Ruoxuan Wang
          FTE indicated, this method provides a non-standard way to do the pagination.
  

• In track1 SDK, this method is not pageable.

• The problem is in our v3 generator, we'll make a List method as pageable.

So, in this case, a custom pageable operation is considered a List operation so that it is generated as a pageable method. Customers took it from granted that this new method will do the custom pagination.

Think about to support this kind of pagination operation, which uses token to get next page.